Bug#400600: [Pkg-cryptsetup-devel] Bug#400600: please clarify role of /lib/cryptsetup/cryptdisks.functions

2006-11-28 Thread Jonas Meurer
On 27/11/2006 David Härdeman wrote:
 But now these scripts just exit with an OK status if this file is not
 present/readable... Under my assumption above it should be a grave error
 instead.
 
 No, because the init scripts can under some conditions still be left on 
 your system even after you've removed the cryptsetup package. Checking 
 in init.d scripts for some necessary components and silently exiting if 
 they're missing is quite common.
 
 Example - /etc/init.d/postgresql-8.1
 line 17:  [ -r /usr/share/postgresql-common/init.d-functions ] || exit 0

 It would be nice if README.Debian provided documentation how the scripts 
 are intended to work together.
 
 Why? If the cryptdisks.functions script is missing even though you haven't 
 removed the cryptsetup package from your system something is seriously 
 broken.

I agree with that opinion. Init scripts and other configuration files
stay on your system if the package is removed but not purged. Therefore
it is even better if the scripts silently exit in this situation.

Robert do you have any objections against closing this bugreport?

...
 jonas


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#400600: please clarify role of /lib/cryptsetup/cryptdisks.functions

2006-11-27 Thread Robert Bihlmeyer
Package: cryptsetup
Version: 2:1.0.4-8
Severity: wishlist

I originally thought that /lib/cryptsetup/cryptdisks.functions is just to share
code between the scripts /etc/init.d/cryptdisks{,-early}.

But now these scripts just exit with an OK status if this file is not
present/readable... Under my assumption above it should be a grave error
instead.

It would be nice if README.Debian provided documentation how the scripts are
intended to work together.

-- 
Robbe


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#400600: [Pkg-cryptsetup-devel] Bug#400600: please clarify role of /lib/cryptsetup/cryptdisks.functions

2006-11-27 Thread David Härdeman

On Mon, Nov 27, 2006 at 03:47:22PM +0100, Robert Bihlmeyer wrote:

Package: cryptsetup
Version: 2:1.0.4-8
Severity: wishlist

I originally thought that /lib/cryptsetup/cryptdisks.functions is just to share
code between the scripts /etc/init.d/cryptdisks{,-early}.


It is


But now these scripts just exit with an OK status if this file is not
present/readable... Under my assumption above it should be a grave error
instead.


No, because the init scripts can under some conditions still be left on 
your system even after you've removed the cryptsetup package. Checking 
in init.d scripts for some necessary components and silently exiting if 
they're missing is quite common.


Example - /etc/init.d/postgresql-8.1
line 17:  [ -r /usr/share/postgresql-common/init.d-functions ] || exit 0


It would be nice if README.Debian provided documentation how the scripts are
intended to work together.


Why? If the cryptdisks.functions script is missing even though you haven't 
removed the cryptsetup package from your system something is seriously 
broken.


--
David Härdeman