Bug#401430: glpi: Please *do* fix this bug

2006-12-16 Thread Pierre Chifflier
Hi,

Here is a new version of the templates.pot file.

Regards,
Pierre
# SOME DESCRIPTIVE TITLE.
# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
# This file is distributed under the same license as the PACKAGE package.
# FIRST AUTHOR [EMAIL PROTECTED], YEAR.
#
#, fuzzy
msgid 
msgstr 
Project-Id-Version: PACKAGE VERSION\n
Report-Msgid-Bugs-To: [EMAIL PROTECTED]
POT-Creation-Date: 2006-12-10 16:58+0100\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME [EMAIL PROTECTED]\n
Language-Team: LANGUAGE [EMAIL PROTECTED]\n
MIME-Version: 1.0\n
Content-Type: text/plain; charset=CHARSET\n
Content-Transfer-Encoding: 8bit\n

#. Type: multiselect
#. Choices
#: ../glpi.templates:1001
msgid apache, apache-ssl, apache-perl, apache2
msgstr 

#. Type: multiselect
#. Description
#: ../glpi.templates:1002
msgid Which web server would you like to reconfigure automatically:
msgstr 

#. Type: multiselect
#. Description
#: ../glpi.templates:1002
msgid 
If you do not select a web server to reconfigure automatically, glpi will 
not be usable until you reconfigure your webserver to enable glpi.
msgstr 

#. Type: boolean
#. Description
#: ../glpi.templates:2001
msgid Should ${webserver} be restarted?
msgstr 

#. Type: boolean
#. Description
#: ../glpi.templates:2001
msgid 
Remember that in order to activate the new configuration ${webserver} has to 
be restarted. You can also restart ${webserver} by manually executing invoke-
rc.d ${webserver} restart.
msgstr 

#. Type: note
#. Description
#: ../glpi.templates:3001
msgid glpi configuration
msgstr 

#. Type: note
#. Description
#: ../glpi.templates:3001
msgid 
Please point your browser to http://server/glpi/ to finish the 
configuration.
msgstr 


Bug#401430: glpi: Please *do* fix this bug

2006-12-16 Thread Christian Perrier
 #. Type: multiselect
 #. Description
 #: ../glpi.templates:1002
 msgid Which web server would you like to reconfigure automatically:

Hmmm, worded like a question but not exactly a question. As
interrogative form is discouraged for select/multiselect, I'd suggest:

Web server to reconfigure automatically:


 #. Type: boolean
 #. Description
 #: ../glpi.templates:2001
 msgid 
 Remember that in order to activate the new configuration ${webserver} has to 
 
 be restarted. You can also restart ${webserver} by manually executing 
 invoke-
 rc.d ${webserver} restart.
 msgstr 
 
 #. Type: note
 #. Description
 #: ../glpi.templates:3001
 msgid glpi configuration
 msgstr 
 
 #. Type: note
 #. Description
 #: ../glpi.templates:3001
 msgid 
 Please point your browser to http://server/glpi/ to finish the 
 configuration.
 msgstr 


I think that this last note template is debconf abuse. This should go
to README.Debian

Apart from that, the templates file seems correct.

-- 




signature.asc
Description: Digital signature


Bug#401430: glpi: Please *do* fix this bug

2006-12-16 Thread Pierre Chifflier
On Sat, Dec 16, 2006 at 02:27:50PM +0100, Christian Perrier wrote:
  #. Type: multiselect
  #. Description
  #: ../glpi.templates:1002
  msgid Which web server would you like to reconfigure automatically:
 
 Hmmm, worded like a question but not exactly a question. As
 interrogative form is discouraged for select/multiselect, I'd suggest:
 
 Web server to reconfigure automatically:

Oh, I forgot this one - new template attached.

[...]
 I think that this last note template is debconf abuse. This should go
 to README.Debian
 

The warning (to finish the configuration) is important. Of course, in
an ideal world, it wouldn't be needed since all users should read
README.Debian, but where not in this kind of world :/
It's also here to inform that the configuration is
_not_ finished and that it needs some action (as opposite to many
debian packages which are left in a safe state after installation).

Pierre


# SOME DESCRIPTIVE TITLE.
# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
# This file is distributed under the same license as the PACKAGE package.
# FIRST AUTHOR [EMAIL PROTECTED], YEAR.
#
#, fuzzy
msgid 
msgstr 
Project-Id-Version: PACKAGE VERSION\n
Report-Msgid-Bugs-To: [EMAIL PROTECTED]
POT-Creation-Date: 2006-12-16 15:28+0100\n
PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
Last-Translator: FULL NAME [EMAIL PROTECTED]\n
Language-Team: LANGUAGE [EMAIL PROTECTED]\n
MIME-Version: 1.0\n
Content-Type: text/plain; charset=CHARSET\n
Content-Transfer-Encoding: 8bit\n

#. Type: multiselect
#. Choices
#: ../glpi.templates:1001
msgid apache, apache-ssl, apache-perl, apache2
msgstr 

#. Type: multiselect
#. Description
#: ../glpi.templates:1002
msgid Web server to reconfigure automatically:
msgstr 

#. Type: multiselect
#. Description
#: ../glpi.templates:1002
msgid 
If you do not select a web server to reconfigure automatically, glpi will 
not be usable until you reconfigure your webserver to enable glpi.
msgstr 

#. Type: boolean
#. Description
#: ../glpi.templates:2001
msgid Should ${webserver} be restarted?
msgstr 

#. Type: boolean
#. Description
#: ../glpi.templates:2001
msgid 
Remember that in order to activate the new configuration ${webserver} has to 
be restarted. You can also restart ${webserver} by manually executing invoke-
rc.d ${webserver} restart.
msgstr 

#. Type: note
#. Description
#: ../glpi.templates:3001
msgid glpi configuration
msgstr 

#. Type: note
#. Description
#: ../glpi.templates:3001
msgid 
Please point your browser to http://server/glpi/ to finish the 
configuration.
msgstr 


Bug#401430: glpi: Please *do* fix this bug

2006-12-16 Thread Christian Perrier

 The warning (to finish the configuration) is important. Of course, in
 an ideal world, it wouldn't be needed since all users should read
 README.Debian, but where not in this kind of world :/
 It's also here to inform that the configuration is
 _not_ finished and that it needs some action (as opposite to many
 debian packages which are left in a safe state after installation).


Thankfully, not all package maintainer think this way, otherwise we
would still have installs cluttered by numerous annoying warnings.

Assuming that your users are dumb is not smart for the clever ones.

Anyway, I will probably not convince you this time. We'll see what
happens when the support for notes will be removed from debconf..:-)




signature.asc
Description: Digital signature


Bug#401430: glpi: Please *do* fix this bug

2006-12-16 Thread Pierre Chifflier
On Sat, Dec 16, 2006 at 06:04:26PM +0100, Christian Perrier wrote:
 
  The warning (to finish the configuration) is important. Of course, in
  an ideal world, it wouldn't be needed since all users should read
  README.Debian, but where not in this kind of world :/
  It's also here to inform that the configuration is
  _not_ finished and that it needs some action (as opposite to many
  debian packages which are left in a safe state after installation).
 
 
 Thankfully, not all package maintainer think this way, otherwise we
 would still have installs cluttered by numerous annoying warnings.
 
 Assuming that your users are dumb is not smart for the clever ones.
 
 Anyway, I will probably not convince you this time. We'll see what
 happens when the support for notes will be removed from debconf..:-)
 

Please stop that. This is not taking users for dumb people, this is
warning them for something important, which can potentially be a
security problem (since anyone can access the php scripts and mysql
database while the application is not configured).

While what you are trying to do (remove useless debconf notes) is
good, do not take it as a ultimate goal without any real reason. Some
notes are *really* important, and if notes is note the correct way,
then another must be provided, because some matters are important (and
security is one of them, even if you have no clue about that). I
already explained that, while most packages leave the system in a safe
way after installation (even if configuration is not changed after),
this is not the case of glpi, since the application does *all*
configuration by the web.

So I'll explain this once: either you have some idea on how to help
(warning the user that something important has to be done ASAP), or
you just want to carry on your personal war vs debconf notes (in this
case, consider the bug report as closed).

Pierre


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#401430: glpi: Please *do* fix this bug

2006-12-09 Thread Christian Perrier
Package: glpi
Followup-For: Bug #401430

This broken template currently makes the translation effort pointless.
Please fix this bug.

Moreover, the broken template is obvious debconf abuse. The information you
give here should be added to README.Debian but not interrupt installs of
your package.

I propose you two patches:

patch1: fixes the broken template, but keep it. I prefer my patch to the one
proposed by Thomas

patch2: removes the abusive note

In both cases, if you do fix this bug, please do NOT upload the package
immediately as the French l10n team is working on the French translation of
the templates. Instead, please send me the new debian/po/templates.pot file
after applying one of our patches and running debconf-updatepo.

-- System Information:
Debian Release: 4.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.18-2-686
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8) (ignored: LC_ALL 
set to fr_FR.UTF-8)
diff -Nru glpi-0.68.2.old/debian/glpi.templates 
glpi-0.68.2/debian/glpi.templates
--- glpi-0.68.2.old/debian/glpi.templates   2006-12-09 08:06:11.524071094 
+0100
+++ glpi-0.68.2/debian/glpi.templates   2006-12-09 08:06:57.712387292 +0100
@@ -1,6 +1,6 @@
 Template: glpi/webserver
 Type: multiselect
-_Choices: apache, apache-ssl, apache-perl, apache2
+__Choices: apache, apache-ssl, apache-perl, apache2
 Default: apache, apache-ssl, apache-perl, apache2
 _Description: Which web server would you like to reconfigure automatically:
  If you do not select a web server to reconfigure automatically, glpi will
@@ -16,5 +16,5 @@
 
 Template: glpi/configuration
 Type: note
-_Description: Please point your browser to http://server/glpi/ to finish
- the configuration.
+_Description: Glpi configuration
+ Please point your browser to http://server/glpi/ to finish the 
configuration.
diff -Nru glpi-0.68.2.old/debian/po/templates.pot 
glpi-0.68.2/debian/po/templates.pot
--- glpi-0.68.2.old/debian/po/templates.pot 2006-12-09 08:06:11.540071203 
+0100
+++ glpi-0.68.2/debian/po/templates.pot 2006-12-09 08:08:16.100924108 +0100
@@ -1,14 +1,22 @@
-# SOME DESCRIPTIVE TITLE.
-# Copyright (C) YEAR THE PACKAGE'S COPYRIGHT HOLDER
-# This file is distributed under the same license as the PACKAGE package.
-# FIRST AUTHOR [EMAIL PROTECTED], YEAR.
+#
+#Translators, if you are not familiar with the PO format, gettext
+#documentation is worth reading, especially sections dedicated to
+#this format, e.g. by running:
+# info -n '(gettext)PO Files'
+# info -n '(gettext)Header Entry'
+#
+#Some information specific to po-debconf are available at
+#/usr/share/doc/po-debconf/README-trans
+# or http://www.debian.org/intl/l10n/po-debconf/README-trans
+#
+#Developers do not need to manually edit POT or PO files.
 #
 #, fuzzy
 msgid 
 msgstr 
 Project-Id-Version: PACKAGE VERSION\n
-Report-Msgid-Bugs-To: [EMAIL PROTECTED]
-POT-Creation-Date: 2006-11-06 13:52+0100\n
+Report-Msgid-Bugs-To: \n
+POT-Creation-Date: 2006-12-09 08:08+0100\n
 PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n
 Last-Translator: FULL NAME [EMAIL PROTECTED]\n
 Language-Team: LANGUAGE [EMAIL PROTECTED]\n
@@ -19,7 +27,25 @@
 #. Type: multiselect
 #. Choices
 #: ../glpi.templates:1001
-msgid apache, apache-ssl, apache-perl, apache2
+msgid apache
+msgstr 
+
+#. Type: multiselect
+#. Choices
+#: ../glpi.templates:1001
+msgid apache-ssl
+msgstr 
+
+#. Type: multiselect
+#. Choices
+#: ../glpi.templates:1001
+msgid apache-perl
+msgstr 
+
+#. Type: multiselect
+#. Choices
+#: ../glpi.templates:1001
+msgid apache2
 msgstr 
 
 #. Type: multiselect
@@ -54,11 +80,13 @@
 #. Type: note
 #. Description
 #: ../glpi.templates:3001
-msgid Please point your browser to http://server/glpi/ to finish
+msgid Glpi configuration
 msgstr 
 
 #. Type: note
 #. Description
 #: ../glpi.templates:3001
-msgid the configuration.
+msgid 
+Please point your browser to http://server/glpi/ to finish the 
+configuration.
 msgstr 
diff -Nru glpi-0.68.2.old/debian/glpi.config glpi-0.68.2/debian/glpi.config
--- glpi-0.68.2.old/debian/glpi.config  2006-12-09 08:06:11.536071176 +0100
+++ glpi-0.68.2/debian/glpi.config  2006-12-09 08:08:43.909114595 +0100
@@ -17,6 +17,5 @@
   dbc_go glpi $@
 fi
 
-db_input high glpi/configuration || true
 db_go
 
diff -Nru glpi-0.68.2.old/debian/glpi.templates 
glpi-0.68.2/debian/glpi.templates
--- glpi-0.68.2.old/debian/glpi.templates   2006-12-09 08:06:11.524071094 
+0100
+++ glpi-0.68.2/debian/glpi.templates   2006-12-09 08:08:54.277185625 +0100
@@ -1,6 +1,6 @@
 Template: glpi/webserver
 Type: multiselect
-_Choices: apache, apache-ssl, apache-perl, apache2
+__Choices: apache, apache-ssl, apache-perl, apache2
 Default: apache, apache-ssl, apache-perl, apache2
 _Description: Which web server would you like to reconfigure automatically:
  If you do not select a web server to reconfigure automatically, glpi