Bug#401698: please add reentrancy check to update-ms-fonts

[Thijs Kinkhorst]

On Tue, 2006-12-05 at 15:51 +0300, Nikita V. Youshchenko wrote:
 I think that update-ms-fonts should have some guard against re-entrancy.

I'm not opposed to the idea, but am not implementing it before etch -
the scenario is not that common and I don't want to risk destabilisation
now.

Were there any adverse effects of the parallel runs? What happened?


Thijs


signature.asc
Description: This is a digitally signed message part

Bug#401698: please add reentrancy check to update-ms-fonts

[Nikita V. Youshchenko]

  I think that update-ms-fonts should have some guard against
  re-entrancy.

 I'm not opposed to the idea, but am not implementing it before etch -
 the scenario is not that common and I don't want to risk destabilisation
 now.

Sure.

 Were there any adverse effects of the parallel runs? What happened?

I just pressed Ctrl+C immediately, so nothing bad happened.

Don't know if any breakage is possible if two scripts will start to unpack 
the fonts in parrallel at the same time to the same location. However 
races are always bad...

Btw, a simple solution is just not to install user-runnable update-msfonts, 
but do things in postinst only (either by moving code into postinst, or 
maybe to some location under /usr/share (not in PATH - so not intended to 
be manually executed). This way, dpkg-level locking will avoid execution 
of several instances. And if re-running is ever needed, there is 
dpkg-reconfigure.


pgpPuhAKOqG8Y.pgp
Description: PGP signature

Bug#401698: please add reentrancy check to update-ms-fonts

[Nikita V. Youshchenko]

Package: msttcorefonts
Version: 1.2
Severity: minor

With current version of msttcodefonts, /usr/sbin/update-ms-fonts could
be easylly called several times in parallel. This just happened for me,
with the following (not so unlikely) scenario:

- apt-get install msttcorefonts,

- downloading fonts failed, because machine is firewalled, and wgetrc
  was not yet configured to go through proxy,

- so msttcore package was left unconfigured

- I then configured proxy and executed update-ms-fonts - that looked
  natural for me

- then I switched to other console and executed apt-get install to
  install other packages

- and then apt-get decided to configure msttcorefonts, and started
  second instance of update-ms-fonts while first one was still
  downloading (network connection was not good today so it did not
  finished yet)

I think that update-ms-fonts should have some guard against re-entrancy.

-- System Information:
Debian Release: 3.1
  APT prefers proposed-updates
  APT policy: (640, 'proposed-updates'), (640, 'stable'), (620, 
'testing-proposed-updates'), (620, 'testing'), (600, 'unstable'), (550, 
'experimental')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.16
Locale: LANG=ru_RU.KOI8-R, LC_CTYPE=ru_RU.KOI8-R (charmap=KOI8-R)

Versions of packages msttcorefonts depends on:
ii  cabextract 1.1-1 a program to extract Microsoft Cab
ii  debconf1.4.30.13 Debian configuration management sy
ii  debianutils2.8.4 Miscellaneous utilities specific t
ii  defoma 0.11.8-0.1Debian Font Manager -- automatic f
ii  wget   1.10.2-1  retrieves files from the web
ii  xutils 4.3.0.dfsg.1-14sarge2 X Window System utility programs

Versions of packages msttcorefonts recommends:
ii  x-ttcidfont-conf  17 Configure TrueType and CID fonts f

-- debconf information excluded


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]