Bug#402622: bug still not fixed

2006-12-18 Thread Josselin Mouette
Le samedi 16 décembre 2006 à 00:16 +0100, Marco d'Itri a écrit :
 On Dec 14, Hendrik Sattler [EMAIL PROTECTED] wrote:
 
  Let's say it this way: which devices that use the MMC protocol (or SD 
  storage) 
  are non-removable?
 Nevermind, I tought that the MTD drivers shared the same infrastructure.
 I will upload a new udev package forcing all mmc, firewire, usb and
 pcmcia block devices to be owned by the floppy group (as usual, patches
 are welcome).

Does this mean the plugdev group is going away?

-- 
Josselin Mouette/\./\

Do you have any more insane proposals for me?


signature.asc
Description: Ceci est une partie de message	numériquement signée


Bug#402649: Bug#402622: bug still not fixed

2006-12-16 Thread Marco d'Itri
On Dec 14, Hendrik Sattler [EMAIL PROTECTED] wrote:

 Let's say it this way: which devices that use the MMC protocol (or SD 
 storage) 
 are non-removable?
Nevermind, I tought that the MTD drivers shared the same infrastructure.
I will upload a new udev package forcing all mmc, firewire, usb and
pcmcia block devices to be owned by the floppy group (as usual, patches
are welcome).

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#402622: bug still not fixed

2006-12-14 Thread Marco d'Itri
On Dec 14, Modestas Vainius [EMAIL PROTECTED] wrote:

 2006 m. gruodis 11 d., pirmadienis 20:33, Marco d'Itri raš?:
  I do not think that every mmc* block device is removable,
 What do you think about following pmount policy on determining removable 
 block 
 devices? I think it would be a reasonable thing to do.
I don't, I believe that pmount is buggy and this is a security hole.
While you can be pretty much sure that every USB and firewire device is
removable, the same is not true for MMC devices.

This is also related to #402649 (which I am not actually sure is a
regression, I do not remember special-casing USB block devices in the
past).
It may be a viable strategy to consider every usb and firewire block
device to be removable, but I would not extend this to MMC devices.
Advice is welcome.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#402622: bug still not fixed

2006-12-14 Thread Modestas Vainius
Hi,

2006 m. gruodis 14 d., ketvirtadienis 21:01, Marco d'Itri rašė:
 I don't, I believe that pmount is buggy and this is a security hole.
 While you can be pretty much sure that every USB and firewire device is
 removable, the same is not true for MMC devices.

 This is also related to #402649 (which I am not actually sure is a
 regression, I do not remember special-casing USB block devices in the
 past).
HAL seems to do the same (hald/linux/blockdev.c:894):

} else if (strcmp (bus, mmc) == 0) {
...
is_hotpluggable = TRUE;
...
break;
}

You might be right about such assumption being a security hole, however Debian 
etch will be released with pmount and HAL, which follow such policy, but are 
not considered RC buggy. Why is udev involved here? Incorrect permissions 
prevent a user to format removable media (no workaround) and in KDE 
mediamanager case, to eject the device since mediamanager uses /usr/bin/eject 
binary (which is run as effective user) directly. However, I'll do my best to 
workaround this limitation by implementing eject via HAL action (then HAL 
starts 'eject' as root so no permission problem; only HAL policy is 
followed).


pgp3PVOp3Dfw5.pgp
Description: PGP signature


Bug#402622: bug still not fixed

2006-12-13 Thread Modestas Vainius
Hi Marco,

2006 m. gruodis 11 d., pirmadienis 20:33, Marco d'Itri rašė:
 I do not think that every mmc* block device is removable,
What do you think about following pmount policy on determining removable block 
devices? I think it would be a reasonable thing to do.

Excerpt from `man pmount`:

o deviceisremovable(USB,FireWire,orMMC  device,  
or /sys/block/drive/removable is 1)

Excerpt from pmount-0.9.13/src/policy.c:366

int
device_removable( const char* device )
{
struct sysfs_device *dev;
static char* hotplug_buses[] = { usb, ieee1394, mmc, pcmcia, 
NULL };
int removable;
char blockdevpath[PATH_MAX];

dev = find_sysfs_device( device, blockdevpath, sizeof( blockdevpath ) );

[... snip ... ]

/* if not, fall back to bus scanning (regard USB and FireWire as 
removable) */
if( !removable )
removable = find_bus_ancestry( dev, hotplug_buses );
sysfs_close_device( dev );

[... snip ... ]

return removable;
}




pgp2y6pC2WUaS.pgp
Description: PGP signature


Bug#402622: bug still not fixed

2006-12-11 Thread Marco d'Itri
On Dec 11, Martin Hoppen [EMAIL PROTECTED] wrote:

  ATTRS{removable}==0

 udev does not recognise your SD card reader as removable. The only thing you 
Because as far as it knows, it's not.

I do not think that every mmc* block device is removable, so unless
somebody can tell me which one of these parent attributes I can use to
safely recognize which devices are removables and which ones are not I
cannot do anything sensible.
Somebody who knows about MMC/SD should be consulted.


 ATTRS{scr}==0125
 ATTRS{serial}==0x20cbe901
 ATTRS{oemid}==0x5344
 ATTRS{name}==SD01G
 ATTRS{manfid}==0x03
 ATTRS{hwrev}==0x8
 ATTRS{fwrev}==0x0
 ATTRS{date}==01/2006
 ATTRS{csd}==002600325f5983c8befbcfffd2404000
 ATTRS{cid}==03534453443031478020cbe901006100

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#402622: bug still not fixed

2006-12-11 Thread Modestas Vainius
Hi Martin, 

could you extract information related to your SD card reader (when a card is 
inserted and when it is not) from

$ lshal

?

$ lshal --monitor
$ hal-device-manager

might help in the process.


pgpV5MaN2KArB.pgp
Description: PGP signature


Bug#402622: bug still not fixed

2006-12-11 Thread Martin Hoppen
Hi Modestas, hi Marco,

On Monday 11 December 2006 19:43, Modestas Vainius wrote:
 Hi Martin,

 could you extract information related to your SD card reader (when a card
 is inserted and when it is not) from

 $ lshal

see attached files with output of lshal with card inserted and card removed


 ?

 $ lshal --monitor

inserting and removing the card gives me:

# lshal --monitor

Start monitoring devicelist:
-
pci_104c_8034_mmc_host_mmc_host_mmc_host_mmc_card_rca40956 added
pci_104c_8034_mmc_host_mmc_host_mmc_host_mmc_card_rca40956_storage added
volume_uuid_3130_3965 added
volume_uuid_3130_3965 removed
pci_104c_8034_mmc_host_mmc_host_mmc_host_mmc_card_rca40956 removed
pci_104c_8034_mmc_host_mmc_host_mmc_host_mmc_card_rca40956_storage removed

 $ hal-device-manager

what shall I show you using that tool?


 might help in the process.

Martin


lshal_card_inserted.bz2
Description: BZip2 compressed data


lshal_card_removed.bz2
Description: BZip2 compressed data