Bug#403983: wireless-tools: Needs to up interface before setting options
On Thu, Nov 13, 2008 at 10:35:36PM -0800, Steve Langasek wrote: Matthew, do you know if this is still needed for softmac? There's been at least one bug report against wireless-tools in Ubuntu complaining that it breaks other ifupdown functionality (https://bugs.launchpad.net/bugs/219520), so if it's safe to drop this diff now, I'd like for us to do that. I agree that conceptually, it's better to set all of the wireless variables before bringing up the interface. softmac's dead, so if it's not required for mac80211 I suspect it can die. -- Matthew Garrett | [EMAIL PROTECTED] -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#403983: wireless-tools: Needs to up interface before setting options
FWIW, Ubuntu has been carrying the attached patch to wireless-tools since 2006 (i.e., the time of Matthew's bug report). Matthew, do you know if this is still needed for softmac? There's been at least one bug report against wireless-tools in Ubuntu complaining that it breaks other ifupdown functionality (https://bugs.launchpad.net/bugs/219520), so if it's safe to drop this diff now, I'd like for us to do that. I agree that conceptually, it's better to set all of the wireless variables before bringing up the interface. Thanks, -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developerhttp://www.debian.org/ [EMAIL PROTECTED] [EMAIL PROTECTED] diff -Nru wireless-tools-29/debian/pre-up wireless-tools-29/debian/pre-up --- wireless-tools-29/debian/pre-up 2008-11-14 06:30:01.0 + +++ wireless-tools-29/debian/pre-up 2008-11-14 06:30:01.0 + @@ -1,11 +1,16 @@ #!/bin/sh IWCONFIG=/sbin/iwconfig +IFCONFIG=/sbin/ifconfig if [ ! -x $IWCONFIG ]; then exit 0 fi +if [ -x $IFCONFIG ]; then + $IFCONFIG $IFACE up +fi + if [ -n $IF_WIRELESS_SENS ]; then $IWCONFIG $IFACE sens $IF_WIRELESS_SENS fi
Bug#403983: wireless-tools: Needs to up interface before setting options
On Thu, Dec 21, 2006 at 02:39:52AM +, Matthew Garrett wrote: As described in http://lkml.org/lkml/2006/12/20/371 , various wireless drivers require that the interface be brought up before wireless options are set. As far as I can tell, the pre-up script doesn't currently do this. Unfortunately, some drivers also require the interface to be down before various wireless options are set. Some don't like option A to be set before option B, and others want it the other way around. Ideally, you want to set everything before bringing the interface up, to avoid being vulnerable in the time between it goes up and you set WEP keys, select ESSID, etcetera. That's why the Debian package contains a pre-up script. I can change it, it will fix some, but break other drivers. What I understand from upstream, who is also responsible for the Wireless Extensions itself, all drivers that require a certain order of events are buggy. -- Met vriendelijke groet / with kind regards, Guus Sliepen [EMAIL PROTECTED] signature.asc Description: Digital signature
Bug#403983: wireless-tools: Needs to up interface before setting options
Package: wireless-tools Severity: normal As described in http://lkml.org/lkml/2006/12/20/371 , various wireless drivers require that the interface be brought up before wireless options are set. As far as I can tell, the pre-up script doesn't currently do this. -- System Information: Debian Release: 3.1 Architecture: i386 (i686) Kernel: Linux 2.4.33 Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_GB.UTF-8) Versions of packages wireless-tools depends on: ii libc6 2.3.2.ds1-22sarge4 GNU C Library: Shared libraries an -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
