Bug#405656: Icedax bugreport: cd title lookup doesn't work
Package: icedax Version: 1.1.0-1 Hello! When I try to read a cd, icedax isn't able to lookup the cd title and tracks from a freedb server. Command: icedax -D /dev/dvd -L 0 cddbp-server=freedb2.freedb.org Part of the result: CDINDEX discid: NE5w4c6M3yfOfH2kAo3vDgrKEN0- CDDB discid: 0xef109f0f CD-Text: not detected CD-Extra: not detected samplefile size will be 45292508 bytes. I captured the conversation between icedax and the freedb server, which reveals a violation of the cddb protocol. There must not be a newline beteween the hello statement and the user: 201 mirror1.freedb.org CDDBP server v1.5.2PL0 ready at Fri Jan 05 08:31:19 2007 cddb hello bxt lysira icedax .11.1.0 500 Command syntax error. quit 230 mirror1.freedb.org Closing connection. Goodbye. Suggestion: Remove the newline after hello. Thanks Jan Goldenbaum -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer -- Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen! Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#405656: Icedax bugreport: cd title lookup doesn't work
#include hallo.h * [EMAIL PROTECTED] [Fri, Jan 05 2007, 12:12:45PM]: Package: icedax Version: 1.1.0-1 Hello! When I try to read a cd, icedax isn't able to lookup the cd title and tracks from a freedb server. Command: icedax -D /dev/dvd -L 0 cddbp-server=freedb2.freedb.org Part of the result: CDINDEX discid: NE5w4c6M3yfOfH2kAo3vDgrKEN0- CDDB discid: 0xef109f0f CD-Text: not detected CD-Extra: not detected samplefile size will be 45292508 bytes. I captured the conversation between icedax and the freedb server, which reveals a violation of the cddb protocol. There must not be a newline beteween the hello statement and the user: 201 mirror1.freedb.org CDDBP server v1.5.2PL0 ready at Fri Jan 05 08:31:19 2007 cddb hello bxt lysira icedax .11.1.0 Captured how? Icedax sends that in two separate chunks but not adding a newline between them. 500 Command syntax error. quit 230 mirror1.freedb.org Closing connection. Goodbye. Suggestion: Remove the newline after hello. AFAICS icedax does not send a newline. The only source of a newline therein can be your own username. Does it contain one? Eduard. -- Elric: We are dreamers, shapers, singers, and makers. We study the mysteries of laser and circuit, crystal and scanner, holographic demons and invocations of equations. These are the tools we employ, and we know many things. -- Quotes from Babylon 5 -- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#405656: Icedax bugreport: cd title lookup doesn't work
Hi! * Eduard Bloch [EMAIL PROTECTED] [070105 11:27 CET]: * [EMAIL PROTECTED] [Fri, Jan 05 2007, 12:12:45PM]: Package: icedax Version: 1.1.0-1 Hello! When I try to read a cd, icedax isn't able to lookup the cd title and tracks from a freedb server. Command: icedax -D /dev/dvd -L 0 cddbp-server=freedb2.freedb.org Part of the result: [...] 500 Command syntax error. quit 230 mirror1.freedb.org Closing connection. Goodbye. Here's a patch that will fix the bug: --- toc.c 2006-12-28 21:47:46.0 +0100 +++ toc_new.c 2007-01-06 02:11:06.0 +0100 @@ -1274,7 +1274,7 @@ } writen(sock_fd, hostname, strlen(hostname)); - writen(sock_fd, icedax , 10); + writen(sock_fd, icedax , 8); writen(sock_fd, VERSION, strlen(VERSION)); writen(sock_fd, \n, 1); Regards, Heiko -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#405656: Icedax bugreport: cd title lookup doesn't work
[Heiko Schlenker] Here's a patch that will fix the bug: I applied your patch, then I looked at it and realised that writen() itself is stupid and should just use strlen internally. So I fixed that (and renamed it writez()). Thanks! Peter signature.asc Description: Digital signature
