Bug#411851: Patch to make pm-utils restart sl-modem-daemon

2007-07-15 Thread Tim Dijkstra
On Tue, 10 Jul 2007 19:10:23 +0200
Julien Valroff [EMAIL PROTECTED] wrote:

 Hi Tim,
 
 Le jeudi 17 mai 2007 à 21:54 +0200, Tim Dijkstra (tdykstra) a écrit :
  Package: sl-modem-daemon
  Followup-For: Bug #411851
  
  As discussed, the best I can do is make pm-utils restart
  sl-modem-daemon.
  
  I'll attach a patch, I verified that the sl-modem-daemon package has the
  correct content now, I don't know about sl-modem-source.
 
 With the attached patch, I have an error in the pm-suspend.log:
   /var/run/pm-suspend: line 1: export `sl-modem-daemon_SERVICE_ACTIVATE=yes': 
 not a valid identifier

This is a bug in pm-utils. It doesn't accept a dash `-' in the service
name, which is a bit stupid. I'll try to fix that. 

grts Tim


signature.asc
Description: PGP signature


Bug#411851: Patch to make pm-utils restart sl-modem-daemon

2007-07-15 Thread Julien Valroff
Le dimanche 15 juillet 2007 à 10:02 +0200, Tim Dijkstra a écrit :
 
  With the attached patch, I have an error in the pm-suspend.log:
/var/run/pm-suspend: line 1: export
 `sl-modem-daemon_SERVICE_ACTIVATE=yes': not a valid identifier
 
 This is a bug in pm-utils. It doesn't accept a dash `-' in the service
 name, which is a bit stupid. I'll try to fix that. 

Great!

Do no hestitate to contact me if you need testers.

Cheers,
Julien





Bug#411851: Patch to make pm-utils restart sl-modem-daemon

2007-07-10 Thread Julien Valroff
Hi Tim,

Le jeudi 17 mai 2007 à 21:54 +0200, Tim Dijkstra (tdykstra) a écrit :
 Package: sl-modem-daemon
 Followup-For: Bug #411851
 
 As discussed, the best I can do is make pm-utils restart
 sl-modem-daemon.
 
 I'll attach a patch, I verified that the sl-modem-daemon package has the
 correct content now, I don't know about sl-modem-source.

With the attached patch, I have an error in the pm-suspend.log:
  /var/run/pm-suspend: line 1: export `sl-modem-daemon_SERVICE_ACTIVATE=yes': 
not a valid identifier

The service is not restarted on resume.

I guess the service shouldn't be stopped on suspend, which works.

Cheers,
Julien
diff -Nur sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon
--- sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon	1970-01-01 01:00:00.0 +0100
+++ sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon	2007-05-17 21:40:55.0 +0200
@@ -0,0 +1,16 @@
+#!/bin/bash
+
+. /usr/lib/pm-utils/functions
+
+case $1 in
+	thaw|resume)
+		restartservice sl-modem-daemon
+		;;
+	*)
+		;;
+esac
+
+exit $?
diff -Nur sl-modem-2.9.9d+e-pre2/debian/rules sl-modem-2.9.9d+e-pre2/debian/rules
--- sl-modem-2.9.9d+e-pre2/debian/rules	2007-05-17 21:32:04.0 +0200
+++ sl-modem-2.9.9d+e-pre2/debian/rules	2007-05-17 21:44:09.0 +0200
@@ -66,6 +66,8 @@
 	cp modem/slmodemd debian/sl-modem-daemon/usr/sbin/
 	cp debian/sl-modem-daemon.modutils debian/sl-modem-daemon/etc/modutils
 	cp debian/sl-modem-daemon.modutils debian/sl-modem-daemon/etc/modprobe.d
+	cp debian/15sl-modem-daemon debian/sl-modem-daemon/usr/lib/pm-utils/sleep.d
+	chmod a+x debian/sl-modem-daemon/usr/lib/pm-utils/sleep.d/15sl-modem-daemon
 	echo install slamr modprobe --ignore-install ungrab-winmodem ;  modprobe --ignore-install slamr; test -e /dev/slamr0 || (/bin/mknod -m 660 /dev/slamr0 c 242 0 2/dev/null  chgrp dialout /dev/slamr0)   debian/sl-modem-daemon/etc/modprobe.d/sl-modem-daemon.modutils
 	dh_installdocs -psl-modem-source debian/README.Debian README
 	dh_installdocs -psl-modem-daemon
diff -Nur sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs
--- sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs	2007-05-17 21:32:04.0 +0200
+++ sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs	2007-05-17 21:41:23.0 +0200
@@ -1,3 +1,4 @@
 usr/sbin
 etc/modutils
 etc/modprobe.d
+usr/lib/pm-utils/sleep.d



Bug#411851: Patch to make pm-utils restart sl-modem-daemon

2007-05-17 Thread Tim Dijkstra (tdykstra)
Package: sl-modem-daemon
Followup-For: Bug #411851

As discussed, the best I can do is make pm-utils restart
sl-modem-daemon.

I'll attach a patch, I verified that the sl-modem-daemon package has the
correct content now, I don't know about sl-modem-source.

grts Tim

-- System Information:
Debian Release: 4.0
  APT prefers stable
  APT policy: (500, 'stable'), (20, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/dash
Kernel: Linux 2.6.20
Locale: LANG=C, LC_CTYPE=C (charmap=UTF-8) (ignored: LC_ALL set to nl_NL.utf8)
diff -Nur sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon 
sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon
--- sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon 1970-01-01 
01:00:00.0 +0100
+++ sl-modem-2.9.9d+e-pre2/debian/15sl-modem-daemon 2007-05-17 
21:40:55.0 +0200
@@ -0,0 +1,16 @@
+#!/bin/bash
+
+. /usr/lib/pm-utils/functions
+
+case $1 in
+   hibernate|suspend)
+   stopservice sl-modem-daemon
+   ;;
+   thaw|resume)
+   restartservice sl-modem-daemon
+   ;;
+   *)
+   ;;
+esac
+
+exit $?
diff -Nur sl-modem-2.9.9d+e-pre2/debian/rules 
sl-modem-2.9.9d+e-pre2/debian/rules
--- sl-modem-2.9.9d+e-pre2/debian/rules 2007-05-17 21:32:04.0 +0200
+++ sl-modem-2.9.9d+e-pre2/debian/rules 2007-05-17 21:44:09.0 +0200
@@ -66,6 +66,8 @@
cp modem/slmodemd debian/sl-modem-daemon/usr/sbin/
cp debian/sl-modem-daemon.modutils debian/sl-modem-daemon/etc/modutils
cp debian/sl-modem-daemon.modutils debian/sl-modem-daemon/etc/modprobe.d
+   cp debian/15sl-modem-daemon 
debian/sl-modem-daemon/usr/lib/pm-utils/sleep.d
+   chmod a+x 
debian/sl-modem-daemon/usr/lib/pm-utils/sleep.d/15sl-modem-daemon
echo install slamr modprobe --ignore-install ungrab-winmodem ;  
modprobe --ignore-install slamr; test -e /dev/slamr0 || (/bin/mknod -m 660 
/dev/slamr0 c 242 0 2/dev/null  chgrp dialout /dev/slamr0)   
debian/sl-modem-daemon/etc/modprobe.d/sl-modem-daemon.modutils
dh_installdocs -psl-modem-source debian/README.Debian README
dh_installdocs -psl-modem-daemon
diff -Nur sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs 
sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs
--- sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs  2007-05-17 
21:32:04.0 +0200
+++ sl-modem-2.9.9d+e-pre2/debian/sl-modem-daemon.dirs  2007-05-17 
21:41:23.0 +0200
@@ -1,3 +1,4 @@
 usr/sbin
 etc/modutils
 etc/modprobe.d
+usr/lib/pm-utils/sleep.d