Bug#420933: ippl: patches to fix some critical bugs

2007-05-20 Thread Marc Haber
tags #420933 confirmed pending
thanks

On Wed, Apr 25, 2007 at 05:51:12PM +0530, Narayanan R S wrote:
 I've attached a new (additions on the existing diff file) diff file with 
 some patches to fix a bunch of critical issues with ippl.

I have committed this to svn. Can you please check whether this fixes
#410729?

I really appreciate your help, thanks.

Greetings
Marc

-- 
-
Marc Haber | I don't trust Computers. They | Mailadresse im Header
Mannheim, Germany  |  lose things.Winona Ryder | Fon: *49 621 72739834
Nordisch by Nature |  How to make an American Quilt | Fax: *49 621 72739835


-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#420933: ippl: patches to fix some critical bugs

2007-04-25 Thread Narayanan R S


Package: ippl
Version: 1.4.14-8
Severity: important

I've attached a new (additions on the existing diff file) diff file with some 
patches to fix a bunch of critical issues with ippl.


The summary is:

a) If you enable multiple protocol logs (eg: icmp+tcp+udp), there's a race 
condition due to which ippl will *NOT* run. The exact issue is that each thread 
drops (root) privileges after it attaches to the raw socket. If one of the 
other thread tries to attach after this drop in privileges it will fail and 
abort. The fix is to drop privileges in the main thread and not in each/every 
thread. There's a forced sleep in there to ensure that all the threads finish 
their socket attaches by then.


b) As a result of (a) (and of course it was a bug from before), it is no longer 
possible to reload the config files and reattach to the socket since the 
privilege drop has already happened. Reload were broken and now I've explicitly 
logged a message to restart instead of reload (the process will quit gracefully 
after logging).


The attached diff can be diffed with the previous diff from the source to get 
the exact changes I've made. Hopefully they are self explanatory.


Please forward this upstream.

Thanks.

Narayanan.

ippl_1.4.14-8.diff.gz
Description: Diffs for ippl patches