Package: pommed
Version: 1.4~dfsg-1
Severity: normal
(This is actually a report against the powerpc version, but reportbug
runs on my other machine)
pommed 1.4 fails to find the lmu in my PowerBook5,4.
On line 472 of pommed/pmac/kbd_backlight.c
of_find_node_by_type(lmu-controller, 0) returns NULL
Changing it to
of_find_node_by_name(lmu-controller, 0) succeeds, and the keyboard
backlight operates fine.
I don't know if it's just the PowerBook 5,4, but here's the relevant
device-tree section:
su:~# for d in `find /proc/device-tree -name 'lmu-controller*' -type d`/*; do
echo $d; hd $d; done
/proc/device-tree/[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL
PROTECTED]/linux,phandle
ff 96 5b 18 |..[.|
0004
/proc/device-tree/[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED]/name
6c 6d 75 2d 63 6f 6e 74 72 6f 6c 6c 65 72 00 |lmu-controller.|
000f
/proc/device-tree/[EMAIL PROTECTED]/[EMAIL PROTECTED]/[EMAIL PROTECTED]/reg
00 00 00 84 ||
0004
As you can see, there's no 'type' entry in the directory for
of_find_node_by_type to match.
Assuming of_find_node_by_type works on other machines, the best
way would prolly be to fall back to of_find_node_by_name, and if
that also returns NULL, fail.
I didn't include a patch, it seems kinda trivial, and for my local
build (the PowerPC build of 1.4 has been queued on a buildd somewhere
for nearly two weeks) changing the of_find_node call was sufficient.
Oh, and thanks for pommed. I'm glad of a pbbuttonsd replacement that
doesn't kill the interface part when restarting the backend, and that
doesn't exclusively lock my sound interface if I change the volume at
the wrong time. ^_^
-- System Information:
Debian Release: lenny/sid
APT prefers unstable
APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: i386 (i686)
Kernel: Linux 2.6.18-4-686 (SMP w/1 CPU core)
Locale: LANG=en_AU.UTF-8, LC_CTYPE=en_AU.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--
Paul TBBle Hampson, [EMAIL PROTECTED]
Shorter .sig for a more eco-friendly paperless office.
pgpEY8eBk1z2I.pgp
Description: PGP signature
