Bug#430786: tagpending: Appears to ignore some changelog entries
On Thu, Jun 28, 2007 at 02:15:49PM +0100, Adam D. Barratt wrote: > Using the new version against the changelog you supplied, I get: That's a lot clearer, thanks. -- "You grabbed my hand and we fell into it, like a daydream - or a fever." signature.asc Description: Digital signature
Bug#430786: tagpending: Appears to ignore some changelog entries
Mark Brown <[EMAIL PROTECTED]> wrote, Thursday, June 28, 2007 12:43 PM It would be useful to output something for all bugs listed in the changelog - my experience was that the wording of the message was less important than the fact that there was no visible indication that the program was paying a blind bit of notice to the bugs I was expecting it to act on. Yeah, that makes sense. I've committed an update which does so (iterates over all bugs that are either pending or mentioned in the changelog, *or both*). It also sorts the bug list into numerical rather than character code order so it's more intuitive when tagging older bugs. Using the new version against the changelog you supplied, I get: [EMAIL PROTECTED]:~/debian/packages/devscripts/svn/trunk$ scripts/tagpending.sh -n tagpending info: would tag these bugs pending: 406018 [EMAIL PROTECTED]:~/debian/packages/devscripts/svn/trunk$ scripts/tagpending.sh -n -v Checking bug #386357: already marked pending Checking bug #406018: needs tag tagpending info: would tag these bugs pending: 406018 Regards, Adam -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#430786: tagpending: Appears to ignore some changelog entries
On Thu, Jun 28, 2007 at 10:20:47AM +0100, Adam D. Barratt wrote: > verbose mode isn't exactly ideal (particularly the "already tagged pending" > message, which really means "probably shouldn't be tagged pending any more > as it's open, tagged pending but not closed in the current changelog - did > you forget it in the last upload?") but I can't think of concise and > correct replacements for them at the moment. It would be useful to output something for all bugs listed in the changelog - my experience was that the wording of the message was less important than the fact that there was no visible indication that the program was paying a blind bit of notice to the bugs I was expecting it to act on. -- "You grabbed my hand and we fell into it, like a daydream - or a fever." signature.asc Description: Digital signature
Bug#430786: tagpending: Appears to ignore some changelog entries
(as discussed on IRC and for the benefit of the bug log) Hi, Mark Brown wrote: Package: devscripts Version: 2.10.5 Severity: important Attemptting to run tagpending on the changelog for zlib with the following entry at the head: [...] results in tagpending claiming that there is nothing to do. Running with verbose turned on it appears that the two bugs referenced in this entry are being ignored by the program: There were in fact two issues here. Firstly, the BTS was temporarily broken with respect to parameters such as pend-exc=done and so wasn't returning only open bugs when requested. Don's now fixed the BTS issue. Secondly, the semantics of include= have changed such that include=pending no longer returns a list of bugs tagged pending (there is "include=pending:pending" but that returns a list of "pending bugs", which is a rather different thing). I've committed a fix to SVN to use tag=pending, which is what we should have been doing all along. The list of bugs being "checked" in verbose mode is formed from the bugs that are either marked as pending in the BTS or closed in the current changelog, but not both. In this case both of the bugs in your changelog were also being returned by the "list pending bugs" query and therefore not being considered. I agree that the wording of some of the messages in verbose mode isn't exactly ideal (particularly the "already tagged pending" message, which really means "probably shouldn't be tagged pending any more as it's open, tagged pending but not closed in the current changelog - did you forget it in the last upload?") but I can't think of concise and correct replacements for them at the moment. Regards, Adam -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
Bug#430786: tagpending: Appears to ignore some changelog entries
Package: devscripts Version: 2.10.5 Severity: important Attemptting to run tagpending on the changelog for zlib with the following entry at the head: | zlib (1:1.2.3.3.dfsg-3) unstable; urgency=low | | * Support building with UNALIGNED_OK and enable it on i386 and amd64. | This seems to provide a small speedup in my tests (closes: #386357). | * Build 32 bit version on KFreeBSD-amd64 (closes: #406018). | | -- Mark Brown <[EMAIL PROTECTED]> Tue, 26 Jun 2007 18:18:31 +0100 results in tagpending claiming that there is nothing to do. Running with verbose turned on it appears that the two bugs referenced in this entry are being ignored by the program: | Checking bug #198375: already marked pending | Checking bug #234237: already marked pending | Checking bug #253068: already marked pending | Checking bug #283502: already marked pending | Checking bug #290049: already marked pending | Checking bug #297455: already marked pending | Checking bug #301283: already marked pending | Checking bug #308799: already marked pending | Checking bug #318927: already marked pending | Checking bug #320999: already marked pending | Checking bug #330032: already marked pending | Checking bug #338009: already marked pending | Checking bug #347990: already marked pending | Checking bug #353406: already marked pending | Checking bug #386357: already marked pending | Checking bug #406018: already marked pending | Checking bug #410261: already marked pending | Checking bug #419603: already marked pending | Checking bug #44038: already marked pending | Checking bug #60315: already marked pending | tagpending info: Nothing to do, exiting. Adding another changelog entry afterwards has no effect. The package can be checked out from: http://bzr.debian.org/bzr/pkg-zlib/zlib/debian/ -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable') Architecture: powerpc (ppc) Kernel: Linux 2.6.21-1-powerpc Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages devscripts depends on: ii debianutils 2.21.1 Miscellaneous utilities specific t ii dpkg-dev 1.14.4 package building tools for Debian ii libc6 2.5-11 GNU C Library: Shared libraries ii perl 5.8.8-7Larry Wall's Practical Extraction ii sed 4.1.5-2The GNU sed stream editor Versions of packages devscripts recommends: ii fakeroot 1.7.1 Gives a fake root environment -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
