Bug#455291: FTBFS with GCC 4.3: missing #includes
tag 455291 patch
thanks
Martin Michlmayr [EMAIL PROTECTED] (09/12/2007):
Package: audacious-plugins
Version: 1.4.1-2
Usertags: ftbfs-gcc-4.3
Please find attached a patch to fix this FTBFS.
Nice build system, by the way:
| if $compile_line ; then \
| printf \033[K\033[0;32mSuccessfully compiled
\033[1;32mxs_fileinfo.c\033[0;32m.\033[0m\n; \
| else \
| printf \033[K\033[0;31mFailed to compile
\033[1;31mxs_fileinfo.c\033[0;31m!\033[0m\n; exit 1; \
| fi
--
Cyril Brulebois
--- a/src/modplug/archive/arch_gzip.cxx
+++ b/src/modplug/archive/arch_gzip.cxx
@@ -13,6 +13,8 @@
#include arch_gzip.h
+#include cstring
+
arch_Gzip::arch_Gzip(const string aFileName)
{
--- a/src/modplug/archive/arch_rar.cxx
+++ b/src/modplug/archive/arch_rar.cxx
@@ -15,6 +15,7 @@
#include arch_rar.h
#include iostream
#include vector
+#include cstring
arch_Rar::arch_Rar(const string aFileName)
{
signature.asc
Description: Digital signature
Bug#455291: FTBFS with GCC 4.3: missing #includes
Hi Adam, Yes a buildbot system would be a great solution. Would you like to help set one up? William On Wed, 2008-03-05 at 21:55 +0100, Adam Cécile (Le_Vert) wrote: Thanks, I will fix it with my next upload. Moreover I'll have a talk with upstream to be sure this kind of ftbfs can't appear anymore (ie: buildbot). Regards, Adam. Cyril Brulebois a écrit : tag 455291 patch thanks Martin Michlmayr [EMAIL PROTECTED] (09/12/2007): Package: audacious-plugins Version: 1.4.1-2 Usertags: ftbfs-gcc-4.3 Please find attached a patch to fix this FTBFS. Nice build system, by the way: | if $compile_line ; then \ | printf \033[K\033[0;32mSuccessfully compiled \033[1;32mxs_fileinfo.c\033[0;32m.\033[0m\n; \ | else \ | printf \033[K\033[0;31mFailed to compile \033[1;31mxs_fileinfo.c\033[0;31m!\033[0m\n; exit 1; \ | fi signature.asc Description: This is a digitally signed message part
Bug#455291: FTBFS with GCC 4.3: missing #includes
Thanks, I will fix it with my next upload. Moreover I'll have a talk with upstream to be sure this kind of ftbfs can't appear anymore (ie: buildbot). Regards, Adam. Cyril Brulebois a écrit : tag 455291 patch thanks Martin Michlmayr [EMAIL PROTECTED] (09/12/2007): Package: audacious-plugins Version: 1.4.1-2 Usertags: ftbfs-gcc-4.3 Please find attached a patch to fix this FTBFS. Nice build system, by the way: | if $compile_line ; then \ | printf \033[K\033[0;32mSuccessfully compiled \033[1;32mxs_fileinfo.c\033[0;32m.\033[0m\n; \ | else \ | printf \033[K\033[0;31mFailed to compile \033[1;31mxs_fileinfo.c\033[0;31m!\033[0m\n; exit 1; \ | fi
Bug#455291: FTBFS with GCC 4.3: missing #includes
I already set up one for the aircrack-ng project, so I have some config files that work out of the box. However I don't know yet how to plug buildbot with your VCS, but that should be quite easy. Let's move to IRC to have a quick discussion about this ;) William Pitcock a écrit : Hi Adam, Yes a buildbot system would be a great solution. Would you like to help set one up? William On Wed, 2008-03-05 at 21:55 +0100, Adam Cécile (Le_Vert) wrote: Thanks, I will fix it with my next upload. Moreover I'll have a talk with upstream to be sure this kind of ftbfs can't appear anymore (ie: buildbot). Regards, Adam. Cyril Brulebois a écrit : tag 455291 patch thanks Martin Michlmayr [EMAIL PROTECTED] (09/12/2007): Package: audacious-plugins Version: 1.4.1-2 Usertags: ftbfs-gcc-4.3 Please find attached a patch to fix this FTBFS. Nice build system, by the way: | if $compile_line ; then \ | printf \033[K\033[0;32mSuccessfully compiled \033[1;32mxs_fileinfo.c\033[0;32m.\033[0m\n; \ | else \ | printf \033[K\033[0;31mFailed to compile \033[1;31mxs_fileinfo.c\033[0;31m!\033[0m\n; exit 1; \ | fi
Bug#455291: FTBFS with GCC 4.3: missing #includes
Package: audacious-plugins Version: 1.4.1-2 Usertags: ftbfs-gcc-4.3 Your package fails to build with GCC 4.3. Version 4.3 has not been released yet but I'm building with a snapshot in order to find errors and give people an advance warning. In GCC 4.3, the C++ header dependencies have been cleaned up. The advantage of this is that programs will compile faster. The downside is that you actually need to directly #include everything you use (but you really should do this anyway, otherwise your program won't work with any compiler other than GCC). There's some more information about this at http://www.cyrius.com/journal/2007/05/10#gcc-4.3-include You can reproduce this problem with gcc-snapshot from unstable. Note that Red Hat, Novell and Ubuntu have done some work getting packages to build with GCC 4.3 so there might be patches floating around somewhere. I suggest you talk to your upstream. Automatic build of audacious-plugins_1.4.1-2 on em64t by sbuild/amd64 0.53 ... [K[0;33mCompiling [1;33marchive/arch_gzip.cxx[0;33m...[0m if x86_64-linux-gnu-g++ -g -O2 -pipe -Wall -I/usr/include -I/usr/include -DPNG_NO_MMX_CODE -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/include/libmowgli -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -g -O2 -pipe -Wall -I/usr/include -I/usr/include -DPNG_NO_MMX_CODE -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/gtk-2.0 -I/usr/include/libmowgli -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -fPIC -I/usr/include -I/usr/include -DPIC -I/usr/include/libmowgli -I/usr/include/dbus-1.0 -I/usr/lib/dbus-1.0/include -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -DPNG_NO_MMX_CODE -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/libpng12 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include -I.. -I../.. -I../../intl -c -o archive/arch_gzip.o archive/arch_gzip.cxx; then \ printf \033[K\033[0;32mSuccessfully compiled \033[1;32marchive/arch_gzip.cxx\033[0;32m.\033[0m\n; \ else \ printf \033[K\033[0;31mFailed to compile \033[1;31marchive/arch_gzip.cxx\033[0;31m!\033[0m\n; exit 1; \ fi archive/arch_gzip.cxx: In static member function 'static bool arch_Gzip::ContainsMod(const std::string)': archive/arch_gzip.cxx:130: error: 'strlen' was not declared in this scope [K[0;31mFailed to compile [1;31marchive/arch_gzip.cxx[0;31m![0m make[6]: *** [archive/arch_gzip.o] Error 1 make[6]: Leaving directory `/build/tbm/audacious-plugins-1.4.1/src/modplug' make[5]: *** [all] Error 1 -- Martin Michlmayr http://www.cyrius.com/
