Bug#458391: smartmontools: Please add LSB formatted dependency info in init.d script

2008-01-07 Thread Bruce Allen

Guido,

You are welcome to add these into the upstream CVS, if you wish.  If 
possible add a comment into the block saying that this is for Debian/LSB.


Cheers,
Bruce


On Tue, 1 Jan 2008, Guido Guenther wrote:


Hi Petter,
On Sun, Dec 30, 2007 at 10:26:48PM +0100, Petter Reinholdtsen wrote:

--- smartmontools-5.37.orig/debian/smartmontools.init   2007-12-30 
22:24:36.0 +0100
+++ smartmontools-5.37/debian/smartmontools.init2007-12-30 
22:25:39.0 +0100
@@ -1,4 +1,11 @@
 #!/bin/sh -e
+### BEGIN INIT INFO
+# Provides:  smartmontools
+# Required-Start:$local_fs
+# Required-Stop: $local_fs
+# Default-Start: 2 3 4 5
+# Default-Stop:  0 1 6
+### END INIT INFO

This was fixed in experimental a while ago. Thanks for the patch and for
your effort to add depenency information to the init scripts. I'll move
the version from experimental to unstable during the next week or so.
Cheers,
-- Guido







--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#458391: smartmontools: Please add LSB formatted dependency info in init.d script

2008-01-01 Thread Guido Guenther
Hi Petter,
On Sun, Dec 30, 2007 at 10:26:48PM +0100, Petter Reinholdtsen wrote:
> --- smartmontools-5.37.orig/debian/smartmontools.init   2007-12-30 
> 22:24:36.0 +0100
> +++ smartmontools-5.37/debian/smartmontools.init2007-12-30 
> 22:25:39.0 +0100
> @@ -1,4 +1,11 @@
>  #!/bin/sh -e
> +### BEGIN INIT INFO
> +# Provides:  smartmontools
> +# Required-Start:$local_fs
> +# Required-Stop: $local_fs
> +# Default-Start: 2 3 4 5
> +# Default-Stop:  0 1 6
> +### END INIT INFO
This was fixed in experimental a while ago. Thanks for the patch and for
your effort to add depenency information to the init scripts. I'll move
the version from experimental to unstable during the next week or so.
Cheers,
 -- Guido



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#458391: smartmontools: Please add LSB formatted dependency info in init.d script

2007-12-30 Thread Petter Reinholdtsen

Package:  smartmontools
Version:  5.37-6
Tags: patch
User: [EMAIL PROTECTED]
Usertags: missing-dependency

To be able to check boot script order, and also to be able to start
boot scripts in parallel, it is important to know the dependencies of
the various boot scripts.  The Linux Software Base specifies a init.d
header file format useful for this purpose, and adding such header to
the init.d script would make it possible for me to use this
information to check the current sequence and to speed up the debian
boot.

I am working on a system to update the boot sequence based on these
dependencies, and would like see this as the default in Lenny.
Because of this, it is nice if the dependencies was updated quickly.

http://refspecs.freestandards.org/LSB_2.1.0/LSB-generic/LSB-generic/initscrcomconv.html>
documents the LSB header format.  Some debian notes are available from
http://wiki.debian.org/LSBInitScripts>.

Here is a patch to document the dependencies.  I hope this is correct.

diff -ru smartmontools-5.37.orig/debian/smartmontools.init 
smartmontools-5.37/debian/smartmontools.init
--- smartmontools-5.37.orig/debian/smartmontools.init   2007-12-30 
22:24:36.0 +0100
+++ smartmontools-5.37/debian/smartmontools.init2007-12-30 
22:25:39.0 +0100
@@ -1,4 +1,11 @@
 #!/bin/sh -e
+### BEGIN INIT INFO
+# Provides:  smartmontools
+# Required-Start:$local_fs
+# Required-Stop: $local_fs
+# Default-Start: 2 3 4 5
+# Default-Stop:  0 1 6
+### END INIT INFO
 #
 # smartmontools init.d startup script
 #



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]