Bug#458663: gz/bz2/xz for debootstrap data.tar
Hello Clint, On Mon, Nov 16, 2009 at 12:18 PM, Clint Adams sch...@debian.org wrote: This anticipates the eventuality of data.tar.xz. I've commited your patch in SVN; even though it is not yet clear that .bz2 data.tar are going to be accepted for base packages I see now reason to now support it in debootstrap leaving this decision to FTP masters. Personally I think the size difference don't justify the complexity that could involve to have a xz binary available in a foreign system and like so I'm against it for base packages. Cheers, -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#458663: gz/bz2/xz for debootstrap data.tar
On Monday 16 November 2009, Otavio Salvador wrote: On Mon, Nov 16, 2009 at 12:18 PM, Clint Adams sch...@debian.org wrote: This anticipates the eventuality of data.tar.xz. I've commited your patch in SVN; even though it is not yet clear that .bz2 data.tar are going to be accepted for base packages I see now reason to now support it in debootstrap leaving this decision to FTP masters. Have you thought this through? Have you considered Joey's arguments that as a distribution we should not *want* to support multiple compression methods in debootstrap because the decompressors may not be available? How will debootstrap react when the decompressors are not available? If you do add this to SVN, shouldn't you also add a dependency on the decompressors? Please don't commit patches blindly. Cheers, FJP -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#458663: gz/bz2/xz for debootstrap data.tar
On Mon, Nov 16, 2009 at 4:00 PM, Frans Pop elen...@planet.nl wrote: On Monday 16 November 2009, Otavio Salvador wrote: On Mon, Nov 16, 2009 at 12:18 PM, Clint Adams sch...@debian.org wrote: This anticipates the eventuality of data.tar.xz. I've commited your patch in SVN; even though it is not yet clear that .bz2 data.tar are going to be accepted for base packages I see now reason to now support it in debootstrap leaving this decision to FTP masters. Have you thought this through? Have you considered Joey's arguments that as a distribution we should not *want* to support multiple compression methods in debootstrap because the decompressors may not be available? Yes; and I agree that Debian shouldn't support it _but_ it does't mean deboostrap cannot support it. How will debootstrap react when the decompressors are not available? It is going to output an error ... File not found! :-) If you do add this to SVN, shouldn't you also add a dependency on the decompressors? No since it is not supported by Debian ATM; we're going to have support on the code for it and derivatives can use it if desired but I don't think we ought to add depends on something that is not used. Please don't commit patches blindly. I did not. -- Otavio Salvador O.S. Systems E-mail: ota...@ossystems.com.br http://www.ossystems.com.br Mobile: +55 53 9981-7854 http://projetos.ossystems.com.br -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#458663: gz/bz2/xz for debootstrap data.tar
On Monday 16 November 2009, Otavio Salvador wrote: How will debootstrap react when the decompressors are not available? It is going to output an error ... File not found! :-) IMHO it should at the very least test if the decompressor is available [1] and output a more meaningful message than that. A user should not have to grub through the source to find out why it's failing. Please don't commit patches blindly. I did not. OK. [1] Using 'if type program /dev/null 21' for compatibility with D-I. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#458663: gz/bz2/xz for debootstrap data.tar
This anticipates the eventuality of data.tar.xz.
--- functions.orig 2009-11-16 08:41:11.094921291 -0500
+++ functions 2009-11-16 08:48:13.883895352 -0500
@@ -719,13 +719,19 @@
extract () { (
cd $TARGET
- local p=0
+ local p=0 tarball
for pkg in $(debfor $@); do
p=$(($p + 1))
progress $p $# EXTRACTPKGS Extracting packages
packagename=$(echo $pkg | sed 's,^.*/,,;s,_.*$,,')
info EXTRACTING Extracting %s... $packagename
- ar -p ./$pkg data.tar.gz | zcat | tar -xf -
+ tarball=$(ar -t ./$pkg | grep ^data.tar.[bgx]z)
+ case $tarball in
+ (data.tar.gz) ar -p ./$pkg data.tar.gz | zcat | tar
-xf - ;;
+ (data.tar.bz2) ar -p ./$pkg data.tar.bz2 | bzcat |
tar -xf - ;;
+ (data.tar.xz) ar -p ./$pkg data.tar.xz | xzcat | tar
-xf - ;;
+ (*) error 1 UNKNOWNDATACOMP Unknown compression type
for %s in %s $tarball $pkg ;;
+ esac
done
); }
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
