Bug#465395: libstlport5.1-dev: another warning about unused parameter

[Thomas Girard]

Hello Norbert,

On Mon, Feb 11, 2008 at 10:53:49PM -0800, Norbert Kiesel wrote:
 Thanks for applying my patch.  i just recompiled and found another one.
 Not sure why that did not show up before, might have been introduced in
 the last version.  This time patch is a bit more complicated because the
 parameter is used with debug output, so I had to add another
 preprocessor macro. Anyway, it's straight-forward and it would be cool
 if you could apply it in one of the next versions.

This part was already present (without the macro) in your previous
patch, and I have not applied it because I thought it was not needed, as
it was for a .c file. It turns out it is.

I'll forward this to upstream, thanks!

Thomas



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]

Bug#465395: libstlport5.1-dev: another warning about unused parameter

[Norbert Kiesel]

Package: libstlport5.1-dev
Version: 5.1.5-1
Severity: minor


Thanks for applying my patch.  i just recompiled and found another one.
Not sure why that did not show up before, might have been introduced in
the last version.  This time patch is a bit more complicated because the
parameter is used with debug output, so I had to add another
preprocessor macro. Anyway, it's straight-forward and it would be cool
if you could apply it in one of the next versions.

Best,
  Norbert


diff -ru /usr/include/stlport-orig/stl/_algobase.c 
/usr/include/stlport/stl/_algobase.c
--- /usr/include/stlport-orig/stl/_algobase.c   2007-09-09 02:12:28.0 
-0700
+++ /usr/include/stlport/stl/_algobase.c2008-02-11 22:45:48.0 
-0800
@@ -371,7 +371,7 @@
 
 template class _ForwardIter, class _Tp, class _Compare1, class _Compare2, 
class _Distance
 _ForwardIter __lower_bound(_ForwardIter __first, _ForwardIter __last, const 
_Tp __val,
-   _Compare1 __comp1, _Compare2 __comp2, _Distance*) {
+   _Compare1 __comp1, _Compare2 
_STLP_VERBOSE_PARAM(__comp2), _Distance*) {
   _Distance __len = distance(__first, __last);
   _Distance __half;
   _ForwardIter __middle;
diff -ru /usr/include/stlport-orig/stl/config/features.h 
/usr/include/stlport/stl/config/features.h
--- /usr/include/stlport-orig/stl/config/features.h 2007-08-18 
13:45:42.0 -0700
+++ /usr/include/stlport/stl/config/features.h  2008-02-11 22:46:38.0 
-0800
@@ -415,8 +415,11 @@
 
 #if !defined (_STLP_DEBUG)
 #  define _STLP_VERBOSE_ASSERT(expr,diagnostic)
+#  define _STLP_VERBOSE_PARAM(param)
 #  define _STLP_DEBUG_CHECK(expr)
 #  define _STLP_DEBUG_DO(expr)
+#else
+#  define _STLP_VERBOSE_PARAM(param) param
 #endif
 
 #if !defined (_STLP_WEAK)


-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.24-1-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages libstlport5.1-dev depends on:
ii  g++ [c++-compiler]4:4.2.2-2  The GNU C++ compiler
ii  g++-4.2 [c++-compiler]4.2.3-1The GNU C++ compiler
ii  libstlport5.1ldbl 5.1.5-1STLport C++ class library

libstlport5.1-dev recommends no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]