Bug#466049: [Piuparts-devel] Bug#466049: piuparts: when called with -b, no policy-rc.d in second chroot
Hi Patrick, thanks for your patch. I've modified it slightly, see attached. cheers, Holger Index: piuparts.py === --- piuparts.py (revision 551) +++ piuparts.py (working copy) @@ -1671,9 +1671,8 @@ chroot.remove() dont_do_on_panic(id) chroot = get_chroot() -chroot.create_temp_dir() +chroot.create() id = do_on_panic(chroot.remove) -chroot.unpack_from_tgz(root_tgz) chroot.check_for_no_processes() signature.asc Description: This is a digitally signed message part.
Bug#466049: piuparts: when called with -b, no policy-rc.d in second chroot
Tags 466049 patch thanks Hi, Marc Haber wrote: > I think that > piuparts -a -b piuparts.tar.gz -d etch -d lenny torrus-apache does the > following: > > (1) unpack tarball > (2) create exit 101 policy-rc.d > (3) upgrade etch > (4) dist-upgrade lenny > (5) unpack tarball a second time in a second directory > (6) do not create policy-rc.d Right. The point is, that after unpacking the tarball a second time the functions that setup a chroot for use after unpacking are not called. Thats probably because the chroot is created 'manually' instead of calling the appropriate function chroot.create(). I'm not exactly sure if replacing that code with a call for chroot.create() as I now did is the way to go. Holger, would be good if you have a look at the responding code anyway if this works out. Best Regards, Patrick Index: piuparts.py === --- piuparts.py (Revision 550) +++ piuparts.py (Arbeitskopie) @@ -1669,11 +1669,8 @@ save_meta_data(settings.saveendmeta, root_info, selections) chroot.remove() -dont_do_on_panic(id) chroot = get_chroot() -chroot.create_temp_dir() -id = do_on_panic(chroot.remove) -chroot.unpack_from_tgz(root_tgz) +chroot.create() chroot.check_for_no_processes()
Bug#466049: piuparts: when called with -b, no policy-rc.d in second chroot
Tags 466049 patch thanks Hi, Marc Haber wrote: > I think that > piuparts -a -b piuparts.tar.gz -d etch -d lenny torrus-apache does the > following: > > (1) unpack tarball > (2) create exit 101 policy-rc.d > (3) upgrade etch > (4) dist-upgrade lenny > (5) unpack tarball a second time in a second directory > (6) do not create policy-rc.d Right. The point is, that after unpacking the tarball a second time the functions that setup a chroot for use after unpacking are not called. Thats probably because the chroot is created 'manually' instead of calling the appropriate function chroot.create(). I'm not exactly sure if replacing that code with a call for chroot.create() as I now did is the way to go. Holger, would be good if you have a look at the responding code anyway if this works out. Best Regards, Patrick -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#466049: piuparts: when called with -b, no policy-rc.d in second chroot
Package: piuparts Version: 0.30 Severity: normal I think that piuparts -a -b piuparts.tar.gz -d etch -d lenny torrus-apache does the following: (1) unpack tarball (2) create exit 101 policy-rc.d (3) upgrade etch (4) dist-upgrade lenny (5) unpack tarball a second time in a second directory (6) do not create policy-rc.d (7) install torrus-apache (8) complain about the processes started by torrus-apache installation (9) abort I am either doing something wrong, or in step (6) there should be a policy-rc.d placed into the second directory as well. -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (500, 'testing') Architecture: i386 (i686) Kernel: Linux 2.6.24.2-zgsrv (SMP w/1 CPU core; PREEMPT) Locale: LANG=C, LC_CTYPE=C (charmap=ANSI_X3.4-1968) Shell: /bin/sh linked to /bin/bash Versions of packages piuparts depends on: ii apt0.7.10Advanced front-end for dpkg ii debootstrap1.0.8 Bootstrap a basic Debian system ii lsb-release3.1-24Linux Standard Base version report ii lsof 4.78.dfsg.1-4 List open files ii python 2.4.4-6 An interactive high-level object-o ii python-debian 0.1.9 python modules to work with Debian piuparts recommends no packages. -- no debconf information -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]
