Bug#473175: Git use work flow for apt-listbugs [was: Re: Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)]
On Sun, 8 Feb 2009 12:48:33 +0100 Francesco Poli wrote: On Wed, 28 Jan 2009 21:02:42 +0100 Francesco Poli wrote: On Tue, 27 Jan 2009 14:59:10 +0900 Junichi Uekawa wrote: [...] I think you will get conflicts in the master branch that way, because I may have modified your patch when merging into my repository. You are right! I think I already explained I am a git novice... You may want to use feature branches; Mmmmh, topic branches could be a solution. OK, restarting from scratch, I could do as follows: $ git clone git://git.debian.org/git/apt-listbugs/apt-listbugs.git then, inside the repository directory: $ git checkout -b $MY_COOL_BRANCH_NAME origin $ vim onefile $ vim anotherfile $ git add onefile anotherfile $ git commit $ vim thirdfile $ vim anotherfile $ git add thirdfile anotherfile $ git commit $ git format-patch origin -o somedirectory/ And then I could send the patch series to you via e-mail... After some time: $ git checkout master git pull # this should result in a fast-forward If the patches have been applied to the public repository, then the branch may be discarded: $ git branch -d $MY_COOL_BRANCH_NAME In order to create another topic branch: $ git checkout master git pull # this should result in a fast-forward $ git checkout -b $SECOND_BRANCH_NAME origin and so forth similarly to $MY_COOL_BRANCH_NAME ... Is that correct? Junichi, could you please confirm that the above strategy is a working one? May I proceed like this? Junichi, please, can you confirm that I can adopt the above strategy in order to help you in maintaining apt-listbugs? -- On some search engines, searching for my nickname AND nano-documents may lead you to my website... . Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4 pgp8Ed8VEZrMz.pgp Description: PGP signature
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
On Wed, 28 Jan 2009 21:02:42 +0100 Francesco Poli wrote: On Tue, 27 Jan 2009 14:59:10 +0900 Junichi Uekawa wrote: [...] I think you will get conflicts in the master branch that way, because I may have modified your patch when merging into my repository. You are right! I think I already explained I am a git novice... You may want to use feature branches; Mmmmh, topic branches could be a solution. OK, restarting from scratch, I could do as follows: $ git clone git://git.debian.org/git/apt-listbugs/apt-listbugs.git then, inside the repository directory: $ git checkout -b $MY_COOL_BRANCH_NAME origin $ vim onefile $ vim anotherfile $ git add onefile anotherfile $ git commit $ vim thirdfile $ vim anotherfile $ git add thirdfile anotherfile $ git commit $ git format-patch origin -o somedirectory/ And then I could send the patch series to you via e-mail... After some time: $ git checkout master git pull # this should result in a fast-forward If the patches have been applied to the public repository, then the branch may be discarded: $ git branch -d $MY_COOL_BRANCH_NAME In order to create another topic branch: $ git checkout master git pull # this should result in a fast-forward $ git checkout -b $SECOND_BRANCH_NAME origin and so forth similarly to $MY_COOL_BRANCH_NAME ... Is that correct? Junichi, could you please confirm that the above strategy is a working one? May I proceed like this? -- On some search engines, searching for my nickname AND nano-documents may lead you to my website... . Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4 pgpPUEeURb4GZ.pgp Description: PGP signature
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
On Tue, 27 Jan 2009 14:59:10 +0900 Junichi Uekawa wrote: At Mon, 26 Jan 2009 22:18:26 +0100, Francesco Poli wrote: [...] On Mon, 26 Jan 2009 06:31:43 +0900 Junichi Uekawa wrote: [...] Anyway, could you please clarify what you expect me to write? Do you mean I should add something to test_logic.rb or to tests/???_*.sh ? I tried to perform such tests with a pbuilder hook script (B92test-pkg), but some of them failed somehow: I wanted to ask you for help in understanding what went wrong, but I thought I could postpone that... Of course, if I have to add a test, I must understand them now, so I'll contact you privately about that. Frankly, I don't have a good idea on a regression-testable code. I was hoping something can be written as test/???_*.sh; or I would have to manually test it to make sure it hasn't broken. I hope some test/???_*.sh may be written. I'll contact you privately soon about this. Moreover, how should I proceed with git? [...] Is that correct? I think you will get conflicts in the master branch that way, because I may have modified your patch when merging into my repository. You are right! I think I already explained I am a git novice... You may want to use feature branches; Mmmmh, topic branches could be a solution. OK, restarting from scratch, I could do as follows: $ git clone git://git.debian.org/git/apt-listbugs/apt-listbugs.git then, inside the repository directory: $ git checkout -b $MY_COOL_BRANCH_NAME origin $ vim onefile $ vim anotherfile $ git add onefile anotherfile $ git commit $ vim thirdfile $ vim anotherfile $ git add thirdfile anotherfile $ git commit $ git format-patch origin -o somedirectory/ And then I could send the patch series to you via e-mail... After some time: $ git checkout master git pull # this should result in a fast-forward If the patches have been applied to the public repository, then the branch may be discarded: $ git branch -d $MY_COOL_BRANCH_NAME In order to create another topic branch: $ git checkout master git pull # this should result in a fast-forward $ git checkout -b $SECOND_BRANCH_NAME origin and so forth similarly to $MY_COOL_BRANCH_NAME ... Is that correct? or better, get a alioth account so that I can add you to Git committers so you can commit to HEAD directly. I think I'll need a bit of review from you at first. Later on, when I get more familiar with apt-listbugs package and with packaging practices, I will be ready to commit directly to the repository. -- On some search engines, searching for my nickname AND nano-documents may lead you to my website... . Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4 pgpMzz2lWJgOv.pgp Description: PGP signature
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
On Mon, 26 Jan 2009 06:31:43 +0900 Junichi Uekawa wrote: Hi, Hi! I'd like something that this code can be tested against, and a real use-case, so I'm waiting for your next patch. Well, try to be more explicit next time, please, so that I will be aware that you're are waiting for me to do something... otherwise we could find ourselves in a sort of deadlock, waiting for each other's action! Anyway, could you please clarify what you expect me to write? Do you mean I should add something to test_logic.rb or to tests/???_*.sh ? I tried to perform such tests with a pbuilder hook script (B92test-pkg), but some of them failed somehow: I wanted to ask you for help in understanding what went wrong, but I thought I could postpone that... Of course, if I have to add a test, I must understand them now, so I'll contact you privately about that. Moreover, how should I proceed with git? I created my commit in my master branch. Should I go on as follows? $ git pull # which will fetch from the public repository # and merge it into my master branch $ vim onefile $ vim anotherfile $ git add onefile anotherfile $ git commit $ vim thirdfile $ vim anotherfile $ git add thirdfile anotherfile $ git commit $ git format-patch origin -o somedirectory/ Is that correct? -- On some search engines, searching for my nickname AND nano-documents may lead you to my website... . Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4 pgpbiWL8bQaHM.pgp Description: PGP signature
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
At Mon, 26 Jan 2009 22:18:26 +0100, Francesco Poli wrote: [1 text/plain; US-ASCII (quoted-printable)] On Mon, 26 Jan 2009 06:31:43 +0900 Junichi Uekawa wrote: Hi, Hi! I'd like something that this code can be tested against, and a real use-case, so I'm waiting for your next patch. Well, try to be more explicit next time, please, so that I will be aware that you're are waiting for me to do something... otherwise we could find ourselves in a sort of deadlock, waiting for each other's action! Well, you could have predicted my mind and did it anyway :) Anyway, could you please clarify what you expect me to write? Do you mean I should add something to test_logic.rb or to tests/???_*.sh ? I tried to perform such tests with a pbuilder hook script (B92test-pkg), but some of them failed somehow: I wanted to ask you for help in understanding what went wrong, but I thought I could postpone that... Of course, if I have to add a test, I must understand them now, so I'll contact you privately about that. Frankly, I don't have a good idea on a regression-testable code. I was hoping something can be written as test/???_*.sh; or I would have to manually test it to make sure it hasn't broken. Moreover, how should I proceed with git? I created my commit in my master branch. Should I go on as follows? $ git pull # which will fetch from the public repository # and merge it into my master branch $ vim onefile $ vim anotherfile $ git add onefile anotherfile $ git commit $ vim thirdfile $ vim anotherfile $ git add thirdfile anotherfile $ git commit $ git format-patch origin -o somedirectory/ Is that correct? I think you will get conflicts in the master branch that way, because I may have modified your patch when merging into my repository. You may want to use feature branches; or better, get a alioth account so that I can add you to Git committers so you can commit to HEAD directly. -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
Hi, I'd like something that this code can be tested against, and a real use-case, so I'm waiting for your next patch. At Sun, 25 Jan 2009 14:45:49 +0100, Francesco Poli wrote: [1 text/plain; US-ASCII (quoted-printable)] On Mon, 12 Jan 2009 19:03:41 +0100 Francesco Poli wrote: On Mon, 12 Jan 2009 10:38:18 +0900 Junichi Uekawa wrote: Hi, I looked at the patch; did you mean to add --bugs option only for 0.0.95 release ? Yes, definitely. Please apply the patch to your git repository, tag the new release and upload it to the Debian archive (assuming that everything looks OK). Thanks in advance. I thought you wanted to fix aptcleanup? That will be for 0.0.96 release, as soon as I am ready to send new patches with git-format-patch (stay tuned!). Hi again, Junichi. I've just noticed that you applied my patch to the apt-listbugs public git repository (thank you!), but then committed another modification in order to mark this new version as UNRELEASED, since you haven't yet uploaded it to the Debian archive. I assume that you are performing some tests and quality checks (good!): I would like to make it clear that, as I previously said, version 0.0.95 is ready to be uploaded to the Debian archive, as far as I am concerned. Future changes from me are intended for version 0.0.96 and later ones. As a consequence, I ask you to upload version 0.0.95 to the Debian archive, as soon as you are satisfied with it. Thanks again. -- On some search engines, searching for my nickname AND nano-documents may lead you to my website... . Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4 [2 application/pgp-signature (7bit)] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
On Mon, 12 Jan 2009 19:03:41 +0100 Francesco Poli wrote: On Mon, 12 Jan 2009 10:38:18 +0900 Junichi Uekawa wrote: Hi, I looked at the patch; did you mean to add --bugs option only for 0.0.95 release ? Yes, definitely. Please apply the patch to your git repository, tag the new release and upload it to the Debian archive (assuming that everything looks OK). Thanks in advance. I thought you wanted to fix aptcleanup? That will be for 0.0.96 release, as soon as I am ready to send new patches with git-format-patch (stay tuned!). Hi again, Junichi. I've just noticed that you applied my patch to the apt-listbugs public git repository (thank you!), but then committed another modification in order to mark this new version as UNRELEASED, since you haven't yet uploaded it to the Debian archive. I assume that you are performing some tests and quality checks (good!): I would like to make it clear that, as I previously said, version 0.0.95 is ready to be uploaded to the Debian archive, as far as I am concerned. Future changes from me are intended for version 0.0.96 and later ones. As a consequence, I ask you to upload version 0.0.95 to the Debian archive, as soon as you are satisfied with it. Thanks again. -- On some search engines, searching for my nickname AND nano-documents may lead you to my website... . Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4 pgpSXHyISsESB.pgp Description: PGP signature
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
On Mon, 12 Jan 2009 10:38:18 +0900 Junichi Uekawa wrote: Hi, I looked at the patch; did you mean to add --bugs option only for 0.0.95 release ? Yes, definitely. Please apply the patch to your git repository, tag the new release and upload it to the Debian archive (assuming that everything looks OK). Thanks in advance. I thought you wanted to fix aptcleanup? That will be for 0.0.96 release, as soon as I am ready to send new patches with git-format-patch (stay tuned!). -- On some search engines, searching for my nickname AND nano-documents may lead you to my website... . Francesco Poli . GnuPG key fpr == C979 F34B 27CE 5CD8 DC12 31B5 78F4 279B DD6D FCF4 pgps3s9tPmcpZ.pgp Description: PGP signature
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
Hi, I looked at the patch; did you mean to add --bugs option only for 0.0.95 release ? I thought you wanted to fix aptcleanup? At Sun, 28 Dec 2008 12:36:27 +0100, Francesco Poli (t1000) wrote: add a new option (--bugs) to only show bugs that belong to a given set add Francesco Poli to the uploaders list --- apt-listbugs | 11 +-- debian/changelog |8 debian/control|1 + debian/copyright |5 +++-- lib/apt-listbugs/logic.rb | 14 +- 5 files changed, 34 insertions(+), 5 deletions(-) diff --git a/apt-listbugs b/apt-listbugs index 8fcc449..3e803e8 100755 --- a/apt-listbugs +++ b/apt-listbugs @@ -4,6 +4,7 @@ # # Copyright (C) 2002 Masato Taruishi t...@debian.org # Copyright (C) 2006-2008 Junichi Uekawa dan...@debian.org +# Copyright (C) 2008 Francesco Poli f...@firenze.linux.it # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -40,7 +41,7 @@ the upgrade/installation is safe. == USAGE -apt-listbugs [-h] [-s severities] [-S stats] [-D] [-H hostname] [-p port] command [arguments] +apt-listbugs [-h] [-s severities] [-S stats] [-B bugs] [-D] [-H hostname] [-p port] command [arguments] == OPTIONS @@ -67,6 +68,10 @@ apt-listbugs [-h] [-s severities] [-S stats] [-D] [-H hostname] [-p port Note that 'pending' does not mean 'tagged pending', but 'still open, pending to be fixed'. +* -B bugs | --bugs bugs + + Bug numbers you want to see separated by comma (e.g. 123456,567890,135792). All other bugs will be ignored. + * -D | --show-downgrade Shows bugs of downgraded packages. (apt mode only) @@ -203,7 +208,8 @@ don't actually apply to the version. You need to review the bug. apt-listbugs was originally written by Masato Taruishi t...@debian.org, and rewritten by Junichi Uekawa dan...@debian.org in 2006 to handle BTS Versioning features and the -SOAP interface. +SOAP interface. The --bugs option was added by Francesco Poli +f...@firenze.linux.it in 2008. Latest source-code is available from http://git.debian.org/?p=apt-listbugs/apt-listbugs.git @@ -332,6 +338,7 @@ rescue end Factory::BugsFactory.delete_ignore_bugs(bugs) if config.command == apt +Factory::BugsFactory.delete_uninteresting_bugs(bugs) if config.fbugs Factory::BugsFactory.delete_unwanted_tag_bugs(bugs) if config.tag begin Factory::BugsFactory.delete_irrelevant_bugs(bugs, cur_pkgs, new_pkgs) { |msg, val| diff --git a/debian/changelog b/debian/changelog index 0b81519..a94992a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +apt-listbugs (0.0.95) unstable; urgency=low + + * fix please implement a command to query the BTS about a given bug in +given package/version (Closes: #476988) + * added Francesco Poli to the uploaders list + + -- Francesco Poli (t1000) f...@firenze.linux.it Thu, 11 Dec 2008 23:58:31 +0100 + apt-listbugs (0.0.94) unstable; urgency=low * remove a trace of -R option which used to be 'release-critical' which diff --git a/debian/control b/debian/control index c3fd35e..44e7c9f 100644 --- a/debian/control +++ b/debian/control @@ -2,6 +2,7 @@ Source: apt-listbugs Section: admin Priority: optional Maintainer: Junichi Uekawa dan...@debian.org +Uploaders: Francesco Poli (t1000) f...@firenze.linux.it Build-Depends: debhelper ( 5.0.0), cdbs, time Build-Depends-Indep: ruby1.8, rdtool, gettext Standards-Version: 3.7.2 diff --git a/debian/copyright b/debian/copyright index 8d9a9d5..e9d68e5 100644 --- a/debian/copyright +++ b/debian/copyright @@ -4,8 +4,9 @@ The original source can always be found at: http://ftp.debian.org/debian/pool/main/a/apt-listbugs/ http://git.debian.org/?p=apt-listbugs/apt-listbugs.git -Copyright (C) 2002 Masato Taruishi -Copyright (C) 2006 Junichi Uekawa +Copyright (C) 2002 Masato Taruishi t...@debian.org +Copyright (C) 2006-2008 Junichi Uekawa dan...@debian.org +Copyright (C) 2008 Francesco Poli f...@firenze.linux.it This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by diff --git a/lib/apt-listbugs/logic.rb b/lib/apt-listbugs/logic.rb index 1982a1e..d86e833 100644 --- a/lib/apt-listbugs/logic.rb +++ b/lib/apt-listbugs/logic.rb @@ -2,6 +2,7 @@ # # Copyright (C) 2002 Masato Taruishi t...@debian.org # Copyright (C) 2006-2008 Junichi Uekawa dan...@debian.org +# Copyright (C) 2008 Francesco Poli f...@firenze.linux.it # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -44,6 +45,7 @@ class AppConfig sprintf(_( -s severities : Severities you want to see [%s], or [all].\n), @severity.join(',')), _(
Bug#476988: [PATCH] 0.0.95 release (add --bugs option, new uploader)
add a new option (--bugs) to only show bugs that belong to a given set add Francesco Poli to the uploaders list --- apt-listbugs | 11 +-- debian/changelog |8 debian/control|1 + debian/copyright |5 +++-- lib/apt-listbugs/logic.rb | 14 +- 5 files changed, 34 insertions(+), 5 deletions(-) diff --git a/apt-listbugs b/apt-listbugs index 8fcc449..3e803e8 100755 --- a/apt-listbugs +++ b/apt-listbugs @@ -4,6 +4,7 @@ # # Copyright (C) 2002 Masato Taruishi t...@debian.org # Copyright (C) 2006-2008 Junichi Uekawa dan...@debian.org +# Copyright (C) 2008 Francesco Poli f...@firenze.linux.it # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -40,7 +41,7 @@ the upgrade/installation is safe. == USAGE -apt-listbugs [-h] [-s severities] [-S stats] [-D] [-H hostname] [-p port] command [arguments] +apt-listbugs [-h] [-s severities] [-S stats] [-B bugs] [-D] [-H hostname] [-p port] command [arguments] == OPTIONS @@ -67,6 +68,10 @@ apt-listbugs [-h] [-s severities] [-S stats] [-D] [-H hostname] [-p port Note that 'pending' does not mean 'tagged pending', but 'still open, pending to be fixed'. +* -B bugs | --bugs bugs + + Bug numbers you want to see separated by comma (e.g. 123456,567890,135792). All other bugs will be ignored. + * -D | --show-downgrade Shows bugs of downgraded packages. (apt mode only) @@ -203,7 +208,8 @@ don't actually apply to the version. You need to review the bug. apt-listbugs was originally written by Masato Taruishi t...@debian.org, and rewritten by Junichi Uekawa dan...@debian.org in 2006 to handle BTS Versioning features and the -SOAP interface. +SOAP interface. The --bugs option was added by Francesco Poli +f...@firenze.linux.it in 2008. Latest source-code is available from http://git.debian.org/?p=apt-listbugs/apt-listbugs.git @@ -332,6 +338,7 @@ rescue end Factory::BugsFactory.delete_ignore_bugs(bugs) if config.command == apt +Factory::BugsFactory.delete_uninteresting_bugs(bugs) if config.fbugs Factory::BugsFactory.delete_unwanted_tag_bugs(bugs) if config.tag begin Factory::BugsFactory.delete_irrelevant_bugs(bugs, cur_pkgs, new_pkgs) { |msg, val| diff --git a/debian/changelog b/debian/changelog index 0b81519..a94992a 100644 --- a/debian/changelog +++ b/debian/changelog @@ -1,3 +1,11 @@ +apt-listbugs (0.0.95) unstable; urgency=low + + * fix please implement a command to query the BTS about a given bug in +given package/version (Closes: #476988) + * added Francesco Poli to the uploaders list + + -- Francesco Poli (t1000) f...@firenze.linux.it Thu, 11 Dec 2008 23:58:31 +0100 + apt-listbugs (0.0.94) unstable; urgency=low * remove a trace of -R option which used to be 'release-critical' which diff --git a/debian/control b/debian/control index c3fd35e..44e7c9f 100644 --- a/debian/control +++ b/debian/control @@ -2,6 +2,7 @@ Source: apt-listbugs Section: admin Priority: optional Maintainer: Junichi Uekawa dan...@debian.org +Uploaders: Francesco Poli (t1000) f...@firenze.linux.it Build-Depends: debhelper ( 5.0.0), cdbs, time Build-Depends-Indep: ruby1.8, rdtool, gettext Standards-Version: 3.7.2 diff --git a/debian/copyright b/debian/copyright index 8d9a9d5..e9d68e5 100644 --- a/debian/copyright +++ b/debian/copyright @@ -4,8 +4,9 @@ The original source can always be found at: http://ftp.debian.org/debian/pool/main/a/apt-listbugs/ http://git.debian.org/?p=apt-listbugs/apt-listbugs.git -Copyright (C) 2002 Masato Taruishi -Copyright (C) 2006 Junichi Uekawa +Copyright (C) 2002 Masato Taruishi t...@debian.org +Copyright (C) 2006-2008 Junichi Uekawa dan...@debian.org +Copyright (C) 2008 Francesco Poli f...@firenze.linux.it This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as published by diff --git a/lib/apt-listbugs/logic.rb b/lib/apt-listbugs/logic.rb index 1982a1e..d86e833 100644 --- a/lib/apt-listbugs/logic.rb +++ b/lib/apt-listbugs/logic.rb @@ -2,6 +2,7 @@ # # Copyright (C) 2002 Masato Taruishi t...@debian.org # Copyright (C) 2006-2008 Junichi Uekawa dan...@debian.org +# Copyright (C) 2008 Francesco Poli f...@firenze.linux.it # # This program is free software; you can redistribute it and/or modify # it under the terms of the GNU General Public License as published by @@ -44,6 +45,7 @@ class AppConfig sprintf(_( -s severities : Severities you want to see [%s], or [all].\n), @severity.join(',')), _( -T tags: Tags you want to see.\n), sprintf(_( -S stats : Stats you want to see [%s].\n), @stats.join(',')), + _( -B bugs: Bugs you want to see.\n), _( -D : Show downgraded packages, too.\n), sprintf(_( -H hostname: Hostname of Debian Bug Tracking System