Bug#486937: DEB_BUILD_OPTIONS must be whitespace-separated
On Thu, 19 Jun 2008, Raphael Hertzog wrote: This is already fixed in the master branch which contains the version 1.15.0 intended for lenny+1. http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=9866c4bafdf147ad764f31e2747f5c1012802b1d Should that fix be backported into the lenny branch? What do release managers think of this? buxy can someone from the release team reply to http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=486937#10 please ? luk_ oh, I thought you applied it to the lenny branch too I didn't think there was an explicit ack needed buxy luk_: well policy 3.8.0 is not RC for lenny so I preferred to be on the safe side I took this as a yes and applied the fix in the lenny branch. It will be in dpkg 1.14.21. Cheers, -- Raphaël Hertzog Le best-seller français mis à jour pour Debian Etch : http://www.ouaza.com/livre/admin-debian/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486937: DEB_BUILD_OPTIONS must be whitespace-separated
Hi, On Wed, 18 Jun 2008, Peter Samuelson wrote: Package: dpkg-dev Version: 1.14.20 Severity: serious Tags: patch Policy 3.8.0.1, section 4.9.1, on DEB_BUILD_OPTIONS: If multiple flags are given, they must be separated by whitespace. dpkg-buildpackage uses , separators instead, which breaks any rules file that follows the example code in Policy. Presumably this bug is not RC for lenny, as the relevant Policy text is new to 3.8.0. This is already fixed in the master branch which contains the version 1.15.0 intended for lenny+1. http://git.debian.org/?p=dpkg/dpkg.git;a=commitdiff;h=9866c4bafdf147ad764f31e2747f5c1012802b1d Should that fix be backported into the lenny branch? What do release managers think of this? Cheers, -- Raphaël Hertzog Le best-seller français mis à jour pour Debian Etch : http://www.ouaza.com/livre/admin-debian/ -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#486937: DEB_BUILD_OPTIONS must be whitespace-separated
[Raphael Hertzog] Should that fix be backported into the lenny branch? I've already fixed my package to work around this ... but it _would_ be a bit of a shame for the debian/rules example code suggested by Policy section 4.9.1 to not actually work until lenny+1. And maintainers might not even notice the fact that DEB_BUILD_OPTIONS is ignored in their package - I mean, who tests that? So that's kind of bad too. -- Peter Samuelson | org-tld!p12n!peter | http://p12n.org/ signature.asc Description: Digital signature
Bug#486937: DEB_BUILD_OPTIONS must be whitespace-separated
Package: dpkg-dev
Version: 1.14.20
Severity: serious
Tags: patch
Policy 3.8.0.1, section 4.9.1, on DEB_BUILD_OPTIONS:
If multiple flags are given, they must be separated by whitespace.
dpkg-buildpackage uses , separators instead, which breaks any rules
file that follows the example code in Policy.
Presumably this bug is not RC for lenny, as the relevant Policy text is
new to 3.8.0.
diff -urN dpkg-1.14.20.orig/scripts/Dpkg/BuildOptions.pm
dpkg-1.14.20/scripts/Dpkg/BuildOptions.pm
--- dpkg-1.14.20.orig/scripts/Dpkg/BuildOptions.pm 2008-06-18
02:33:30.0 -0500
+++ dpkg-1.14.20/scripts/Dpkg/BuildOptions.pm 2008-06-18 23:45:52.0
-0500
@@ -38,13 +38,13 @@
$overwrite = 1 if not defined($overwrite);
my $env = $overwrite ? '' : $ENV{DEB_BUILD_OPTIONS}||'';
-if ($env) { $env .= ',' }
+if ($env) { $env .= ' ' }
while (my ($k, $v) = each %$opts) {
if ($v) {
- $env .= $k=$v,;
+ $env .= $k=$v ;
} else {
- $env .= $k,;
+ $env .= $k ;
}
}
