Bug#493560: uswsusp: LFS.patch should be applied directly
Package: uswsusp Version: 0.8-1 Severity: normal Hi Tim, debian/patches/LFS.patch modifies debian/rules and sets CFLAGS/LDFLAGS. As the patch is applied *after* debian/rules has been called, they will not have any effect. The general rule of thumb is, that changes to debian/ should be applied directly and changes to the upstream sources should be applied via distinct patches in debian/patches/. Cheers, Michael -- System Information: Debian Release: lenny/sid APT prefers unstable APT policy: (500, 'unstable'), (300, 'experimental') Architecture: i386 (i686) Kernel: Linux 2.6.26.1 Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/dash Versions of packages uswsusp depends on: ii debconf [debconf-2.0] 1.5.23 Debian configuration management sy ii libc6 2.7-13 GNU C Library: Shared libraries ii libdirectfb-1.0-0 1.0.1-10 direct frame buffer graphics - sha ii libgcc1 1:4.3.1-8 GCC support library ii libgcrypt11 1.4.1-1LGPL Crypto library - runtime libr ii libglib2.0-0 2.16.5-1 The GLib library of C routines ii libgpg-error0 1.4-2 library for common error values an ii liblzo2-2 2.03-1 data compression library ii libpci3 1:3.0.0-4 Linux PCI Utilities (shared librar ii libsplashy1 0.3.10-2 Library to draw splash screen on b ii libx86-1 1.1+ds1-2 x86 real-mode library Versions of packages uswsusp recommends: ii initramfs-tools 0.92e tools for generating an initramfs ii mount 2.13.1.1-1 Tools for mounting and manipulatin Versions of packages uswsusp suggests: pn splashy none (no description available) -- debconf information excluded -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#493560: uswsusp: LFS.patch should be applied directly
Op Sun, 03 Aug 2008 10:41:47 +0200 schreef Michael Biebl [EMAIL PROTECTED]: Package: uswsusp Version: 0.8-1 Severity: normal Hi Tim, debian/patches/LFS.patch modifies debian/rules and sets CFLAGS/LDFLAGS. As the patch is applied *after* debian/rules has been called, they will not have any effect. The general rule of thumb is, that changes to debian/ should be applied directly and changes to the upstream sources should be applied via distinct patches in debian/patches/. Hmm, isn't that one of yours? Uhm, no, indeed it was attached to the bug, seemed harmless and I dropped it into place. But, I guess your right. I'll have to fix it in the next upload. grts TIm -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
