Bug#496875: lintian reports build-depends-on-obsolete-package as an error

2008-08-28 Thread Steve Langasek
Package: lintian
Version: 1.24.4
Severity: important

lintian currently reports the following error for the samba 2:3.2.3-1 source
package:

E: samba source: build-depends-on-obsolete-package build-depends: libcupsys2-dev

But this package has a deliberate *or'ed* build-dependency to facilitate
backporting:

  libcups2-dev | libcupsys2-dev

So this is not an error, and lintian should not report it as such.

-- 
Steve Langasek   Give me a lever long enough and a Free OS
Debian Developer   to set it on, and I can move the world.
Ubuntu Developerhttp://www.debian.org/
[EMAIL PROTECTED] [EMAIL PROTECTED]



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#496875: lintian reports build-depends-on-obsolete-package as an error

2008-08-28 Thread Frank Lichtenheld
On Thu, Aug 28, 2008 at 12:31:18AM -0700, Steve Langasek wrote:
 lintian currently reports the following error for the samba 2:3.2.3-1 source
 package:
 
 E: samba source: build-depends-on-obsolete-package build-depends: 
 libcupsys2-dev
 
 But this package has a deliberate *or'ed* build-dependency to facilitate
 backporting:
 
   libcups2-dev | libcupsys2-dev
 
 So this is not an error, and lintian should not report it as such.

This was fixed for dependencies in 76bb09a06cd86412505c33036ddd4ad89645ef42.
Should probably be adapted for build-dependencies as well.

Gruesse,
-- 
Frank Lichtenheld [EMAIL PROTECTED]
www: http://www.djpig.de/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#496875: lintian reports build-depends-on-obsolete-package as an error

2008-08-28 Thread Adam D. Barratt
On Thu, August 28, 2008 14:07, Frank Lichtenheld wrote:
 On Thu, Aug 28, 2008 at 12:31:18AM -0700, Steve Langasek wrote:
[...]
 But this package has a deliberate *or'ed* build-dependency to facilitate
 backporting:

   libcups2-dev | libcupsys2-dev

 So this is not an error, and lintian should not report it as such.

 This was fixed for dependencies in
 76bb09a06cd86412505c33036ddd4ad89645ef42.
 Should probably be adapted for build-dependencies as well.

At the time, I only patched the code that deals with dependencies as it
was suggested that OR-ed build-depends on obsolete packages were generally
pointless due to the way sbuild interprets them (see #486145).

Backporting is one case where they do make sense however. It's a fairly
simple change to add support for OR-ed build-deps; I'll do so in the next
couple of days unless there are any objections.

Adam




-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#496875: lintian reports build-depends-on-obsolete-package as an error

2008-08-28 Thread Frank Lichtenheld
On Thu, Aug 28, 2008 at 06:46:25PM +0100, Adam D. Barratt wrote:
 On Thu, August 28, 2008 14:07, Frank Lichtenheld wrote:
  On Thu, Aug 28, 2008 at 12:31:18AM -0700, Steve Langasek wrote:
 [...]
  But this package has a deliberate *or'ed* build-dependency to facilitate
  backporting:
 
libcups2-dev | libcupsys2-dev
 
  So this is not an error, and lintian should not report it as such.
 
  This was fixed for dependencies in
  76bb09a06cd86412505c33036ddd4ad89645ef42.
  Should probably be adapted for build-dependencies as well.
 
 At the time, I only patched the code that deals with dependencies as it
 was suggested that OR-ed build-depends on obsolete packages were generally
 pointless due to the way sbuild interprets them (see #486145).

Yeah, they do not really help for backports.org backports, but might
for private ones. And they also don't really hurt in unstable
precisely due to the sbuild behaviour. So it is probably better to
reduce the severity of the tag like we did for dependencies as well.

Gruesse,
-- 
Frank Lichtenheld [EMAIL PROTECTED]
www: http://www.djpig.de/



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]