Bug#498308: ntop: /etc/default/ntop - incomplete comments to document variables
On 01/-10/-28163 11:59 AM, jaalto wrote: /etc/default/ntop reads: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg #GETOPT= The variables that can be set are not mentioned. SUGGESTION Please make it read: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg # GETOPT= + # USER=ntop + # INTERFACES=eth0 I gave this problem some thinking: -having the same options in 2 places is wrong: the admin should not be able to just override the values set via debconf -we do not want the admin to be change the USER variable by hand, because permission needs to be fixed if that variable is changed -variables set via debconf (USER, INTERFACES) should not be in a conffile, while variables not set via debconf (GETOPT) should be in a conffile. Therefore they cannot be all in the /etc/default/ntop. So I believe a solution is -no longer include /var/lib/ntop/init.cfg from /etc/default/ntop, and use the latter only for the GETOPT (and ENABLED) options -include /var/lib/ntop/init.cfg directly from the init script I wonder what is GETOP for? Perhaps a comment beside it would help to orient reader better. Adding a comment. I'm not sure the function of /var/lib/ntop/init.cfg because the installation did not ask about any interface to define by default. That's where debconf settings are stored. The guessed interface eth0 is not correct in wireless environment, so it's better to spell out the variables that can be set. Mhm, this should work better now. If not, please open a separate bug. Thanks, Ludovico -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#498308: ntop: /etc/default/ntop - incomplete comments to document variables
On 04/18/2011 11:54 PM, jari wrote: I agree. Please also add comment to the beginning of /etc/default/ntop # NOTE: to configure more variables, run dpkg-reconfiggure --priority=low ntop Good! Yes, already added ;) Thanks, Ludovico -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#498308: ntop: /etc/default/ntop - incomplete comments to document variables
On 2011-04-18 22:58, Ludovico Cavedon wrote: | On 01/-10/-28163 11:59 AM, jaalto wrote: | /etc/default/ntop reads: | | # This file will normally include the debconf template but you can disable | # that and use this file only. | | . /var/lib/ntop/init.cfg | #GETOPT= | | The variables that can be set are not mentioned. | | SUGGESTION | | Please make it read: | | # This file will normally include the debconf template but you can disable | # that and use this file only. | . /var/lib/ntop/init.cfg | # GETOPT= | + # USER=ntop | + # INTERFACES=eth0 | | I gave this problem some thinking: | -having the same options in 2 places is wrong: the admin should not be | able to just override the values set via debconf | -we do not want the admin to be change the USER variable by hand, | because permission needs to be fixed if that variable is changed | -variables set via debconf (USER, INTERFACES) should not be in a | conffile, while variables not set via debconf (GETOPT) should be in a | conffile. Therefore they cannot be all in the /etc/default/ntop. | | So I believe a solution is | -no longer include /var/lib/ntop/init.cfg from /etc/default/ntop, and | use the latter only for the GETOPT (and ENABLED) options | -include /var/lib/ntop/init.cfg directly from the init script I agree. Please also add comment to the beginning of /etc/default/ntop # NOTE: to configure more variables, run dpkg-reconfiggure --priority=low ntop Jari -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#498308: ntop: /etc/default/ntop - incomplete comments to document variables
severity 498308 minor thanks Hi Jari On Wed, Sep 10, 2008 at 07:05:1888AM +0300, Jari Aalto wrote: Ola Lundqvist [EMAIL PROTECTED] writes: Hi Jaalto On Tue, Sep 09, 2008 at 12:47:18AM +0300, jaalto wrote: Package: ntop Version: 3:3.3-11+b2 Severity: normal /etc/default/ntop reads: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg #GETOPT= The variables that can be set are not mentioned. The variables to use are any variables for /etc/init.d/ntop Please add those in comments to the /etc/default/ntop file. Yes that is a good thing to do. SUGGESTION Please make it read: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg # GETOPT= + # USER=ntop + # INTERFACES=eth0 I wonder what is GETOP for? Perhaps a comment beside it would help to orient reader better. See the /etc/init.d/ntop script. There you can see what $GETOPT and other variables are used for. 95 start-stop-daemon --start --quiet --name $NAME --exec $DAEMON -- \ 96 -d -L -u $USER -P $HOMEDIR \ 97 --access-log-file=$LOGDIR/access.log -i $INTERFACES \ 98 -p /etc/ntop/protocol.list \ 99 -O $LOGDIR $GETOPT It's better to document them in /etc/default/ntop and tell what to do. Of course. Also you can read in /var/lib/ntop/init.cfg what to set. It's not clear by reading /etc/init.d/ntop. This is how /etc/default/nfs-kernel-server for example does it: Yes that is a good thing to add documentation. Patches are welcome. Best regards, // Ola # Number of servers to start up RPCNFSDCOUNT=8 # Runtime priority of server (see nice(1)) RPCNFSDPRIORITY=0 # Options for rpc.mountd. # If you have a port-based firewall, you might want to set up # a fixed port here using the --port option. For more information, # see rpc.mountd(8) or http://wiki.debian.org/?SecuringNFS RPCMOUNTDOPTS= # Do you want to start the svcgssd daemon? It is only required for Kerberos # exports. Valid alternatives are yes and no; the default is no. NEED_SVCGSSD= # Options for rpc.svcgssd. RPCSVCGSSDOPTS= I'm not sure the function of /var/lib/ntop/init.cfg because the installation did not ask about any interface to define by default. If that is the case then you have set a too low debconf severity level for your installation. The questions are medium if eth0 is up and high if not. -- - Ola Lundqvist --- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | http://inguza.com/ +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#498308: ntop: /etc/default/ntop - incomplete comments to document variables
Ola Lundqvist [EMAIL PROTECTED] writes: Hi Jaalto On Tue, Sep 09, 2008 at 12:47:18AM +0300, jaalto wrote: Package: ntop Version: 3:3.3-11+b2 Severity: normal /etc/default/ntop reads: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg #GETOPT= The variables that can be set are not mentioned. The variables to use are any variables for /etc/init.d/ntop Please add those in comments to the /etc/default/ntop file. SUGGESTION Please make it read: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg # GETOPT= + # USER=ntop + # INTERFACES=eth0 I wonder what is GETOP for? Perhaps a comment beside it would help to orient reader better. See the /etc/init.d/ntop script. There you can see what $GETOPT and other variables are used for. 95 start-stop-daemon --start --quiet --name $NAME --exec $DAEMON -- \ 96 -d -L -u $USER -P $HOMEDIR \ 97 --access-log-file=$LOGDIR/access.log -i $INTERFACES \ 98 -p /etc/ntop/protocol.list \ 99 -O $LOGDIR $GETOPT It's better to document them in /etc/default/ntop and tell what to do. Also you can read in /var/lib/ntop/init.cfg what to set. It's not clear by reading /etc/init.d/ntop. This is how /etc/default/nfs-kernel-server for example does it: # Number of servers to start up RPCNFSDCOUNT=8 # Runtime priority of server (see nice(1)) RPCNFSDPRIORITY=0 # Options for rpc.mountd. # If you have a port-based firewall, you might want to set up # a fixed port here using the --port option. For more information, # see rpc.mountd(8) or http://wiki.debian.org/?SecuringNFS RPCMOUNTDOPTS= # Do you want to start the svcgssd daemon? It is only required for Kerberos # exports. Valid alternatives are yes and no; the default is no. NEED_SVCGSSD= # Options for rpc.svcgssd. RPCSVCGSSDOPTS= I'm not sure the function of /var/lib/ntop/init.cfg because the installation did not ask about any interface to define by default. If that is the case then you have set a too low debconf severity level for your installation. The questions are medium if eth0 is up and high if not. -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#498308: ntop: /etc/default/ntop - incomplete comments to document variables
Package: ntop Version: 3:3.3-11+b2 Severity: normal /etc/default/ntop reads: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg #GETOPT= The variables that can be set are not mentioned. SUGGESTION Please make it read: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg # GETOPT= + # USER=ntop + # INTERFACES=eth0 I wonder what is GETOP for? Perhaps a comment beside it would help to orient reader better. I'm not sure the function of /var/lib/ntop/init.cfg because the installation did not ask about any interface to define by default. The guessed interface eth0 is not correct in wireless environment, so it's better to spell out the variables that can be set. -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages ntop depends on: ii adduser3.110 add and remove users and groups ii debconf [debconf-2.0] 1.5.22Debian configuration management sy ii libc6 2.7-13GNU C Library: Shared libraries ii libcairo2 1.6.4-6 The Cairo 2D vector graphics libra ii libfontconfig1 2.6.0-1 generic font configuration library ii libfreetype6 2.3.7-2 FreeType 2 font engine, shared lib ii libgdbm3 1.8.3-3 GNU dbm database routines (runtime ii libglib2.0-0 2.16.4-2 The GLib library of C routines ii libpango1.0-0 1.20.5-1 Layout and rendering of internatio ii libpcap0.8 0.9.8-5 system interface for user-level pa ii libpixman-1-0 0.10.0-2 pixel-manipulation library for X a ii libpng12-0 1.2.27-1 PNG library - runtime ii librrd41.3.1-3 Time-series data storage and displ ii libssl0.9.80.9.8g-13 SSL shared libraries ii libx11-6 2:1.1.4-2 X11 client-side library ii libxcb-render-util00.2.1+git1-1 utility libraries for X C Binding ii libxcb-render0 1.1-1.1 X C Binding, render extension ii libxcb11.1-1.1 X C Binding ii libxml22.6.32.dfsg-3 GNOME XML library ii libxrender11:0.9.4-2 X Rendering Extension client libra ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime ntop recommends no packages. Versions of packages ntop suggests: pn graphviz none (no description available) ii gsfonts 1:8.11+urwcyr1.0.7~pre44-3 Fonts for the Ghostscript interpre -- debconf information excluded -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
Bug#498308: ntop: /etc/default/ntop - incomplete comments to document variables
Hi Jaalto On Tue, Sep 09, 2008 at 12:47:18AM +0300, jaalto wrote: Package: ntop Version: 3:3.3-11+b2 Severity: normal /etc/default/ntop reads: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg #GETOPT= The variables that can be set are not mentioned. The variables to use are any variables for /etc/init.d/ntop SUGGESTION Please make it read: # This file will normally include the debconf template but you can disable # that and use this file only. . /var/lib/ntop/init.cfg # GETOPT= + # USER=ntop + # INTERFACES=eth0 I wonder what is GETOP for? Perhaps a comment beside it would help to orient reader better. See the /etc/init.d/ntop script. There you can see what $GETOPT and other variables are used for. Also you can read in /var/lib/ntop/init.cfg what to set. I'm not sure the function of /var/lib/ntop/init.cfg because the installation did not ask about any interface to define by default. If that is the case then you have set a too low debconf severity level for your installation. The questions are medium if eth0 is up and high if not. The guessed interface eth0 is not correct in wireless environment, so it's better to spell out the variables that can be set. The question is spelled out, as described above. Best regards, // Ola -- System Information: Debian Release: lenny/sid APT prefers testing APT policy: (990, 'testing'), (500, 'unstable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26-1-amd64 (SMP w/2 CPU cores) Locale: LANG=en_DK.UTF-8, LC_CTYPE=en_DK.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages ntop depends on: ii adduser3.110 add and remove users and groups ii debconf [debconf-2.0] 1.5.22Debian configuration management sy ii libc6 2.7-13GNU C Library: Shared libraries ii libcairo2 1.6.4-6 The Cairo 2D vector graphics libra ii libfontconfig1 2.6.0-1 generic font configuration library ii libfreetype6 2.3.7-2 FreeType 2 font engine, shared lib ii libgdbm3 1.8.3-3 GNU dbm database routines (runtime ii libglib2.0-0 2.16.4-2 The GLib library of C routines ii libpango1.0-0 1.20.5-1 Layout and rendering of internatio ii libpcap0.8 0.9.8-5 system interface for user-level pa ii libpixman-1-0 0.10.0-2 pixel-manipulation library for X a ii libpng12-0 1.2.27-1 PNG library - runtime ii librrd41.3.1-3 Time-series data storage and displ ii libssl0.9.80.9.8g-13 SSL shared libraries ii libx11-6 2:1.1.4-2 X11 client-side library ii libxcb-render-util00.2.1+git1-1 utility libraries for X C Binding ii libxcb-render0 1.1-1.1 X C Binding, render extension ii libxcb11.1-1.1 X C Binding ii libxml22.6.32.dfsg-3 GNOME XML library ii libxrender11:0.9.4-2 X Rendering Extension client libra ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime ntop recommends no packages. Versions of packages ntop suggests: pn graphviz none (no description available) ii gsfonts 1:8.11+urwcyr1.0.7~pre44-3 Fonts for the Ghostscript interpre -- debconf information excluded -- - Ola Lundqvist --- / [EMAIL PROTECTED] Annebergsslingan 37 \ | [EMAIL PROTECTED] 654 65 KARLSTAD | | http://inguza.com/ +46 (0)70-332 1551 | \ gpg/f.p.: 7090 A92B 18FE 7994 0C36 4FE4 18A1 B1CF 0FE5 3DD9 / --- -- To UNSUBSCRIBE, email to [EMAIL PROTECTED] with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]
