Bug#504000: chrony: init script hangs for a while might break

2008-11-06 Thread Michael Meskes
 With just “aptitude install chrony”, the “starting” step took a very long
 while, several minutes before doing anything. People might (quite rightfully)
 consider it hung, and interrupt the package installation/upgrade, which then
 leaves the package management system in a bad state.
 
 That's why I'm bumping the severity to its initial value, which seems the 
 right
 one to me.

I beg to disagree because this bug seems to hit only some systems but not all.
Of course I agree that this is bad if your system is hit, but with a lot of
system not being hit I do not consider this release critical. 

Aynway, the best solution is to fix this, if it is fixable on the chrony side
at all.

Michael
-- 
Michael Meskes
Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org)
Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org
ICQ: 179140304, AIM/Yahoo: michaelmeskes, Jabber: [EMAIL PROTECTED]
Go VfL Borussia! Go SF 49ers! Use Debian GNU/Linux! Use PostgreSQL!



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#504000: chrony: init script hangs for a while might break

2008-11-06 Thread Cyril Brulebois
Helmut Grohne [EMAIL PROTECTED] (06/11/2008):
 Did you notice that the bug was reported on i386 initially? So it is
 even a bit cross-architecture.

Sure, but I wasn't going to emphasize something that I didn't experience
personally. ;)

Mraw,
KiBi.


signature.asc
Description: Digital signature


Bug#504000: chrony: init script hangs for a while might break

2008-11-06 Thread John Hasler
Cyril writes:
 All of the boxes in my company are. Too bad I can't test on more
 systems. That's quite different from “a single system”. And it's not like
 amd64 is an obscure architecture, last time I checked.

It works fine on amd64 here as well as on two different i386 boxes.  It has
to do with the rtc clock hardware, not the architecture.
-- 
John Hasler 
[EMAIL PROTECTED]
Elmwood, WI USA



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#504000: chrony: init script hangs for a while might break

2008-11-06 Thread Cyril Brulebois
Michael Meskes [EMAIL PROTECTED] (06/11/2008):
 I beg to disagree because this bug seems to hit only some systems but
 not all.

I didn't upgrade to grave, only to serious.

 Of course I agree that this is bad if your system is hit, but with a
 lot of system not being hit I do not consider this release critical. 

All of the boxes in my company are. Too bad I can't test on more
systems. That's quite different from “a single system”. And it's not
like amd64 is an obscure architecture, last time I checked.

 Aynway, the best solution is to fix this, if it is fixable on the
 chrony side at all.

Sure thing.

Mraw,
KiBi.


signature.asc
Description: Digital signature


Bug#504000: chrony: init script hangs for a while might break

2008-11-06 Thread Helmut Grohne
 All of the boxes in my company are. Too bad I can't test on more
 systems. That's quite different from ???a single system???. And it's not
 like amd64 is an obscure architecture, last time I checked.

Did you notice that the bug was reported on i386 initially? So it is
even a bit cross-architecture.

Helmut



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#504000: chrony: init script hangs for a while might break

2008-11-06 Thread John Hasler
Michael writes:
 I beg to disagree because this bug seems to hit only some systems but not all.
 Of course I agree that this is bad if your system is hit, but with a lot of
 systm not being hit I do not consider this release critical. 

 Aynway, the best solution is to fix this, if it is fixable on the chrony
 side at all.

I'm working on a fix (or at least a workaround) in the initscript.  I'm
putting a subshell containing sleep 5; kill `pidof chronyc' in the
background just before launching chronyc.  This should prevent hangs due to
chronyc being unable to contact chronyd.  I intend to do likewise with the
netstat call as it has been reported to hang for minutes (unreproducible
here).

The new, as yet untested initscript is attached:

#! /bin/sh
#
# Written by Miquel van Smoorenburg [EMAIL PROTECTED].
# Modified for Debian GNU/Linux by Ian Murdock [EMAIL PROTECTED].
# Modified for Debian by Christoph Lameter [EMAIL PROTECTED]
# Modified for chrony by John Hasler [EMAIL PROTECTED] 1998-2008

### BEGIN INIT INFO
# Provides:  time-daemon
# Required-Start:$local_fs
# Required-Stop: $local_fs
# Default-Start: 2 3 4 5
# Default-Stop:  0 1 6
# Short-Description:  Controls chronyd NTP time daemon
# Description:   Chronyd is the NTP time daemon in the Chrony package
#  
### END INIT INFO


PATH=/bin:/usr/bin:/sbin:/usr/sbin
DAEMON=/usr/sbin/chronyd
FLAGS=defaults
NAME=chronyd
DESC=time daemon

putonline ()
{ # Do we have a default route?  If so put chronyd online.
(sleep 5; kill `pidof netstat` 2 /dev/null) 
if netstat -rn 2/dev/null | grep UG | cut -f 1 -d ' ' | grep -q '0\.0\.0\.0'
then
	KEY=$(awk '$1 ~ /^commandkey$/ { print $2; exit}' /etc/chrony/chrony.conf)
	PASSWORD=`awk '$1 ~ /^'$KEY'$/ {print $2; exit}' /etc/chrony/chrony.keys`
	# Make sure chronyc can't hang us up.
	(sleep 5; kill `pidof chronyc` 2 /dev/null) 
	/usr/bin/chronyc  EOF
password $PASSWORD
online
burst 5/10
quit
EOF
	touch /var/run/chrony-ppp-up
fi
}

test -f $DAEMON || exit 0

case $1 in
start)
	start-stop-daemon --start --verbose --exec $DAEMON
	/bin/pidof $DAEMON  /dev/null || sleep 1  # Chronyd can take a few milliseconds to start.
	/bin/pidof $DAEMON  /dev/null || echo $DAEMON failed to start.  exit 1
	putonline
	;;
stop)
	start-stop-daemon --stop --verbose --oknodo --exec $DAEMON
	rm -f /var/run/chrony-ppp-up
	;;
restart|force-reload)
	echo -n Restarting $DESC: 
	start-stop-daemon --stop --quiet --exec $DAEMON
	sleep 1
	start-stop-daemon --start --quiet --exec $DAEMON -- -r
	/bin/pidof $DAEMON  /dev/null || sleep 1  # Chronyd can take a few milliseconds to start.
	/bin/pidof $DAEMON  /dev/null || echo $DAEMON failed to restart.  exit 1
	putonline
	echo $NAME.
	;;
*)
	echo Usage: /etc/init.d/chrony {start|stop|restart|force-reload}
	exit 1
	;;
esac

exit 0

-- 
John Hasler 
[EMAIL PROTECTED]
Elmwood, WI USA


Bug#504000: chrony: init script hangs for a while might break upgrade

2008-11-05 Thread Cyril Brulebois
severity 504000 serious
thanks

On Thu, Oct 30, 2008 at 12:51:58PM +0100, Helmut Grohne wrote:
 Package: chrony
 Version: 1.23-3
 Severity: grave
 Justification: renders package unusable
 
 # /etc/init.d/chrony start
 Starting /usr/sbin/chronyd...

With just “aptitude install chrony”, the “starting” step took a very long
while, several minutes before doing anything. People might (quite rightfully)
consider it hung, and interrupt the package installation/upgrade, which then
leaves the package management system in a bad state.

That's why I'm bumping the severity to its initial value, which seems the right
one to me.
 
 My chrony.conf only differs from the default in the set of servers used (i.e.
 only lines starting with server are changed and only the second field is
 changed).

No local modifications here.

Mraw,
KiBi.


signature.asc
Description: Digital signature