Hi Tim, > I think a delay of 1 second is probably five times too long even in > worst cases, but if I didn't make mistakes in the code, it won't matter > because a signal will arrive quickly. Exactly, so it wouldn't hurt to increase it.
> Slower machines don't necessarily make the race condition more likely to > occur. Well, if the directFB initialization takes longer, the race condition is more likely to occur AFAICS. It would be a lot longer, though. > The "window of error" is only the execution of a few lines of code. > This bug was triggered simply by moving from inittop to premount. > Milliseconds of difference. But even with the previous code, the race condition could have occured. The point I'm making is why take the (probably very small) chance that this bug shows up again on systems that might be different from what we are testing on now. But let's just leave this to Luis :-) Gr. Matthijs
signature.asc
Description: Digital signature