Bug#505723: FTBFS with GCC 4.4: missing #include

2008-11-14 Thread Martin Michlmayr
Package: webkit
Version: 1.0.1-4
User: [EMAIL PROTECTED]
Usertags: ftbfs-gcc-4.4
Tags: patch

Your package fails to build with the upcoming GCC 4.4.  Version 4.4
has not been released yet but I'm building with a snapshot in order
to find errors and give people an advance warning.

GCC 4.4 cleaned up some more C++ headers.  You always have to #include
headers directly and cannot rely for things to be included indirectly.

You can reproduce this problem with gcc-snapshot from unstable.

 Automatic build of webkit_1.0.1-4 on em64t by sbuild/amd64 0.53
...
 mv -f 
 WebKitTools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-GCControllerGtk.Tpo
  
 WebKitTools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-GCControllerGtk.Po
 g++ -Wl,--as-needed -DHAVE_CONFIG_H -I. -I..  -I../WebKitTools/DumpRenderTree 
 -I../WebKitTools/DumpRenderTree/gtk -I../WebKit/gtk -I./WebKit/gtk 
 -DWTF_USE_ICU_UNICODE=1 -DBUILDING_CAIRO__=1 -DBUILDING_GTK__=1 -DWTF_CHANGES 
  -DXP_UNIX -DNDEBUG-I../JavaScriptCore 
 -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/wtf 
 -I../JavaScriptCore/kjs -I./DerivedSources 
 -I../JavaScriptCore/ForwardingHeaders -I../JavaScriptCore/VM 
 -I../JavaScriptCore/profiler -I../JavaScriptCore/wtf/unicode 
 -I./JavaScriptCore/pcre -I./JavaScriptCore/kjs  -fno-strict-aliasing -O2 
 -pthread -I/usr/include/glib-2.0 -I/usr/lib/glib-2.0/include   -D_REENTRANT 
 -I/usr/include/gtk-2.0 -I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 
 -I/usr/include/cairo -I/usr/include/pango-1.0 -I/usr/include/glib-2.0 
 -I/usr/lib/glib-2.0/include -I/usr/include/freetype2 -I/usr/include/directfb 
 -I/usr/include/libpng12 -I/usr/include/pixman-1 -I/usr/include/libxml2   
 -fvisibility-inlines-hidden -fno-rtti -Wall -W -Wcast-align -Wchar-subscripts 
 -Wreturn-type -Wformat -Wformat-security -Wno-format-y2k -Wundef 
 -Wmissing-format-attribute -Wpointer-arith -Wwrite-strings 
 -Wno-unused-parameter -Wno-parentheses -fno-exceptions -fvisibility=hidden -g 
 -Wall -O2 -MT 
 WebKitTools/DumpRenderTree/gtk/Programs_DumpRenderTree-LayoutTestControllerGtk.o
  -MD -MP -MF 
 WebKitTools/DumpRenderTree/gtk/.deps/Programs_DumpRenderTree-LayoutTestControllerGtk.Tpo
  -c -o 
 WebKitTools/DumpRenderTree/gtk/Programs_DumpRenderTree-LayoutTestControllerGtk.o
  `test -f 'WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp' || 
 echo '../'`WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp
 In file included from 
 ../WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:34:
 ../WebKitTools/DumpRenderTree/WorkQueueItem.h:49: warning: type qualifiers 
 ignored on function return type
 ../WebKitTools/DumpRenderTree/WorkQueueItem.h:50: warning: type qualifiers 
 ignored on function return type
 ../WebKitTools/DumpRenderTree/WorkQueueItem.h:71: warning: type qualifiers 
 ignored on function return type
 ../WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp: In function 
 'gboolean waitToDumpWatchdogFired(void*)':
 ../WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:159: error: 
 'stderr' was not declared in this scope
 ../WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:159: error: 
 'fprintf' was not declared in this scope
 ../WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:160: error: 
 'stdout' was not declared in this scope
 make[2]: *** 
 [WebKitTools/DumpRenderTree/gtk/Programs_DumpRenderTree-LayoutTestControllerGtk.o]
  Error 1
 make[2]: Leaving directory `/build/tbm/webkit-1.0.1/build'
 make[1]: *** [all] Error 2

--- WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp~ 2008-11-14 
16:43:19.0 +
+++ WebKitTools/DumpRenderTree/gtk/LayoutTestControllerGtk.cpp  2008-11-14 
16:43:27.0 +
@@ -35,6 +35,7 @@
 #include JavaScriptCore/JSRetainPtr.h
 #include JavaScriptCore/JSStringRef.h
 
+#include cstdio
 #include glib.h
 
 LayoutTestController::~LayoutTestController()

-- 
Martin Michlmayr
http://www.cyrius.com/



--
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]



Bug#505723: FTBFS with GCC 4.4: missing #include

2008-11-14 Thread Alp Toker
Fixed upstream in WebKit r38406

http://trac.webkit.org/changeset/38406

Thanks for the report.



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of unsubscribe. Trouble? Contact [EMAIL PROTECTED]