Bug#506696: libmodule-build-perl: Breaks build of Zim, share files no more installed

2009-01-16 Thread Raphael Hertzog
clone 506696 -1
reassign -1 zim 0.27-1
retitle -1 zim build system incompatible with latest Module::Build
thanks

On Fri, 16 Jan 2009, Niko Tyni wrote:
> Please clone and/or reassign #506696 as you deem appropriate. Clearly
> zim needs to adapt somehow.

Done, thanks.

Cheers,
-- 
Raphaël Hertzog

Le best-seller français mis à jour pour Debian Etch :
http://www.ouaza.com/livre/admin-debian/



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#506696: libmodule-build-perl: Breaks build of Zim, share files no more installed

2009-01-16 Thread Niko Tyni
On Sun, Nov 23, 2008 at 11:03:49PM +0200, Niko Tyni wrote:
> On Sun, Nov 23, 2008 at 08:44:24PM +0100, Raphael Hertzog wrote:
> > Package: libmodule-build-perl
> > Version: 0.3000-1
> > Severity: important
> > 
> > For some reason, this version of the module doesn't install files from
> > blib/share/ where it used to install them and this breaks zim's build.
> > The version of the module in perl-modules works and I used that as a
> > work-around in the meantime (Build-Conflicting on libmodule-build-perl).

> It looks to me like zim's Build.PL may be poking at Module::Build
> internals too much by adding a new key ('share') in each install_sets
> hash.

> I'll ask upstream if this is considered a bug or not.

Quoting Eric Wilhelm in https://rt.cpan.org/Ticket/Display.html?id=41166 :

> I think that code is out-of-bounds by modifying the install_sets
> element directly.  It would possibly be less breakable if it were done
> local() in one of the overridden methods, but probably Module::Build
> should offer some "official" 'share' directory as part of the API.

Please clone and/or reassign #506696 as you deem appropriate. Clearly
zim needs to adapt somehow.
-- 
Niko Tyni   nt...@debian.org



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#506696: libmodule-build-perl: Breaks build of Zim, share files no more installed

2008-11-23 Thread Niko Tyni
On Sun, Nov 23, 2008 at 08:44:24PM +0100, Raphael Hertzog wrote:
> Package: libmodule-build-perl
> Version: 0.3000-1
> Severity: important
> 
> For some reason, this version of the module doesn't install files from
> blib/share/ where it used to install them and this breaks zim's build.
> The version of the module in perl-modules works and I used that as a
> work-around in the meantime (Build-Conflicting on libmodule-build-perl).
> 
> Please check what's wrong.

The change that broke this is

 https://svn.perl.org/viewvc/modules?view=revision&revision=11816

r11816 | schwern | 2008-09-18 16:24:32 +0300 (Thu, 18 Sep 2008) | 10 lines

 [EMAIL PROTECTED]:  schwern | 2008-09-18 06:24:09 -0700
 It's necessary to set_install_paths from config when resuming in order to
 make "make install INSTALLSITELIB=foo" emulation work.  It changes the
 installsitelib config value.
 
 Change LIB to alter config rather than set install_path.  This properly
 emulates MakeMaker's behavior and allows "make install INSTALLDIRS=site 
INSTALLSITELIB=foo" to override.
 
 All tests now pass.

It looks to me like zim's Build.PL may be poking at Module::Build
internals too much by adding a new key ('share') in each install_sets
hash.

In any case, the poking is not preserved during the Build call anymore,
because Module::Build::Base::resume() now explicitly resets install_sets
by calling the _set_install_paths() method.

I'll ask upstream if this is considered a bug or not.
-- 
Niko Tyni   [EMAIL PROTECTED]



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]



Bug#506696: libmodule-build-perl: Breaks build of Zim, share files no more installed

2008-11-23 Thread Raphael Hertzog
Package: libmodule-build-perl
Version: 0.3000-1
Severity: important

For some reason, this version of the module doesn't install files from
blib/share/ where it used to install them and this breaks zim's build.
The version of the module in perl-modules works and I used that as a
work-around in the meantime (Build-Conflicting on libmodule-build-perl).

Please check what's wrong.

-- System Information:
Debian Release: lenny/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (500, 'testing'), (500, 'stable'), (1, 
'experimental')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/1 CPU core)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash



-- 
To UNSUBSCRIBE, email to [EMAIL PROTECTED]
with a subject of "unsubscribe". Trouble? Contact [EMAIL PROTECTED]