Bug#511044: clean-patched depends on configure-stamp

2009-02-23 Thread Sven Mueller
Unfortunately, as far as I recall, simply dropping configure-stamp from
the clean-patched target was basically prohibiting the (policy mandated)
ability to run debian/rules clean to get back from any state of the
build tree to one which was equivalent to the pristine unpacked source
(i.e. unpacked of orig.tar.gz and patch from with diff.gz applied),
basically giving you the option to build twice in a row without first
unpacking the source again.

Anyway, this might get fixed with the removal of our huge patch of the
upstream build system (basically running autotools in preparation of a
sourceful upload instead of running them during the build process).

Duncan: This is for you to keep in mind while doing the 2.3 stuff:
Since you already removed the autoconf patch and are running the
autotools instead during build, please check wether you can actually do
a debian/rules clean and get back to a state where no modifications
are left in the build tree except for the removal of autogenerated files.

Regards,
Sven



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#511044: clean-patched depends on configure-stamp

2009-01-06 Thread Jack Bates
Package: cyrus-imapd-2.2
Version: 2.2.13
Severity: minor
Tags: patch

I encountered this error when trying to build the cyrus-imapd-2.2 package with 
pbuilder:

checking sasl/sasl.h usability... no
checking sasl/sasl.h presence... no
checking for sasl/sasl.h... no
configure: error: Cannot continue without libsasl2.
Get it from ftp://ftp.andrew.cmu.edu/pub/cyrus-mail/.
make: *** [configure-stamp] Error 1
dpkg-buildpackage: failure: fakeroot debian/rules clean gave error exit status 2

I think this is because pbuilder runs the debian/rules clean target outside of 
the build root, but the build dependencies are not satisfied outside of the 
build root. With many packages, I do not encounter this error because the 
debian/rules clean target does not depend on (most of) the build dependencies.

I dropped the debian/rules clean-patched dependency on configure-stamp and 
built the package successfully. I wonder if this dependency is really 
necessary? If it could be safely dropped, then building the package with 
pbuilder would be more convenient...

-- System Information:
Debian Release: 5.0
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)

Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash
--- a/cyrus-imapd-2.2-2.2.13/debian/rules   2009-01-06 16:14:26.0 
-0800
+++ b/cyrus-imapd-2.2-2.2.13/debian/rules   2009-01-06 16:17:12.0 
-0800
@@ -92,7 +92,7 @@
 # This is done to make sure the build daemon's source tree is the 
 # same as the one I am using to produce the i386 debs. 
 clean: clean-patched unpatch
-clean-patched: configure-stamp
+clean-patched:
dh_testdir
dh_testroot
-xargs -t -r chmod +x  debian/executable.files