Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
On Wed, Feb 18, 2009 at 10:55:07AM +0100, Micha Lenk wrote: I wrote some minutes ago: Is the package where you encountered this problem publicly available? I'd be happy to take a look at it and try to understand what happened. Yes, libaqbanking in the affected version is in the archive in unstable. You can have a look on the false positives here: http://lintian.debian.org/maintainer/mi...@lenk.info.html#libaqbanking Err, true positives I wanted to say... Ok, there are some issues mixed here: 1) You install the ChangeLog file with dh_installdocs which is a bug in your packaging, since it will already be installed with dh_installchangelogs as changelog. 2) lintian complains about the changelog not being compressed but what it really should complain about is the duplicated changelog file, which it would make it clearer that this is your fault ;) Gruesse, -- Frank Lichtenheld dj...@debian.org www: http://www.djpig.de/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi Frank, Frank Lichtenheld schrieb: On Wed, Feb 18, 2009 at 10:55:07AM +0100, Micha Lenk wrote: I wrote some minutes ago: Is the package where you encountered this problem publicly available? I'd be happy to take a look at it and try to understand what happened. Yes, libaqbanking in the affected version is in the archive in unstable. You can have a look on the false positives here: http://lintian.debian.org/maintainer/mi...@lenk.info.html#libaqbanking Err, true positives I wanted to say... Ok, there are some issues mixed here: 1) You install the ChangeLog file with dh_installdocs which is a bug in your packaging, since it will already be installed with dh_installchangelogs as changelog. Interesting point I've missed so far. Thanks for pointing it out. I will fix that in the next upload. 2) lintian complains about the changelog not being compressed but what it really should complain about is the duplicated changelog file, which it would make it clearer that this is your fault ;) Yes. So, how do we proceed with this bug now? Regards Micha -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmgRtgACgkQWN0/4pnhQbS31ACdFF1DZSCNHfTlgPEVh+yd9ppy uGcAn3xkSJ7823LsUltvQpLMEiTYGVQu =Xcyb -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
On Sat, Feb 21, 2009 at 07:24:30PM +0100, Micha Lenk wrote: Frank Lichtenheld schrieb: 2) lintian complains about the changelog not being compressed but what it really should complain about is the duplicated changelog file, which it would make it clearer that this is your fault ;) Yes. So, how do we proceed with this bug now? I've downgraded it to wishlist. I think it is something that should be fixed eventually, but it is not urgent. If you want you can clone it against your package and close that with your next upload, but I don't really see a point in that. Gruesse, -- Frank Lichtenheld dj...@debian.org www: http://www.djpig.de/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
Frank Lichtenheld dj...@debian.org writes: Ok, there are some issues mixed here: 1) You install the ChangeLog file with dh_installdocs which is a bug in your packaging, since it will already be installed with dh_installchangelogs as changelog. 2) lintian complains about the changelog not being compressed but what it really should complain about is the duplicated changelog file, which it would make it clearer that this is your fault ;) I think the best thing that we can manage here in the short run is to just not issue a tag for this case, since it's occasionally desirable to have both ChangeLog and changelog. (If the maintainer installs NEWS as changelog, for instance.) We could potentially decide at a Policy level that that's not the right thing to do, but we don't really say right now. http://bugs.debian.org/459427 is relevant here. Ideally, we'd detect if ChangeLog and changelog were identical and warn about the duplicate, but I don't see a particularly straightforward way of doing that other than reading in the entire text of both and comparing it or forking a diff process or something, none of which feels horribly appealing. I think I'm going to fix the false positive and call that good enough for this bug and we can revisit it later if someone comes up with a good idea for how to make the test better. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, Russ Allbery wrote: Micha, is it possible that you called the debhelper scripts in the wrong order? If, for example, you called dh_installchangelogs after dh_compress, that could cause this problem. I doubt it because it's called from within a vanilla dh binary-arch call. Is the package where you encountered this problem publicly available? I'd be happy to take a look at it and try to understand what happened. Yes, libaqbanking in the affected version is in the archive in unstable. You can have a look on the false positives here: http://lintian.debian.org/maintainer/mi...@lenk.info.html#libaqbanking Regards Micha -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmb2moACgkQWN0/4pnhQbQTcwCdFAUymQRyVveoRLuK+RybZ2s5 oXcAoLTGH7grvTFbQ+Pkp2HVUPQA4/Xk =s1++ -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi, I wrote some minutes ago: Is the package where you encountered this problem publicly available? I'd be happy to take a look at it and try to understand what happened. Yes, libaqbanking in the affected version is in the archive in unstable. You can have a look on the false positives here: http://lintian.debian.org/maintainer/mi...@lenk.info.html#libaqbanking Err, true positives I wanted to say... Regards Micha -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.9 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iEYEARECAAYFAkmb2vkACgkQWN0/4pnhQbTjTgCg0l+xHMKNqiG+DqcjqwkEcxIF PBcAnjDOy8vpgnEUvBLQODf/YNFHlx9a =qxF6 -END PGP SIGNATURE- -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
Package: lintian Version: 1.24.2.1 Severity: normal Hi, in chapter 12.3 the policy says: Any additional documentation that comes with the package may be installed at the discretion of the package maintainer. Plain text documentation should be installed in the directory `/usr/share/doc/package', where package is the name of the package, and compressed with `gzip -9' unless it is small. This bug report is about the last four words of this paragraph: If a provided plain text file is small it does not need to get compressed. Regardless of this exception Lintian complains about such files with a changelog-file-not-compressed error. For the records: Debhelper (dh_compress) considers files smaller than 4k (typical file system block size) to be small. Regards Micha -- System Information: Debian Release: 5.0 APT prefers stable APT policy: (500, 'stable'), (50, 'unstable') Architecture: i386 (i686) Kernel: Linux 2.6.26-1-686 (SMP w/2 CPU cores) Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages lintian depends on: ii binutils2.18.1~cvs20080103-7 The GNU assembler, linker and bina ii diffstat1.45-2 produces graph of changes introduc ii dpkg-dev1.14.25 Debian package development tools ii file4.26-1 Determines file type using magic ii gettext 0.17-4 GNU Internationalization utilities ii intltool-debian 0.35.0+20060710.1Help i18n of RFC822 compliant conf ii libparse-debianchan 1.1.1-2 parse Debian changelogs and output ii libtimedate-perl1.1600-9 Time and date functions for Perl ii liburi-perl 1.35.dfsg.1-1Manipulates and accesses URI strin ii man-db 2.5.2-4 on-line manual pager ii perl [libdigest-sha 5.10.0-19Larry Wall's Practical Extraction lintian recommends no packages. Versions of packages lintian suggests: ii binutils-multiarch 2.18.1~cvs20080103-7 Binary utilities that support mult ii libtext-template-pe 1.44-1.2 Text::Template perl module ii man-db 2.5.2-4 on-line manual pager -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
Micha Lenk mi...@lenk.info writes: in chapter 12.3 the policy says: Any additional documentation that comes with the package may be installed at the discretion of the package maintainer. Plain text documentation should be installed in the directory `/usr/share/doc/package', where package is the name of the package, and compressed with `gzip -9' unless it is small. This bug report is about the last four words of this paragraph: If a provided plain text file is small it does not need to get compressed. Regardless of this exception Lintian complains about such files with a changelog-file-not-compressed error. For the records: Debhelper (dh_compress) considers files smaller than 4k (typical file system block size) to be small. You missed the portion specifically about changelog files in 12.7: All of these files should be installed compressed using gzip -9, as they will become large with time even if they start out small. There is no unless it is small Policy exception for changelog files, only for other documentation files. This is, among other things, so that the changelog files retain a stable name across packages; they're always changelog.gz and changelog.Debian.gz. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
Russ Allbery schrieb: Micha Lenk mi...@lenk.info writes: in chapter 12.3 the policy says: Any additional documentation that comes with the package may be installed at the discretion of the package maintainer. Plain text documentation should be installed in the directory `/usr/share/doc/package', where package is the name of the package, and compressed with `gzip -9' unless it is small. This bug report is about the last four words of this paragraph: If a provided plain text file is small it does not need to get compressed. Regardless of this exception Lintian complains about such files with a changelog-file-not-compressed error. For the records: Debhelper (dh_compress) considers files smaller than 4k (typical file system block size) to be small. You missed the portion specifically about changelog files in 12.7: All of these files should be installed compressed using gzip -9, as they will become large with time even if they start out small. There is no unless it is small Policy exception for changelog files, only for other documentation files. This is, among other things, so that the changelog files retain a stable name across packages; they're always changelog.gz and changelog.Debian.gz. Thank you for pointing this out. So, you say it's dh_compress that is failing to compress the ChangeLogs if they are smaller than 4k. I would agree on reassigning this bug to debhelper. Regards Micha -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
Micha Lenk mi...@lenk.info writes: Thank you for pointing this out. So, you say it's dh_compress that is failing to compress the ChangeLogs if they are smaller than 4k. I would agree on reassigning this bug to debhelper. I believe that if you install them with dh_installchangelogs, they'll be compressed. I think that's the way you're supposed to install the upstream changelog. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
Russ Allbery wrote: I believe that if you install them with dh_installchangelogs, they'll be compressed. I think that's the way you're supposed to install the upstream changelog. No matter how the changelog is installed, dh_compress is the *only* thing in debhhelper that will compress it, and it will always compress changelogs no matter their size. -- see shy jo signature.asc Description: Digital signature
Bug#515601: lintian: false positive changelog-file-not-compressed if corresponding file is small
Joey Hess jo...@debian.org writes: Russ Allbery wrote: I believe that if you install them with dh_installchangelogs, they'll be compressed. I think that's the way you're supposed to install the upstream changelog. No matter how the changelog is installed, dh_compress is the *only* thing in debhhelper that will compress it, and it will always compress changelogs no matter their size. Oh, thank you for the correction. Micha, is it possible that you called the debhelper scripts in the wrong order? If, for example, you called dh_installchangelogs after dh_compress, that could cause this problem. Is the package where you encountered this problem publicly available? I'd be happy to take a look at it and try to understand what happened. -- Russ Allbery (r...@debian.org) http://www.eyrie.org/~eagle/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
