Bug#515910: /usr/bin/git-quiltimport: git-quiltimport: cannot specify Author interactively
On Fri, Feb 20, 2009 at 08:54:36AM +, Gerrit Pape wrote: Hi Uwe, does the attached patch fix this for you? Yes it does, thanks Uwe -- Pengutronix e.K. | Uwe Kleine-König| Industrial Linux Solutions| http://www.pengutronix.de/ | -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#515910: /usr/bin/git-quiltimport: git-quiltimport: cannot specify Author interactively
tags 515910 + patch quit On Wed, Feb 18, 2009 at 11:23:15AM +0100, Uwe Kleine-König wrote: when I run git quiltimport without --author and it fails to determine an author, quiltimport tries a `read patch_author`. At least for me this doesn't work, the read command seems to consume input from the series files, not from my tty. And after that it enters an infinite loop, probably because read fails. Hi Uwe, does the attached patch fix this for you? Thanks, Gerrit. From 679c4e82bf8eb9a7bb144884629c8b1e781c7ffc Mon Sep 17 00:00:00 2001 From: Gerrit Pape p...@smarden.org Date: Fri, 20 Feb 2009 08:39:26 + Subject: [PATCH] git-quiltimport: preserve standard input to be able to read user input MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit When run without --author and it fails to determine an author, git quiltimport tries `read patch_author` to get user input, but standard input has been redirected to the patch series file. This commit lets quiltimport read the series file through file descriptor 3 so that the standard input is preserved. Reported by Uwe Kleine-König through http://bugs.debian.org/515910 --- git-quiltimport.sh |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/git-quiltimport.sh b/git-quiltimport.sh index cebaee1..9a6ba2b 100755 --- a/git-quiltimport.sh +++ b/git-quiltimport.sh @@ -63,7 +63,7 @@ tmp_info=$tmp_dir/info commit=$(git rev-parse HEAD) mkdir $tmp_dir || exit 2 -while read patch_name level garbage +while read patch_name level garbage 3 do case $patch_name in ''|'#'*) continue;; esac case $level in @@ -134,5 +134,5 @@ do commit=$( (echo $SUBJECT; echo; cat $tmp_msg) | git commit-tree $tree -p $commit) git update-ref -m quiltimport: $patch_name HEAD $commit || exit 4 fi -done $QUILT_PATCHES/series +done 3$QUILT_PATCHES/series rm -rf $tmp_dir || exit 5 -- 1.6.1.3
Bug#515910: /usr/bin/git-quiltimport: git-quiltimport: cannot specify Author interactively
Package: git-core Version: 1:1.5.6.5-3 Severity: normal File: /usr/bin/git-quiltimport Hello, when I run git quiltimport without --author and it fails to determine an author, quiltimport tries a `read patch_author`. At least for me this doesn't work, the read command seems to consume input from the series files, not from my tty. And after that it enters an infinite loop, probably because read fails. Best regards Uwe -- System Information: Debian Release: 5.0 APT prefers testing APT policy: (700, 'testing'), (70, 'oldstable'), (70, 'stable') Architecture: amd64 (x86_64) Kernel: Linux 2.6.26-1-amd64 (SMP w/8 CPU cores) Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) Shell: /bin/sh linked to /bin/bash Versions of packages git-core depends on: ii libc6 2.7-18GNU C Library: Shared libraries ii libcurl3-gnutls7.18.2-8 Multi-protocol file transfer libra ii libdigest-sha1-perl2.11-2+b1 NIST SHA-1 message digest algorith ii liberror-perl 0.17-1Perl module for error/exception ha ii libexpat1 2.0.1-4 XML parsing C library - runtime li ii perl-modules 5.10.0-19 Core Perl modules ii zlib1g 1:1.2.3.3.dfsg-12 compression library - runtime Versions of packages git-core recommends: ii less 418-1 Pager program similar to more ii openssh-client [ssh-client] 1:5.1p1-5 secure shell client, an rlogin/rsh ii patch 2.5.9-5Apply a diff file to an original ii rsync 3.0.3-2fast remote file copy program (lik Versions of packages git-core suggests: pn git-arch none (no description available) pn git-cvs none (no description available) pn git-daemon-run none (no description available) ii git-doc 1:1.5.6.5-2 fast, scalable, distributed revisi ii git-email1:1.5.6.5-2 fast, scalable, distributed revisi pn git-gui none (no description available) pn git-svn none (no description available) ii gitk 1:1.5.6.5-2 fast, scalable, distributed revisi pn gitweb none (no description available) -- no debconf information -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
