Bug#530133: ltp-tools: bashism in /bin/sh script
On Sunday 31 May 2009 14:07:13 Jiří Paleček wrote: > On Thu, 28 May 2009 23:45:34 +0200, Raphael Geissert > > wrote: > > On Tuesday 26 May 2009 17:15:59 Jiří Paleček wrote: > >> Hello, > >> > >> > While performing an archive wide checkbashisms (from the 'devscripts' > >> > package) > >> > check I've found your package containing a /bin/sh script making use > >> > of a bashism. > >> > >> Thanks for your effort. I'd just like to ask some questions: > >> > >> - is it OK to use a bashism (in this case, a Bash predefined variable), > >> if > >> the behaviour of the script is good even when it is undefined? > > > > I'd say no, because the variable is used because of some reason. > > Even if that "reason" is to detect redhat systems? Patches should be forwarded to upstream, and I assume upstream is also interested in Red Hat. Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#530133: ltp-tools: bashism in /bin/sh script
On Tuesday 26 May 2009 17:15:59 Jiří Paleček wrote: > Hello, > > > While performing an archive wide checkbashisms (from the 'devscripts' > > package) > > check I've found your package containing a /bin/sh script making use > > of a bashism. > > Thanks for your effort. I'd just like to ask some questions: > > - is it OK to use a bashism (in this case, a Bash predefined variable), if > the behaviour of the script is good even when it is undefined? I'd say no, because the variable is used because of some reason. > > - I've done my checks, which showed different bashisms than your posted > output. Where did you find those? I'm interested so that I can improve the scanner. > In particular, pushd/popd. Would usage of "cd -" be a POSIX > replacement for these? It depends on the usage of pushd/popd; if they are used with no parameters it is usually the simplest way to avoid them, yes. Cheers, -- Raphael Geissert - Debian Maintainer www.debian.org - get.debian.net -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#530133: ltp-tools: bashism in /bin/sh script
Hello, While performing an archive wide checkbashisms (from the 'devscripts' package) check I've found your package containing a /bin/sh script making use of a bashism. Thanks for your effort. I'd just like to ask some questions: - is it OK to use a bashism (in this case, a Bash predefined variable), if the behaviour of the script is good even when it is undefined? - I've done my checks, which showed different bashisms than your posted output. In particular, pushd/popd. Would usage of "cd -" be a POSIX replacement for these? Regards Jiri Palecek -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
