Bug#536762: kio_locate.la: incorrect-libdir-in-la-file

2009-07-13 Thread Raphael Geissert
severity 536762 minor
thanks

Hi,

On Monday 13 July 2009 05:23:20 Michael Schutte wrote:
[...]
> lintian reports:
>
> E: kio-locate: incorrect-libdir-in-la-file usr/lib/kde3/kio_locate.la
> /build/buildd/kio-locate-0.4.5+ds/debian/kio-locate/usr/lib/kde3 !=
> /usr/lib/kde3

I know, it was me who added that check to lintian, and as a matter of fact the 
test case is kio-locate's .la file[1].

In this case, the libdir is irrelevant to the .la's file pourpose.

[1]http://git.debian.org/?p=lintian/lintian.git;a=blob;f=t/tests/shared-libs-la-files/debian/kio_locate.la;hb=HEAD

>
> This is easily resolved by using scons’ DESTDIR option in debian/rules
> instead of prepending DEB_DESTDIR to the prefix.  A patch is attached.
>

I know, thanks. My plans were to port kio-locate to autotools and kde4, but 
since I haven't had much time to do it I guess I'll do a simple cleanup.

Cheers,
-- 
Raphael Geissert - Debian Developer
www.debian.org - get.debian.net



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org



Bug#536762: kio_locate.la: incorrect-libdir-in-la-file

2009-07-13 Thread Michael Schutte
Package: kio-locate
Version: 0.4.5+ds-1
Severity: normal
Tags: patch

Hey,

lintian reports:

E: kio-locate: incorrect-libdir-in-la-file usr/lib/kde3/kio_locate.la 
/build/buildd/kio-locate-0.4.5+ds/debian/kio-locate/usr/lib/kde3 != 
/usr/lib/kde3
N: 
N:The given .la file points to a libdir other than the path where it is
N:installed. This can be caused by resetting prefix at make install time
N:instead of using DESTDIR. The incorrect path will cause packages linking
N:to this library using libtool to build incorrectly (adding incorrect
N:paths to RPATH, for example).
N:
N:Severity: important, Certainty: possible
N: 

This is easily resolved by using scons’ DESTDIR option in debian/rules
instead of prepending DEB_DESTDIR to the prefix.  A patch is attached.

Cheers,
-- 
Michael Schutte 
--- kio-locate-0.4.5+ds/debian/rules
+++ kio-locate-0.4.5+ds/debian/rules
@@ -24,7 +24,7 @@
 common-configure-arch common-configure-indep:: common-configure-impl
 common-configure-impl:: $(CONFIG_STATUS)
 $(CONFIG_STATUS):
-	CXXFLAGS="$(CXXFLAGS)" $(SCONS_CMD) configure prefix=$(DEB_DESTDIR)$(DEB_SCONS_PREFIX) $(CONFIGFLAGS); \
+	CXXFLAGS="$(CXXFLAGS)" $(SCONS_CMD) configure prefix=$(DEB_SCONS_PREFIX) $(CONFIGFLAGS); \
 	touch $@
 
 common-build-arch common-build-indep:: common-build-impl
@@ -35,7 +35,7 @@
 
 common-install-arch common-install-indep:: common-install-impl
 common-install-impl::
-	$(SCONS_CMD) install
+	$(SCONS_CMD) install DESTDIR=$(DEB_DESTDIR)
 
 clean::
 	# workaround to "fix" a dependencies loop:


signature.asc
Description: Digital signature