Bug#538066: [pkg-horde] Bug#538066: ingo1 "Source" filter produces bad maildrop filter lines
tags 538066 fixed-upstream thanks Hello, On Fri, Aug 14, 2009 at 12:21:06PM -0500, David Ehle wrote: > > I think upstream has a solution available in this thread: > http://bugs.horde.org/ticket/7611 > However you might want to review the suggestion made by the most recent > poster on that thread and see if it makes sense and should be implemented. > > I've attached the published patch that does not include the numeric > comparison change. Ok, thanks for this information. Then it will be fixed in next upstream release. For Lenny, it's more complex because it's not security bug or RC bug. Regards, -- Gregory Colpart GnuPG:1024D/C1027A0E Evolix - Informatique et Logiciels Libres http://www.evolix.fr/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#538066: [pkg-horde] Bug#538066: ingo1 "Source" filter produces bad maildrop filter lines
Gregory, I think upstream has a solution available in this thread: http://bugs.horde.org/ticket/7611 However you might want to review the suggestion made by the most recent poster on that thread and see if it makes sense and should be implemented. I've attached the published patch that does not include the numeric comparison change. David. On Sat, 8 Aug 2009, Gregory Colpart wrote: Hello, On Wed, Jul 22, 2009 at 03:09:49PM -0500, David Ehle wrote: This may have been addressed upstream, but it appears that the Destination and Source filter on choices in Ingo produce lines similar to this: # sourcetest # if( \ /^From,Sender,Reply-to,Resent-from:\s*.*u...@host\.some\.domain\.edu/:h \ ) exception { to "${DEFAULT}/.ttt/" } The syntax /^From,Sender,Reply-to,Resent-from: while "legal" appears to be trying to match that string literally rather than anything in the list. This means that it basically just doesn't work. I saw some traffic on the INGO1 mailing list about a similar problem for the "Destination" filter choice having the same problem. From the look of it both Destination and Participant are both effected in the Debian/Lenny release: Thanks for your report. I'm not a maildrop guru, then could you provide corrected rules? Regards, -- Gregory Colpart GnuPG:1024D/C1027A0E Evolix - Informatique et Logiciels Libres http://www.evolix.fr/ --- maildrop.php.org2008-10-27 10:07:56.0 +0100 +++ maildrop.php2008-10-30 12:47:37.0 +0100 @@ -570,8 +570,13 @@ $string .= '! '; } -$string .= '/^' . $condition['field'] . ':\\s*'; - +// convert 'field' to PCRE pattern matching +if (strpos($condition['field'], ',') == false) { +$string .= '/^' . $condition['field'] . ':\\s*'; +} else { +$string .= '/^(' . str_replace(',', '|', $condition['field']) . '):\\s*'; +} + switch ($match) { case 'regex': $string .= $condition['value'];
Bug#538066: [pkg-horde] Bug#538066: ingo1 "Source" filter produces bad maildrop filter lines
Gregory, I'll try to find the Ingo discussion and see if I can work out what their solution was. I'm afraid I'm not an maildrop expert either :( David. On Sat, 8 Aug 2009, Gregory Colpart wrote: Hello, On Wed, Jul 22, 2009 at 03:09:49PM -0500, David Ehle wrote: This may have been addressed upstream, but it appears that the Destination and Source filter on choices in Ingo produce lines similar to this: # sourcetest # if( \ /^From,Sender,Reply-to,Resent-from:\s*.*u...@host\.some\.domain\.edu/:h \ ) exception { to "${DEFAULT}/.ttt/" } The syntax /^From,Sender,Reply-to,Resent-from: while "legal" appears to be trying to match that string literally rather than anything in the list. This means that it basically just doesn't work. I saw some traffic on the INGO1 mailing list about a similar problem for the "Destination" filter choice having the same problem. From the look of it both Destination and Participant are both effected in the Debian/Lenny release: Thanks for your report. I'm not a maildrop guru, then could you provide corrected rules? Regards, -- Gregory Colpart GnuPG:1024D/C1027A0E Evolix - Informatique et Logiciels Libres http://www.evolix.fr/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org
Bug#538066: [pkg-horde] Bug#538066: ingo1 "Source" filter produces bad maildrop filter lines
Hello, On Wed, Jul 22, 2009 at 03:09:49PM -0500, David Ehle wrote: > This may have been addressed upstream, but it appears that the Destination > and Source filter on choices in Ingo produce lines similar to this: > # sourcetest # > if( \ >/^From,Sender,Reply-to,Resent-from:\s*.*u...@host\.some\.domain\.edu/:h \ > ) > exception { >to "${DEFAULT}/.ttt/" > } > > The syntax /^From,Sender,Reply-to,Resent-from: while "legal" appears to be > trying to match that string literally rather than anything in the list. > > This means that it basically just doesn't work. > I saw some traffic on the INGO1 mailing list about a similar problem for the > "Destination" filter choice having the same problem. From the look of it > both Destination and Participant are both effected in the Debian/Lenny > release: Thanks for your report. I'm not a maildrop guru, then could you provide corrected rules? Regards, -- Gregory Colpart GnuPG:1024D/C1027A0E Evolix - Informatique et Logiciels Libres http://www.evolix.fr/ -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of "unsubscribe". Trouble? Contact listmas...@lists.debian.org