Bug#544669: cryptsetup: /sbin/blkid is not in initramfs

2009-09-02 Thread Mario 'BitKoenig' Holbe
Package: cryptsetup
Version: 2:1.0.7-2
Severity: grave

Hello,

cryptsetup 1.0.7-2 recommends to replace vol_id and un_vol_id by blkid
and un_blkid. Both of these scripts depend on /sbin/blkid.
However, /sbin/blkid is not available in the initramfs image.

Considering your changelog statement that udev will remove vol_id soon,
I'm not sure whether this bug should really be fixed in cryptsetup
itself or if /sbin/blkid should be included in the initramfs either by
initramfs-tools or util-linux directly.


regards
   Mario
-- 
User sind wie ideale Gase - sie verteilen sich gleichmaessig ueber alle Platten


signature.asc
Description: Digital signature


Bug#544669: [pkg-cryptsetup-devel] Bug#544669: cryptsetup: /sbin/blkid is not in initramfs

2009-09-02 Thread Jonas Meurer
reassign 544669 util-linux
severity 544669 normal
tag 544669 +patch
thanks

hey,

On 02/09/2009 Mario 'BitKoenig' Holbe wrote:
 cryptsetup 1.0.7-2 recommends to replace vol_id and un_vol_id by blkid
 and un_blkid. Both of these scripts depend on /sbin/blkid.
 However, /sbin/blkid is not available in the initramfs image.

thanks for the bugreport. cryptroot doesn't support checkscripts, thus
check and precheck options are ignored for cryptroot devices anyway. i'm
downgrading severity to normal for that reason.

 Considering your changelog statement that udev will remove vol_id soon,
 I'm not sure whether this bug should really be fixed in cryptsetup
 itself or if /sbin/blkid should be included in the initramfs either by
 initramfs-tools or util-linux directly.

yes, you're correct. util-linux should copy blkid to the initramfs
directly. initramfs-tools will need to be migrated to blkid anyway.
currently it's using vol_id. so the propper fix for this is to ship
/usr/share/initramfs-tools/hooks/util-linux within util-linux. the
script should contain something like:

---snip---
#!/bin/sh -e

PREREQ=

prereqs()
{
echo $PREREQ
}

case $1 in
prereqs)
prereqs
exit 0
;;
esac

. /usr/share/initramfs-tools/hook-functions

copy_exec /sbin/blkid
---snap---

this mail downgrades the bug to normal, adds the 'patch' tag, and
reassigns it to the package 'util-linux'.

greetings,
 jonas


signature.asc
Description: Digital signature