Bug#550673: nitrogen: more info

2009-10-13 Thread none
Package: nitrogen
Version: 1.4-2
Severity: normal


I can not reproduce this.

It is an Apply button bugs. If you click directly on wallpaper (I
didn't know about such possibility) everything works fine. Anyway, I've
attached a patch to this message which fix apply for me.
--- src/NWindow.cc  2008-07-31 03:46:26.0 +0400
+++ src/NWindow.cc  2009-10-13 13:50:15.0 +0400
@@ -141,6 +141,10 @@
 
 std::mapGlib::ustring, Glib::ustring::iterator mapiter = 
view.map_setbgs.find(curbgondisp);
 
+   // checking for fullscreen xinerama with several screens end
+   if( mapiter == view.map_setbgs.end() )
+   break;
+
 // if filenames don't match, this row must be blanked out!
 Glib::ustring filename = (*i)[view.record.Filename];
 if (filename != (*mapiter).second)
@@ -152,7 +156,8 @@
 (*i)[view.record.Description] = 
Util::make_current_set_string(this, filename, (*mapiter).first);
 }
 
-if (!this-is_multihead || thedisp == xin_-1)
+// some debug error check?
+if (!this-is_xinerama  thedisp == xin_-1)
 {
 hide();
 Gtk::Main::quit();


Bug#550673: nitrogen: more info

2009-10-13 Thread Nico Golde
Hi,
* none nppp...@gmail.com [2009-10-13 15:42]:
 I can not reproduce this.
 
 It is an Apply button bugs. If you click directly on wallpaper (I
 didn't know about such possibility) everything works fine. Anyway, I've
 attached a patch to this message which fix apply for me.

Ah that's why I couldn't reproduce it. Patch looks good, I'll include it in 
the package. Dave, can you include the patch upstream as well?

Cheers
Nico
-- 
Nico Golde - http://www.ngolde.de - n...@jabber.ccc.de - GPG: 0xA0A0
For security reasons, all text in this mail is double-rot13 encrypted.


pgp7G2AJLzh0w.pgp
Description: PGP signature


Bug#550673: nitrogen: more info

2009-10-13 Thread Dave Foster

Nico Golde wrote:


Ah that's why I couldn't reproduce it. Patch looks good, I'll include it in 
the package. Dave, can you include the patch upstream as well?
  


I'll put it through testing tonight, but it looks good so far.  It'll be 
in 1.6.  Thanks, all.


dave