Bug#553359: Licensing issues

2010-09-08 Thread Andrew Kaminsky
Are you about post from JimC?
This was in part due to Paul J. Lee, who collaborated with Hirakawa
Keigo (the original co-author of AHD algorithm as part of his Ph.D
thesis).

If I understand everything correctly - author of VCD is Paul Lee (the
original co-author of AHD algorithm as part of his Ph.D thesis)

http://www.dpreview.com/members/4422684169
http://forums.dpreview.com/forums/read.asp?forum=1018message=30233091
In this thread you can see also ejmartin (one of the authors of AMaZE),
Iliah Borg (co author of libraw and RPP) and other clever boys, skilled
in raw development.


And when you dig into the code of ahd_interpolate_mod.c you can see:

if (verbose) fprintf (stderr,_(AHD interpolation (modified for
anti-aliasing)...\n));

So question: Which refinements are better refinements? :-)

Strictly speaking in VCD implementation we have 3 different demosaicing:
1) modified ahd
2) mixed modified_AHD and VCD. This is what named VCD in darktable
3) VCD
Demosaicing named AHD in darktable is from dcraw (libraw).

PS: I'l submit patches in 1-2 days.

On Tue, 2010-09-07 at 23:27 +0200, Jose Carlos Garcia Sogo wrote:
 BTW, shouldn't be using the versions for AHD that are in dcraw.c??? I
 suppose those have some refinements, and that is what this post seems
 to say:
 http://forums.steves-digicams.com/nikon-dslr/164000-better-shooting-raw-converting-jpg.html
 

Regards,
Andrey Kaminsky





-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#553359: Licensing issues

2010-09-07 Thread Jose Carlos Garcia Sogo
On Tue, Sep 7, 2010 at 9:24 PM, Andrew Kaminsky
kaminsky.and...@gmail.com wrote:
 Hi.

 ahd_interpolate_mod.c
 ahd_partial_interpolate.c
 es_median_filter.c
 median_filter_new.c
 refinement.c
 vcd_interpolate.c

 Those are originally imported from VCD demosaicing:

 http://sites.google.com/site/demosaicalgorithms/modified-dcraw

 So I think I can`t to attach copyright and license notes.
 I`m not lawyer, but i think they are under the same licenses as dcraw.

As they have based their implementation in dcraw and they are
distributing the sources together, they have to abide to the use GPL
v2 or later option in dcraw. But, copyright notice is still needed.
Anyway authors should be contacted for clarification.
Of course, as it is not your work, you cannot attach copyright and/or
license notes.


 Next:

 libraw_internal_funcs_vcd.h - derived work from VCD demosaicing sources.
 Is this correct if I add copyright and license? If yes - GPL or LGPL. Which 
 one?

Then license is the same than  previous one, but you could add you (c)
to it. License should be GPL, given that they are releasing a modified
dcraw, which is under GPL.


 libraw_internal_funcs_amaze.h - derived work from GPL`ed code,
 so I think it is GPL or LGPL.

Has to be GPL then. LGPL is more restrictive than GPL, so nothing
derived from a GPL work can be licensed under LGPL. This is because
LGPL allows linking to closed source programs to libraries licensed
under LGPL, and GPL doesn't.

 libraw_internal_funcs_dcb.h - derived work from code covered by BSD license,
 so I think GPL or LGPL is correct (or may be BSD?).
 (original sources from: http://www.linuxphoto.org/html/algorithms.html )

Can be BSD, GPL or LGPL at your wish, but you have to keep original
(c) and conditions for the original work, as BSD license states. I
would recommend you GPL or BSD, not LGPL.

 Is this enough, or I MUST submit patch.

You should submit a patch for your modified work. For the work you
took from VCD demosaicing, I'll try to contact them before making any
assumption. I'll copy you and the list.


 And I don`t understand which license is better in this situation.
 GPL or LGPL. May be LGPL, to be compatible with libraw?

You only need to license under LGPL whatever you want to contribute
back to libraw, as they are using a LGPL license. Whatever you write
as GPL can be linked against any LGPL library, but they won't accept
any patch with a GPL license stick to it.

Regards

-- 
José Carlos García Sogo
   js...@debian.org



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#553359: Licensing issues

2010-09-07 Thread Jose Carlos Garcia Sogo
BTW, shouldn't be using the versions for AHD that are in dcraw.c??? I
suppose those have some refinements, and that is what this post seems
to say:
http://forums.steves-digicams.com/nikon-dslr/164000-better-shooting-raw-converting-jpg.html

-- 
José Carlos García Sogo
   js...@debian.org



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org