Bug#554904: HellaNZB crashes on startup when missing unrar package

2009-11-07 Thread Severin Heiniger
Package: hellanzb
Version: 0.13-5.2
Severity: important
Tags: patch

The hellanzb package has been patched so that it doesn't use unrar by
default in order to prevent the package from being moved from main to
contrib. In more detail, the SKIP_UNRAR configuration option defaults to
True in Debian and unrar has been added to hellanzb's Suggests. So far
so good.

However, hellanzb crashes on startup if unrar isn't installed, no matter
what the SKIP_UNRAR configuration option is set to:

A problem occurred while reading the config file: FatalError':
Cannot continue program, required executable not found: 'unrar'
Exiting: FatalError': Cannot continue program, required
executable not found: 'unrar'

The attached debdiff fixes this bug. It changes hellanzb's Core.py so
that it only looks for the unrar executable if SKIP_UNRAR is not set to
True. The diff also contains other minor changes, which of course can be
dropped if they're not welcome:

  * Bump Standards-Version to 3.8.3 (no changes needed).
  * Add README.sources to fix patch-system-but-no-source-readme lintian
 warning.
  * Minor cleanup in README.Debian and NEWS.Debian.

If the patch is applied, I'll take care of sending it upstream. However,
the project is more or less dead.

Fixing this bug will also make it possible to finally resolve #523851,
because up to now, LottaNZB depended unrar only to prevent HellaNZB from
crashing.

Regards,
Severin Heiniger
diff -u hellanzb-0.13/debian/control hellanzb-0.13/debian/control
--- hellanzb-0.13/debian/control
+++ hellanzb-0.13/debian/control
@@ -4,7 +4,7 @@
 Maintainer: Adam Cécile (Le_Vert) gand...@le-vert.net
 Build-Depends: debhelper (= 5.0.37.2), dpatch
 Build-Depends-Indep: python-all-dev (= 2.5.4), python-all, python-support (= 0.5.3)
-Standards-Version: 3.8.1
+Standards-Version: 3.8.3
 Homepage: http://www.hellanzb.com/
 
 Package: hellanzb
diff -u hellanzb-0.13/debian/changelog hellanzb-0.13/debian/changelog
--- hellanzb-0.13/debian/changelog
+++ hellanzb-0.13/debian/changelog
@@ -1,3 +1,13 @@
+hellanzb (0.13-5.3) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Bump Standards-Version to 3.8.3 (no changes needed).
+  * Add new patch to fix crash when unrar isn't installed.
+  * Add README.sources to fix patch-system-but-no-source-readme lintian warning.
+  * Minor cleanup in README.Debian and NEWS.Debian.
+
+ -- Severin Heiniger severinheini...@gmail.com  Wed, 04 Nov 2009 19:32:33 +0100
+
 hellanzb (0.13-5.2) unstable; urgency=low
 
   * Non-maintainer upload.
diff -u hellanzb-0.13/debian/NEWS.Debian hellanzb-0.13/debian/NEWS.Debian
--- hellanzb-0.13/debian/NEWS.Debian
+++ hellanzb-0.13/debian/NEWS.Debian
@@ -1,16 +1,16 @@
 hellanzb (0.11-1) experimental; urgency=low
 
-  On previous version, hellanzb XMLRPC server was listening to world.
-  It's really unsafe and expose user to several security issues if he doesn't
-  change the default password.
+  In previous versions, the HellaNZB XMLRPC server accepted connections from
+  anywhere. Not changing the default password exposed the user to several
+  security issues.
 
-  Therefore, I added a new configuration directive named 
-  Hellanzb.XMLRPC_SERVER_BIND. If it's not set, remote access to the XMLRPC
-  server is disabled (binded to 127.0.0.1).
+  Therefore, a new configuration directive named Hellanzb.XMLRPC_SERVER_BIND
+  has been added. If it's not set, remote access to the XMLRPC server is
+  disabled (bound to 127.0.0.1).
 
-  To reproduce the same behavior as previous version, just add:
-  Hellanzb.XMLRPC_SERVER_BIND. = '0.0.0.0' to hellanzb.conf.
+  To reproduce the same behavior as previous versions, just add
+  Hellanzb.XMLRPC_SERVER_BIND = '0.0.0.0' to hellanzb.conf.
 
-  /!\ Please add Hellanzb.XMLRPC_SERVER_BIND. to your configuration file.
+  Please add Hellanzb.XMLRPC_SERVER_BIND to your configuration file.
 
  -- Adam Cécile (Le_Vert) gand...@le-vert.net  Sat, 10 Feb 2007 15:01:20 +0100
diff -u hellanzb-0.13/debian/README.Debian hellanzb-0.13/debian/README.Debian
--- hellanzb-0.13/debian/README.Debian
+++ hellanzb-0.13/debian/README.Debian
@@ -1,12 +1,11 @@
-hellanzb for Debian
---
+HellaNZB for Debian
+---
 
-The default configuration files skip unraring during post processing 
-(Hellanzb.SKIP_UNRAR = True).
+The default configuration file skips unraring during post-processing 
+(Hellanzb.SKIP_UNRAR is set to True). This is necessary to prevent the package
+from being moved from main to contrib.
 
-I removed unrar call to avoid the package to be moved from main to contrib.
-
-You can enable this feature again but you need to install unrar package from
-non-free.
+You can enable this feature again but you'll need to install the non-free
+unrar package.
 
  -- Adam Cécile (Le_Vert) gand...@le-vert.net, Fri,  8 Sep 2006 21:12:36 +0200
diff -u hellanzb-0.13/debian/patches/00list hellanzb-0.13/debian/patches/00list
--- hellanzb-0.13/debian/patches/00list
+++ 

Bug#554904: HellaNZB crashes on startup when missing unrar package

2009-11-07 Thread Adam Cécile (Le_Vert)

Severin Heiniger a écrit :

Package: hellanzb
Version: 0.13-5.2
Severity: important
Tags: patch

The hellanzb package has been patched so that it doesn't use unrar by
default in order to prevent the package from being moved from main to
contrib. In more detail, the SKIP_UNRAR configuration option defaults to
True in Debian and unrar has been added to hellanzb's Suggests. So far
so good.

However, hellanzb crashes on startup if unrar isn't installed, no matter
what the SKIP_UNRAR configuration option is set to:

A problem occurred while reading the config file: FatalError':
Cannot continue program, required executable not found: 'unrar'
Exiting: FatalError': Cannot continue program, required
executable not found: 'unrar'

The attached debdiff fixes this bug. It changes hellanzb's Core.py so
that it only looks for the unrar executable if SKIP_UNRAR is not set to
True. The diff also contains other minor changes, which of course can be
dropped if they're not welcome:

  * Bump Standards-Version to 3.8.3 (no changes needed).
  * Add README.sources to fix patch-system-but-no-source-readme lintian
 warning.
  * Minor cleanup in README.Debian and NEWS.Debian.

If the patch is applied, I'll take care of sending it upstream. However,
the project is more or less dead.

Fixing this bug will also make it possible to finally resolve #523851,
because up to now, LottaNZB depended unrar only to prevent HellaNZB from
crashing.

Regards,
Severin Heiniger
  

Hi,

Go ahead with a NMU, I'm far too busy.

Thanks in advance,

Adam.



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org