Bug#564169: [Pkg-acpi-devel] Bug#564169: acpi-support should depend on rfkill
Put yourself into the position of a user: They install acpi-support because someone told them it will make the Thinkpad's special buttons work. They press Fn-F5, but nothing happens. They look into the system logs: nothing. They conclude that acpi-support does not support Fn-F5. Your fix will not really help that user. True. But don't forget that your package manager will tell you about rfkill, so you could have installed it. The simplest thing would be to just depend on rfkill. I understand that not all laptops will need it, but then again, it's small ;-). The problem with Doesn't really matter, it is not a dependendecy. :-) If depending on rfkill is not possible, I'd suggest: * Explain in the package description where rfkill is needed: Install rfkill to enable toggling WLAN on Thinkpad laptops. No, this will bloat the description. I don't think this is acceptable either. I think the best place to put this is /usr/share/doc/acpi-support/README.thinkpad. * Put some hint into ibm-wireless.sh about rfkill, e.g.: Replace test -x /usr/sbtest -x /usr/sbin/rfkill || exit 0 with if (! test -x /usr/sbin/rfkill) then logger Error: Please install package rfkill to enable toggling of wireless devices. ;exit 0 fi This sounds good. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: mes...@jabber.org VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#564169: [Pkg-acpi-devel] Bug#564169: acpi-support should depend on rfkill
Hi, On Tue, 12 Jan 2010 16:15:31 +0100, Michael Meskes mes...@debian.org wrote: They press Fn-F5, but nothing happens. They look into the system logs: nothing. They conclude that acpi-support does not support Fn-F5. Your fix will not really help that user. True. But don't forget that your package manager will tell you about rfkill, so you could have installed it. yes, that is true. That was my point: the package manager will tell me that rfkill is a Suggest or Recommend, but it will not say what it's needed for. That's why I wrote that it would be useful to have some kind of comment with a Suggest/Recommend to tell users *why* it's recommended. Maybe that'll come one day... * Explain in the package description where rfkill is needed: Install rfkill to enable toggling WLAN on Thinkpad laptops. No, this will bloat the description. I don't think this is acceptable either. I think the best place to put this is /usr/share/doc/acpi-support/README.thinkpad. Yes, that sounds reasonable. Maybe the package description could note that /usr/share/doc/acpi-support/README.thinkpad. (or /usr/share/doc/acpi-support/README* ) contains useful information for users :-). * Put some hint into ibm-wireless.sh about rfkill, e.g.: Replace test -x /usr/sbtest -x /usr/sbin/rfkill || exit 0 with if (! test -x /usr/sbin/rfkill) then logger Error: Please install package rfkill to enable toggling of wireless devices. ;exit 0 fi This sounds good. That's good :-). Greetings, S.Leske -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#564169: [Pkg-acpi-devel] Bug#564169: acpi-support should depend on rfkill
Hi, thanks for the prompt reply. On Fri, Jan 08, 2010 at 06:35:57AM +0100, Sebastian Leske wrote: acpi-support should depend on rfkill, as it is used in /etc/acpi/ibm-wireless.sh A Suggest has to be sufficient because it is not needed for other laptops. But ibm-wireless.sh should also test for its existance. Thanks, but I fear that will not really help. Put yourself into the position of a user: They install acpi-support because someone told them it will make the Thinkpad's special buttons work. They press Fn-F5, but nothing happens. They look into the system logs: nothing. They conclude that acpi-support does not support Fn-F5. Your fix will not really help that user. The simplest thing would be to just depend on rfkill. I understand that not all laptops will need it, but then again, it's small ;-). The problem with recommends/suggests is that it's difficult for a user to tell which packages they need; users may not know which packages they really need. If depending on rfkill is not possible, I'd suggest: * Explain in the package description where rfkill is needed: Install rfkill to enable toggling WLAN on Thinkpad laptops. and * Put some hint into ibm-wireless.sh about rfkill, e.g.: Replace test -x /usr/sbtest -x /usr/sbin/rfkill || exit 0 with if (! test -x /usr/sbin/rfkill) then logger Error: Please install package rfkill to enable toggling of wireless devices. ;exit 0 fi (or similar). The idea is to give the user a hint why the functionality isn't working. Of course, this is really a problem with recommends/suggests; I believe it could help if they had an extra field to explain why the packages is recommended / suggested. Maybe that'll come some day... -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#564169: [Pkg-acpi-devel] Bug#564169: acpi-support should depend on rfkill
tag 564169 pending thanks On Fri, Jan 08, 2010 at 06:35:57AM +0100, Sebastian Leske wrote: acpi-support should depend on rfkill, as it is used in /etc/acpi/ibm-wireless.sh A Suggest has to be sufficient because it is not needed for other laptops. But ibm-wireless.sh should also test for its existance. Michael -- Michael Meskes Michael at Fam-Meskes dot De, Michael at Meskes dot (De|Com|Net|Org) Michael at BorussiaFan dot De, Meskes at (Debian|Postgresql) dot Org ICQ: 179140304, AIM/Yahoo/Skype: michaelmeskes, Jabber: mes...@jabber.org VfL Borussia! Forca Barca! Go SF 49ers! Use: Debian GNU/Linux, PostgreSQL -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
