Bug#567484: pbuilder: -e$DEBEMAIL instead of -e$DEBFULLNAME $DEBEMAIL used for dpkg-buildpackage
On Sat, Jan 30, 2010, Jean-Christophe Dubacq wrote: However, other debian utilities expect DEBEMAIL to be only the email and DEBFULLNAME to be only the name (depatch for example). I would be very happy if this were made into some program. Yes, dpatch suffers from a similar problem, but with a different interpretation of which values and how values should be set. Both cases are wrong, but heavy to implement as nicely as dch in shell. -- Loïc Minier -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#567484: pbuilder: -e$DEBEMAIL instead of -e$DEBFULLNAME $DEBEMAIL used for dpkg-buildpackage
Package: pbuilder
Version: 0.196
Severity: normal
Tags: patch
In /usr/lib/pbuilder/pbuilder-buildpackage, the call to dpkg-buildpackage reads:
COMMANDLINE=dpkg-buildpackage -us -uc ${DEBEMAIL:+\-e$DEBEMAIL\}
$DEBBUILDOPTS
which generates .changes with a Changed-By: line with only the email address
instead
of the full stanza.
lintian reports this as :
E: pbuilder-utils_2.5_i386.changes: changed-by-name-missing jcduba...@free.fr
N:
N:The Changed-By field seems to contain just an email address. It must
N:contain the package maintainer's name and email address.
N:
N:Refer to Debian Policy Manual section 5.6.4 (Changed-By) for details.
N:
N:Severity: serious, Certainty: certain
N:
I suggest using instead:
COMMANDLINE=dpkg-buildpackage -us -uc
${DEBEMAIL:+${DEBFULLNAME:+\-e$DEBFULLNAME $DEBEMAIL\}} $DEBBUILDOPTS
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (990, 'testing'), (500, 'stable'), (100, 'unstable'), (50,
'experimental')
Architecture: i386 (x86_64)
Kernel: Linux 2.6.32-trunk-amd64 (SMP w/2 CPU cores)
Locale: LANG=fr_FR.UTF-8, LC_CTYPE=fr_FR.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages pbuilder depends on:
ii coreutils 7.4-2 The GNU core utilities
ii debconf [debconf-2.0] 1.5.28 Debian configuration management sy
ii debianutils 3.2.2 Miscellaneous utilities specific t
ii debootstrap 1.0.20 Bootstrap a basic Debian system
ii wget 1.12-1.1 retrieves files from the web
Versions of packages pbuilder recommends:
ii devscripts2.10.61scripts to make the life of a Debi
ii fakeroot 1.14.4-1 Gives a fake root environment
ii sudo 1.7.2p1-1 Provide limited super user privile
Versions of packages pbuilder suggests:
pn cowdancer none (no description available)
ii gdebi-core 0.5.9debian2 Simple tool to install deb files
pn pbuilder-umlnone (no description available)
-- debconf information:
pbuilder/nomirror:
* pbuilder/mirrorsite: http://ftp.fr.debian.org/debian/
* pbuilder/rewrite: false
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#567484: pbuilder: -e$DEBEMAIL instead of -e$DEBFULLNAME $DEBEMAIL used for dpkg-buildpackage
tags 567484 - patch
stop
On Fri, Jan 29, 2010, Jean-Christophe Dubacq wrote:
In /usr/lib/pbuilder/pbuilder-buildpackage, the call to dpkg-buildpackage
reads:
COMMANDLINE=dpkg-buildpackage -us -uc ${DEBEMAIL:+\-e$DEBEMAIL\}
$DEBBUILDOPTS
which generates .changes with a Changed-By: line with only the email address
instead
of the full stanza.
This is because you didn't set DEBEMAIL with your name; you can set:
DEBEMAIL=Loïc Minier l...@dooz.org
We should deal with this better, but this is going to be subtle;
checkout the code of dch for reference handling of these vars:
if (exists $env{'DEBEMAIL'} and $env{'DEBEMAIL'} =~ /^(.*)\s+(.*)$/) {
$env{'DEBFULLNAME'} = $1 unless exists $env{'DEBFULLNAME'};
$env{'DEBEMAIL'} = $2;
}
if (! exists $env{'DEBEMAIL'} or ! exists $env{'DEBFULLNAME'}) {
if (exists $env{'EMAIL'} and $env{'EMAIL'} =~ /^(.*)\s+(.*)$/) {
$env{'DEBFULLNAME'} = $1 unless exists $env{'DEBFULLNAME'};
$env{'EMAIL'} = $2;
}
}
the logic continues for some dozens of lines.
In an ideal world, consider making this code a separate utility, e.g.
get-debian-maintainer which would output:
EMAIL=foo...@baz
NAME=Foo Bar
Thanks!
--
Loïc Minier
--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#567484: pbuilder: -e$DEBEMAIL instead of -e$DEBFULLNAME $DEBEMAIL used for dpkg-buildpackage
Loïc Minier a écrit :
tags 567484 - patch
stop
On Fri, Jan 29, 2010, Jean-Christophe Dubacq wrote:
In /usr/lib/pbuilder/pbuilder-buildpackage, the call to dpkg-buildpackage
reads:
COMMANDLINE=dpkg-buildpackage -us -uc ${DEBEMAIL:+\-e$DEBEMAIL\}
$DEBBUILDOPTS
which generates .changes with a Changed-By: line with only the email address
instead
of the full stanza.
This is because you didn't set DEBEMAIL with your name; you can set:
DEBEMAIL=Loïc Minier l...@dooz.org
We should deal with this better, but this is going to be subtle;
checkout the code of dch for reference handling of these vars:
if (exists $env{'DEBEMAIL'} and $env{'DEBEMAIL'} =~ /^(.*)\s+(.*)$/) {
$env{'DEBFULLNAME'} = $1 unless exists $env{'DEBFULLNAME'};
$env{'DEBEMAIL'} = $2;
}
if (! exists $env{'DEBEMAIL'} or ! exists $env{'DEBFULLNAME'}) {
if (exists $env{'EMAIL'} and $env{'EMAIL'} =~ /^(.*)\s+(.*)$/) {
$env{'DEBFULLNAME'} = $1 unless exists $env{'DEBFULLNAME'};
$env{'EMAIL'} = $2;
}
}
the logic continues for some dozens of lines.
In an ideal world, consider making this code a separate utility, e.g.
get-debian-maintainer which would output:
EMAIL=foo...@baz
NAME=Foo Bar
Thanks!
However, other debian utilities expect DEBEMAIL to be only the email and
DEBFULLNAME to be only the name (depatch for example).
I would be very happy if this were made into some program.
--
Jean-Christophe Dubacq
signature.asc
Description: OpenPGP digital signature
