Bug#568897: [debhelper-devel] Bug#568897: debhelper: DEB_BUILD_OPTIONS=nocheck should prevent override_dh_auto_test rule to be run
On Monday, December 12, 2016 10:57:20 AM CST Peter Pentchev wrote: > On Sun, Dec 11, 2016 at 08:22:09PM -0600, Steve M. Robbins wrote: > > Alternatively: if the logic was all in dh (to skip both dh_auto_test > > and override_dh_auto_test), then it would not need to be in > > dh_auto_test at all. > > It may still need to be in dh_auto_test for packages that still do not > use the override targets at all, but invoke the dh_* commands explicitly > from the "build", "binary", etc targets. None of mine do, but I bet that > there are still some in the archive :) You're suggesting someone would use dh_auto_test from within a binary target? Interesting use case. My feeling is that DEB_BUILD_OPTIONS represent global build options, so I think I'd design it into dh rather than individual tools. You're right that it would be a breaking change, but I think one could use a debhelper compatibility level to remove the functionality from the tools. -Steve signature.asc Description: This is a digitally signed message part.
Bug#568897: [debhelper-devel] Bug#568897: debhelper: DEB_BUILD_OPTIONS=nocheck should prevent override_dh_auto_test rule to be run
On Sun, Dec 11, 2016 at 08:22:09PM -0600, Steve M. Robbins wrote: > I, too, think this would be a valuable addition. > > > On Tue, Feb 09, 2010 at 02:38:34PM -0500, Joey Hess wrote: > > > If I did this, I would need to also make override_dh_strip to be > > skipped when DEB_BUILD_OPTIONS=nostrip. > > Yes, would also be nice. > > > > One reason to dislike this is it would mean redundant tests in > > dh that'd have to be maintained in parallel with the tests in the > > commands. > > Agree that it would take work to implement, though I would think that > the tests could be centralized and used by both dh and dh_auto_test. > Alternatively: if the logic was all in dh (to skip both dh_auto_test > and override_dh_auto_test), then it would not need to be in > dh_auto_test at all. It may still need to be in dh_auto_test for packages that still do not use the override targets at all, but invoke the dh_* commands explicitly from the "build", "binary", etc targets. None of mine do, but I bet that there are still some in the archive :) G'luck, Peter -- Peter Pentchev r...@ringlet.net r...@freebsd.org p...@storpool.com PGP key:http://people.FreeBSD.org/~roam/roam.key.asc Key fingerprint 2EE7 A7A5 17FC 124C F115 C354 651E EFB0 2527 DF13 signature.asc Description: PGP signature
