Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
Hi! * Alexander Sack a...@debian.org [100412 13:29]: [..] Not a big deal ... especially since builders dont pick up alternative build depends anyway --- so syncs wont be possible anyway. What is the status of this bug? Yesterday enigmail was removed from testing and icedove propagated to testing, so it's no longer an affects only unstable users problem anymore :( Best Regards, Alexander -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
On Sun, Apr 11, 2010 at 10:26:00PM +0200, Michael Musenbrock wrote: Am 2010-04-11 20:26, schrieb Leo 'costela' Antunes: On 11/04/10 20:13, Michael Musenbrock wrote: So the attached patch should do the trick again. I assumed the package Alexander had prepared already included your first patch, so I didn't even check. So that the patch will break the whole thing on ubuntu, he can't use the patch for the ubuntu system, I think that was the reason. @Alexander Prepared a new patch, this one can be used both for the ubuntu and the debian package. So you can use the 'same' build rules on both systems (Have no Ubuntu system to test). well. we dont want --with-system-nspr/nss etc. to be on command line in ubuntu as we want to use whatever the target thunderbird uses ... e.g. we want to spin it against dailies 3.1 etc. which is why i asked Chris to fix it like we did in ubuntu --- however, glandium vetoed, so we have to diverge in debian for now ... Not a big deal ... especially since builders dont pick up alternative build depends anyway --- so syncs wont be possible anyway. - Alexander -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
Alexander Sack wrote: I see, I didn't check the ubuntu pkg. So added a patch to corresponding bug in icedove-dev already [1] [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577021 ... let me know when icedove has either of the patches so i can upload the package. Michael beat me cleanly and made all the work before I even got a chance to sit down to it, but just so it doesn't seem like I didn't do anything at all, I'm letting you know the icedove-dev bug has been closed by an upload today! :) Cheers -- Leo costela Antunes [insert a witty retort here] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
On Sun, Apr 11, 2010 at 04:41:41PM +0200, Leo 'costela' Antunes wrote: Alexander Sack wrote: I see, I didn't check the ubuntu pkg. So added a patch to corresponding bug in icedove-dev already [1] [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577021 ... let me know when icedove has either of the patches so i can upload the package. Michael beat me cleanly and made all the work before I even got a chance to sit down to it, but just so it doesn't seem like I didn't do anything at all, I'm letting you know the icedove-dev bug has been closed by an upload today! :) Can you verify that the package below just builds now? https://edge.launchpad.net/~asac/+archive/ppa/+files/enigmail_1.0.1-0ubuntu1~asac2.dsc - Alexander -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
On 11/04/10 16:52, Alexander Sack wrote: Can you verify that the package below just builds now? https://edge.launchpad.net/~asac/+archive/ppa/+files/enigmail_1.0.1-0ubuntu1~asac2.dsc I'm getting: /tmp/buildd/enigmail-1.0.1/allmakefiles.sh: line 113: /tmp/buildd/enigmail-1.0.1/toolkit/toolkit-makefiles.sh: No such file or directory Sorry for the naive question, but why is the orig tarball so different from upstream's? There's no sign of either file in upstream's source tarball but the copyright statement mentions them being from Mozilla, so it doesn't seem to be something you wrote yourself specially for the debian package... I guess I'm missing something very obvious? Cheers -- Leo costela Antunes [insert a witty retort here] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
Am 2010-04-11 20:01, schrieb Leo 'costela' Antunes: On 11/04/10 16:52, Alexander Sack wrote: Can you verify that the package below just builds now? https://edge.launchpad.net/~asac/+archive/ppa/+files/enigmail_1.0.1-0ubuntu1~asac2.dsc I'm getting: /tmp/buildd/enigmail-1.0.1/allmakefiles.sh: line 113: /tmp/buildd/enigmail-1.0.1/toolkit/toolkit-makefiles.sh: No such file or directory Same error I got by my first attempts to build the packages. This was fixed with my first patch, but it seems that this change was not considered. So the attached patch should do the trick again. Regards --- enigmail-1.0.1.orig/debian/rules 2010-04-10 01:39:14.0 +0200 +++ enigmail-1.0.1/debian/rules 2010-04-11 20:06:04.0 +0200 @@ -3,7 +3,7 @@ #BUILDDIR = $(CURDIR)/objdir-enigmail BUILDDIR = $(CURDIR) -TBIRD_SDK = $(shell ls -d /usr/lib/thunderbird-devel-3* | head -n1) +TBIRD_SDK = $(shell ls -d /usr/lib/icedove-devel* | head -n1) %: # dh --with quilt --with xul-ext --builddirectory=$(BUILDDIR) $@ @@ -11,7 +11,7 @@ override_dh_auto_configure: mkdir -p $(BUILDDIR) - cd $(BUILDDIR); $(CURDIR)/configure --with-libxul-sdk=$(TBIRD_SDK) --enable-application=extensions --enable-extensions=enigmail --disable-debug --disable-tests --disable-crashreporter --disable-ogg + cd $(BUILDDIR); $(CURDIR)/configure --with-libxul-sdk=$(TBIRD_SDK) --enable-application=extensions --enable-extensions=enigmail --disable-debug --disable-tests --disable-crashreporter --disable-ogg --with-system-nspr --with-system-nss override_dh_auto_build: # dh_auto_build --builddirectory=$(BUILDDIR)
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
On 11/04/10 20:13, Michael Musenbrock wrote: Same error I got by my first attempts to build the packages. This was fixed with my first patch, but it seems that this change was not considered. So the attached patch should do the trick again. Oh, that was silly. I assumed the package Alexander had prepared already included your first patch, so I didn't even check. Great, now it compiles cleanly and runs - so far - smoothly! Cheers -- Leo costela Antunes [insert a witty retort here] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
Am 2010-04-11 20:26, schrieb Leo 'costela' Antunes: On 11/04/10 20:13, Michael Musenbrock wrote: So the attached patch should do the trick again. I assumed the package Alexander had prepared already included your first patch, so I didn't even check. So that the patch will break the whole thing on ubuntu, he can't use the patch for the ubuntu system, I think that was the reason. @Alexander Prepared a new patch, this one can be used both for the ubuntu and the debian package. So you can use the 'same' build rules on both systems (Have no Ubuntu system to test). Regards --- enigmail-1.0.1.orig/debian/rules 2010-04-10 01:39:14.0 +0200 +++ enigmail-1.0.1/debian/rules 2010-04-11 22:08:56.0 +0200 @@ -3,7 +3,14 @@ #BUILDDIR = $(CURDIR)/objdir-enigmail BUILDDIR = $(CURDIR) -TBIRD_SDK = $(shell ls -d /usr/lib/thunderbird-devel-3* | head -n1) +TBIRD_SDK = $(shell ls -d /usr/lib/thunderbird-devel-3* /usr/lib/icedove-devel* 2 /dev/null | head -n1) + +ifneq (,$(findstring icedove,$(TBIRD_SDK))) +DEBIANSPECIFICFLAGS = --with-system-nspr --with-system-nss +else +DEBIANSPECIFICFLAGS = +endif + %: # dh --with quilt --with xul-ext --builddirectory=$(BUILDDIR) $@ @@ -11,7 +18,7 @@ override_dh_auto_configure: mkdir -p $(BUILDDIR) - cd $(BUILDDIR); $(CURDIR)/configure --with-libxul-sdk=$(TBIRD_SDK) --enable-application=extensions --enable-extensions=enigmail --disable-debug --disable-tests --disable-crashreporter --disable-ogg + cd $(BUILDDIR); $(CURDIR)/configure --with-libxul-sdk=$(TBIRD_SDK) --enable-application=extensions --enable-extensions=enigmail --disable-debug --disable-tests --disable-crashreporter --disable-ogg $(DEBIANSPECIFICFLAGS) override_dh_auto_build: # dh_auto_build --builddirectory=$(BUILDDIR)
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
On Thu, Apr 08, 2010 at 09:37:16PM +0200, Michael Musenbrock wrote: Am 2010-04-08 20:59, schrieb Alexander Sack: The package is done and floating in a ppa ... it needs some build-depends love and for debian we need to add --with-system-nspr and --with-system-nss to configure flags. build-depends love turned out as following: libglib2.0-dev, libgtk2.0-dev, libdbus-glib-1-dev, libnotify-dev, libasound2-dev, libidl-dev, libiw-dev where missing (on my machine) Needed to add mimecryp.h, mimemoz2.h and nsStreamConverter.h by hand, I think they should find a way into the icedove-dev package. yes, that needs to go in there ... we have a patch for that in thunderbird 3 in ubuntu - Alexander -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
On Fri, 9 Apr 2010 13:42:14 +0200, Alexander Sack wrote On Thu, Apr 08, 2010 at 09:37:16PM +0200, Michael Musenbrock wrote: Needed to add mimecryp.h, mimemoz2.h and nsStreamConverter.h by hand, I think they should find a way into the icedove-dev package. yes, that needs to go in there ... we have a patch for that in thunderbird 3 in ubuntu I see, I didn't check the ubuntu pkg. So added a patch to corresponding bug in icedove-dev already [1] [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577021 -- -- Please ignore the ad in the mail GRATIS für alle GMX-Mitglieder: Die maxdome Movie-FLAT! Jetzt freischalten unter http://portal.gmx.net/de/go/maxdome01 -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
On Fri, Apr 09, 2010 at 02:10:32PM +0200, Michael Musenbrock wrote: On Fri, 9 Apr 2010 13:42:14 +0200, Alexander Sack wrote On Thu, Apr 08, 2010 at 09:37:16PM +0200, Michael Musenbrock wrote: Needed to add mimecryp.h, mimemoz2.h and nsStreamConverter.h by hand, I think they should find a way into the icedove-dev package. yes, that needs to go in there ... we have a patch for that in thunderbird 3 in ubuntu I see, I didn't check the ubuntu pkg. So added a patch to corresponding bug in icedove-dev already [1] [1] http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=577021 ... let me know when icedove has either of the patches so i can upload the package. - Alexander -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#569804: Re: Bug#569804: enigmail: New Version 1.0.*
Am 2010-04-08 20:59, schrieb Alexander Sack: The package is done and floating in a ppa ... it needs some build-depends love and for debian we need to add --with-system-nspr and --with-system-nss to configure flags. build-depends love turned out as following: libglib2.0-dev, libgtk2.0-dev, libdbus-glib-1-dev, libnotify-dev, libasound2-dev, libidl-dev, libiw-dev where missing (on my machine) Needed to add mimecryp.h, mimemoz2.h and nsStreamConverter.h by hand, I think they should find a way into the icedove-dev package. AFAIUI it should work with latest icedove in unstable. Wanna try and help getting the final its from above in place? Can't provide a patch, because enigmail source folder is too messy at the moment. I will do a clean build tomorrow. At first sight, everything seems to work. Regards Michael -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
