Bug#571016: can't reproduce / lacks detail

2010-02-25 Thread Piotr Ożarowski
tags 571016 + patch
thanks

I can reproduce it as well by just installing python-moinmoin and
following /usr/share/doc/python-moinmoin/README.Debian.gz instructions
(with python-flup installed, using CGI)

Here's what fixed the problem for me (see IRC logs from my previous mail
for more details):

| diff -r 1ecb884c0deb MoinMoin/web/contexts.py
| --- a/MoinMoin/web/contexts.pyTue Jan 19 00:35:00 2010 +0100
| +++ b/MoinMoin/web/contexts.pyThu Feb 25 00:25:06 2010 +0100
| @@ -273,7 +273,7 @@
|  # the output related methods
|  def write(self, *data):
|   Write to output stream. 
| -self.request.stream.writelines(data)
| +self.request.out_stream.writelines(data)
|  
|  def redirectedOutput(self, function, *args, **kw):
|   Redirect output during function, return redirected output 
| diff -r 1ecb884c0deb MoinMoin/web/request.py
| --- a/MoinMoin/web/request.py Tue Jan 19 00:35:00 2010 +0100
| +++ b/MoinMoin/web/request.py Thu Feb 25 00:25:06 2010 +0100
| @@ -47,7 +47,8 @@
|  self.response = []
|  self.status_code = 200
|  
| -in_stream = RequestBase.stream
| +in_stream = cached_property(RequestBase.stream.func, 'in_stream')
| +out_stream = cached_property(ResponseBase.stream.func, 'out_stream')
|  
|  @cached_property
|  def in_data(self):

and upsteram fixed it with this patch (which is compatible with Werkzeug 0.5):
http://hg.moinmo.in/moin/1.9/rev/ca98db50efac
-- 
Piotr Ożarowski Debian GNU/Linux Developer
www.ozarowski.pl  www.griffith.cc   www.debian.org
GPG Fingerprint: 1D2F A898 58DA AF62 1786 2DF7 AEF6 F1A2 A745 7645



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#571016: can't reproduce / lacks detail

2010-02-25 Thread Thomas Waldmann
Bug is likely fixed by:

http://hg.moinmo.in/moin/1.9/rev/ca98db50efac

Please test.





-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#571016: can't reproduce / lacks detail

2010-02-24 Thread Thomas Waldmann
I tried to reproduce this with:

moin 1.9.1 release and 1.9.current
werkzeug 0.6 release and current

I didn't get a traceback.

So, please give much more details about how to reproduce this, e.g. what
you did when the crash happen (URL? URL got removed above.)

It would be helpful if you could reproduce it with the standalone
wikiserver.py, so we don't need to setup apache just to find out whether
it is related to that.

I see it is using _fallback_cgi - do you have flup installed?

Is this CGI? FastCGI?

How does your moin.cgi / moin.fcgi look like?







-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#571016: can't reproduce / lacks detail

2010-02-24 Thread Frank Lin PIAT
On Wed, 2010-02-24 at 16:00 +0100, Thomas Waldmann wrote:
 I tried to reproduce this with:
 
 moin 1.9.1 release and 1.9.current
 werkzeug 0.6 release and current
 
 I didn't get a traceback.
 
 So, please give much more details about how to reproduce this, e.g. what
 you did when the crash happen (URL? URL got removed above.)
 
 It would be helpful if you could reproduce it with the standalone
 wikiserver.py, so we don't need to setup apache just to find out whether
 it is related to that.

I could reproduce the error with:
 - python-werkzeug 0.6-1 (the problem doesn't occur with 0.5.1)
 - python-flup 1.0.2-1

My apache config:
  FastCgiServer /path/to/moin.fcgi
  ScriptAlias /wiki /path/to/moin.fcgi

My mywiki.py:
  from farmconfig import FarmConfig

  class Config(FarmConfig):
sitename = u'MyWiki'
interwikiname = u'MyWiki'
page_front_page = uFrontPage
data_dir = '/var/lib/mywiki/data/'
data_underlay_dir = '/var/lib/mywiki/underlay/'
allow_xslt = True
cookie_lifetime = (1,1)


 I see it is using _fallback_cgi - do you have flup installed?

For the record, using fcgi without flup causes the error below. (using either 
werkzeug 0.5.1 or 0.6).

==
2010-02-24 22:59:22,450 WARNING __main__:77 No flup-package installed, only 
basic CGI support is available.
2010-02-24 22:59:22,451 ERROR MoinMoin.wsgiapp:292 An exception has occurred.
Traceback (most recent call last):
  File /usr/lib/pymodules/python2.5/MoinMoin/wsgiapp.py, line 279, in __call__
request = self.Request(environ)
  File /usr/lib/pymodules/python2.5/MoinMoin/web/request.py, line 45, in 
__init__
self.abs_href = Href(self.url_root, self.charset)
  File /usr/lib/pymodules/python2.5/werkzeug/utils.py, line 681, in __get__
value = self.func(obj)
  File /usr/lib/pymodules/python2.5/werkzeug/wrappers.py, line 355, in 
url_root
return get_current_url(self.environ, True)
  File /usr/lib/pymodules/python2.5/werkzeug/utils.py, line 1241, in 
get_current_url
tmp = [environ['wsgi.url_scheme'], '://', get_host(environ)]
  File /usr/lib/pymodules/python2.5/werkzeug/utils.py, line 1214, in get_host
result = environ['SERVER_NAME']
KeyError: 'SERVER_NAME'
Traceback (most recent call last):
  File /usr/share/moin/server/moin-.fcgi, line 80, in module
WSGIServer(application).run()
  File /usr/lib/pymodules/python2.5/MoinMoin/web/_fallback_cgi.py, line 69, 
in run
result = self.application(environ, start_response)
  File /usr/lib/pymodules/python2.5/werkzeug/utils.py, line 248, in __call__
return self.app(environ, start_response)
  File /usr/lib/pymodules/python2.5/MoinMoin/wsgiapp.py, line 279, in __call__
request = self.Request(environ)
  File /usr/lib/pymodules/python2.5/MoinMoin/web/request.py, line 45, in 
__init__
self.abs_href = Href(self.url_root, self.charset)
  File /usr/lib/pymodules/python2.5/werkzeug/utils.py, line 681, in __get__
value = self.func(obj)
  File /usr/lib/pymodules/python2.5/werkzeug/wrappers.py, line 355, in 
url_root
return get_current_url(self.environ, True)
  File /usr/lib/pymodules/python2.5/werkzeug/utils.py, line 1241, in 
get_current_url
tmp = [environ['wsgi.url_scheme'], '://', get_host(environ)]
  File /usr/lib/pymodules/python2.5/werkzeug/utils.py, line 1214, in get_host
result = environ['SERVER_NAME']
KeyError: 'SERVER_NAME'
===




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org