Bug#577273: Reversed and one error saturation level in 0.24.0

[Josselin Mouette]

forwarded 577273 https://bugzilla.gnome.org/show_bug.cgi?id=615417
thanks

Le dimanche 11 avril 2010 à 13:02 +0800, Wen-Yen Chuang a écrit : 
 In vte 0.24.0:
 1. when saturation is 1, the background image is original image (very
light).
 2. when saturation is less 1 but near 1, the image is black (dark).
 3. the saturation level is reversed compared with vte = 0.23.5
 
 In vte 0.23.5 and before:
 1. when saturation is near 1, the background image is light.
 2. when saturation is near 0, the background image is dark.
 
 The attached patch will fix the problem.

Thanks for the patch. I prefer to wait and see whether upstream chooses
to keep the old behavior or the new one before applying it.

Cheers,
-- 
 .''`.  Josselin Mouette
: :' :
`. `'  “If you behave this way because you are blackmailed by someone,
  `-[…] I will see what I can do for you.”  -- Jörg Schilling


signature.asc
Description: This is a digitally signed message part

Bug#577273: Reversed and one error saturation level in 0.24.0

[Wen-Yen Chuang]

Package: libvte9
Version: 1:0.24.0-2
Tags: patch

This is upstream bug #615417. [1]

In vte 0.24.0:
1. when saturation is 1, the background image is original image (very
   light).
2. when saturation is less 1 but near 1, the image is black (dark).
3. the saturation level is reversed compared with vte = 0.23.5

In vte 0.23.5 and before:
1. when saturation is near 1, the background image is light.
2. when saturation is near 0, the background image is dark.

The attached patch will fix the problem.

Kind regards
 Wen-Yen Chuang (caleb)

[1] https://bugzilla.gnome.org/show_bug.cgi?id=615417
--- vte-0.24.0.orig/src/vtebg.c
+++ vte-0.24.0/src/vtebg.c
@@ -500,7 +500,7 @@
    tint-red / 65535.,
    tint-green / 65535.,
    tint-blue / 65535.,
-   saturation);
+   1 - saturation);
 		cairo_set_operator (cr, CAIRO_OPERATOR_OVER);
 		cairo_paint (cr);
 	}