Bug#587493: closed by Frans Pop elen...@planet.nl (reply to 587...@bugs.debian.org) (Bug#587493: choose-mirror: Strange wget error message in the installation log)

2010-08-02 Thread Petter Reinholdtsen
For the record, these error messages from wget still happen with the
current squeeze installer:

  Aug  1 22:12:22 main-menu[319]: (process:2436): wget: server returned error: 
HTTP/1.0 404 Not Found
  Aug  1 22:17:45 main-menu[319]: (process:12241): wget: server returned error: 
HTTP/1.0 404 Not Found

I've patched debian-edu-install to ignore these errors when looking
for problems during installation, but wish it was not needed to throw
away error messages from d-i to avoid false positives.

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#587493: choose-mirror: Strange wget error message in the installation log

2010-06-29 Thread Petter Reinholdtsen

Package:  choose-mirror
Version:  2.32
User: debian-...@lists.debian.org
UserTags: debian-edu

In Debian Edu, we automatically search for error: in the installation
log to detect errors during installation.  When PXE installing, I get
this one:

  Jun 28 23:18:29 main-menu[555]: (process:2840): wget: server returned
error: HTTP/1.0 404 Not Found

It is a bogus error message that is creating noise and confusion in
the Debian Edu test installation.

I've tried to track down where it come from, and as far as I
understand from the log it must originate from choose-mirror.

This is the relevant log fragment:

Jun 28 23:18:28 main-menu[555]: DEBUG: resolver (localization-config-udeb): 
package doesn't exist (ignored)
Jun 28 23:18:28 anna-install: Queueing udeb partman-lvm for later installation
Jun 28 23:18:28 anna-install: Queueing udeb partman-auto-lvm for later 
installation
Jun 28 23:18:28 main-menu[555]: INFO: Falling back to the package description 
for auto-install
Jun 28 23:18:28 main-menu[555]: INFO: Falling back to the package description 
for ai-choosers
Jun 28 23:18:28 main-menu[555]: INFO: Menu item 'choose-mirror' selected
Jun 28 23:18:28 anna-install: Queueing udeb apt-mirror-setup for later 
installation
Jun 28 23:18:28 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/oldstable/Release -O - | grep -E 
'^(Suite|Codename):'
Jun 28 23:18:28 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/stable/Release -O - | grep -E 
'^(Suite|Codename):'
Jun 28 23:18:29 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/lenny/Release -O - | grep -E 
'^(Suite|Codename):'
Jun 28 23:18:29 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/testing/Release -O - | grep -E 
'^(Suite|Codename):'
Jun 28 23:18:29 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/squeeze/Release -O - | grep -E 
'^(Suite|Codename):'
Jun 28 23:18:29 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/unstable/Release -O - | grep -E 
'^(Suite|Codename):'
Jun 28 23:18:29 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/sid/Release -O - | grep -E 
'^(Suite|Codename):'
Jun 28 23:18:29 choose-mirror[2847]: INFO: suite/codename set to: 
testing/squeeze
Jun 28 23:18:29 choose-mirror[2847]: DEBUG: command: wget -q 
http://ftp.skolelinux.org/debian/dists/squeeze/main/binary-i386/Release -O - | 
grep ^Architecture:
Jun 28 23:18:29 anna-install: Queueing udeb squeeze-support for later 
installation
Jun 28 23:18:29 main-menu[555]: (process:2840): wget: server returned error: 
HTTP/1.0 404 Not Found
Jun 28 23:18:29 main-menu[555]: DEBUG: resolver (libc6-udeb): package doesn't 
exist (ignored)

The URLs in the log seem to work, so I do not understand why wget is
complaining.  Is there some other wget calls that are not reported to
the log?

The only wget calls I find in choose-mirror do not throw away error
messages.  Perhaps they should?  If so, this untested patch should
implement it:

debian/changelog

  * Throw away stderr when calling wget, to avoid getting bogus error
messages in the installation log.

--- choose-mirror.c (revision 63581)
+++ choose-mirror.c (working copy)
@@ -243,7 +243,7 @@
free(directory);
directory = strdup(debconf-value);
 
-   asprintf(command, wget -q %s://%s%s/dists/%s/Release -O - | grep -E 
'^(Suite|Codename):',
+   asprintf(command, wget -q %s://%s%s/dists/%s/Release -O - 2/dev/null 
| grep -E '^(Suite|Codename):',
 protocol, hostname, directory, name);
di_log(DI_LOG_LEVEL_DEBUG, command: %s, command);
f = popen(command, r);
@@ -757,7 +757,7 @@
if (strlen(debconf-value)  0) {
codename = strdup(debconf-value);
 
-   asprintf(command, wget -q 
%s://%s%s/dists/%s/main/binary-%s/Release -O - | grep ^Architecture:,
+   asprintf(command, wget -q 
%s://%s%s/dists/%s/main/binary-%s/Release -O - 2/dev/null | grep 
^Architecture:,
 protocol, hostname, directory, codename, ARCH_TEXT);
di_log(DI_LOG_LEVEL_DEBUG, command: %s, command);
f = popen(command, r);

Happy hacking,
-- 
Petter Reinholdtsen



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#587493: choose-mirror: Strange wget error message in the installation log

2010-06-29 Thread Frans Pop
On Tuesday 29 June 2010, Petter Reinholdtsen wrote:
 In Debian Edu, we automatically search for error: in the installation
 log to detect errors during installation.

Then it seems you need to make an exception for this error.

 When PXE installing, I get this one:

   Jun 28 23:18:29 main-menu[555]: (process:2840): wget: server returned
 error: HTTP/1.0 404 Not Found

So, one wget results in a 404. As choose-mirror tries various possible 
suites and codenames and wgets are used for other purposes as well, a 404 
is always a possibility.

 It is a bogus error message that is creating noise and confusion in
 the Debian Edu test installation.

It's not bogus. It's a useful message for troubleshooting and debugging.
The only thing that is a pity is that logging of the error messages to 
stderr gets delayed until the component completes.

 The URLs in the log seem to work, so I do not understand why wget is
 complaining.  Is there some other wget calls that are not reported to
 the log?

Did you check the code?

 The only wget calls I find in choose-mirror do not throw away error
 messages.  Perhaps they should?  If so, this untested patch should
 implement it:

NACK. The errors are too useful to suppress.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#587493: choose-mirror: Strange wget error message in the installation log

2010-06-29 Thread Petter Reinholdtsen
[Frans Pop]
 So, one wget results in a 404. As choose-mirror tries various
 possible suites and codenames and wgets are used for other purposes
 as well, a 404 is always a possibility.

Sure, but all the URLs listed in the log are working, so it seem
strange that one of them give 404.

 It's not bogus. It's a useful message for troubleshooting and
 debugging.  The only thing that is a pity is that logging of the
 error messages to stderr gets delayed until the component completes.

It is bogus, as all the URLs in the log are working when I test them
manually, and it is close to impossible to figure out what URL was
failing.

  The URLs in the log seem to work, so I do not understand why wget is
  complaining.  Is there some other wget calls that are not reported to
  the log?
 
 Did you check the code?

Yes.  Only found the two mentioned in the patch, and neither seem to
use a non-existing URL. :/

 The only wget calls I find in choose-mirror do not throw away error
 messages.  Perhaps they should?  If so, this untested patch should
 implement it:
 
 NACK. The errors are too useful to suppress.

I disagree.  The error in question is almost useless.  There is no way
to see which URL was missing, and the message show up in the wrong
location in the log.  A useful error message would make it possible to
figure out what is wrong.  This one do not. :(

If the error message continue to come from d-i, we need to filter it
out in debian-edu, but I thought it best to try to get rid of it
first.

Happy hacking,
-- 
Petter Reinholdtsen




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#587493: choose-mirror: Strange wget error message in the installation log

2010-06-29 Thread Frans Pop
On Tuesday 29 June 2010, Petter Reinholdtsen wrote:
 [Frans Pop]
  So, one wget results in a 404. As choose-mirror tries various
  possible suites and codenames and wgets are used for other purposes
  as well, a 404 is always a possibility.

 Sure, but all the URLs listed in the log are working, so it seem
 strange that one of them give 404.

So either it's due to a temporary mirror issue (which you'd want to know 
about), or it's from an unlogged wget. Or it's from a wget from a 
subprogram called by choose-mirror, in which case you patch won't even 
help.

  It's not bogus. It's a useful message for troubleshooting and
  debugging.  The only thing that is a pity is that logging of the
  error messages to stderr gets delayed until the component completes.

 It is bogus, as all the URLs in the log are working when I test them
 manually, and it is close to impossible to figure out what URL was
 failing.

No, it's not bogus. There *is* a wget that's failing. Whether it affects 
the end result of the install or not is another matter.

wgets in choose-mirror can fail for various valid reasons. Most of them you 
want to know about for troubleshooting purposes.
Examples are: (temporarily) broken mirrors, incomplete mirrors, broken 
proxies. I've seen 403s and 404s that have helped a lot tracing the cause 
of failed installs.

Removing valid information from logs for cosmetic reasons is wrong.

   The URLs in the log seem to work, so I do not understand why wget is
   complaining.  Is there some other wget calls that are not reported
   to the log?
 
  Did you check the code?

 Yes.  Only found the two mentioned in the patch, and neither seem to
 use a non-existing URL. :/

So, you'll need to look a bit deeper. Usually we fix the *cause* of errors. 
We don't suppress errors for cosmetic reasons.

  The only wget calls I find in choose-mirror do not throw away error
  messages.  Perhaps they should?  If so, this untested patch should
  implement it:
 
  NACK. The errors are too useful to suppress.

 I disagree.  The error in question is almost useless.  There is no way
 to see which URL was missing, and the message show up in the wrong
 location in the log.  A useful error message would make it possible to
 figure out what is wrong.  This one do not. :(

But it's currently all we have! And, as mentioned before, it *has* helped 
me a number of times in the past, both while tracing issues from 
installation reports and while debugging.

Improving the error handling is valid. Simply removing the messages without 
replacing them with something else (better) is plain wrong.

 If the error message continue to come from d-i, we need to filter it
 out in debian-edu, but I thought it best to try to get rid of it
 first.

If you can't come up with a proper solution for choose-mirror then that is 
the correct way to go. The primary purpose of the syslog is to help users 
and developers to find the cause of issues. Removing real error messages 
for cosmetic reasons does not improve the installer.



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#587493: choose-mirror: Strange wget error message in the installation log

2010-06-29 Thread Frans Pop
On Tuesday 29 June 2010, Frans Pop wrote:
   NACK. The errors are too useful to suppress.
 
  I disagree.  The error in question is almost useless.  There is no way
  to see which URL was missing, and the message show up in the wrong
  location in the log.  A useful error message would make it possible to
  figure out what is wrong.  This one do not. :(

Note that the order of the errors does match the order of calls. Together 
with other info I've always been able to match things up properly.

I agree (and said so in my initial reply) that the current situation is not 
ideal, but that does not make the errors useless.



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#587493: choose-mirror: Strange wget error message in the installation log

2010-06-29 Thread Holger Levsen
so which of Petters wget calls failed?


signature.asc
Description: This is a digitally signed message part.