Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-10 Thread Michelle Konzack
Hello Slavko,

Am 2010-08-09 16:03:59, schrieb Slavko:
  It seems, that mcedit-debian should be removed since it is useless.
 
 OK, i did this and now it now works :-)

Perfectly, then Yury, know how to solv it for the future.

Maybe we can get it into Squeeze even if it is frozen?

 thank you

Nothing to thanks, because mc is a tool I use daily and very heavy...
So I have to care about it.  ;-)

Thanks, Greetings and nice Day/Evening
Michelle Konzack

-- 
# Debian GNU/Linux Consultant ##
   Development of Intranet and Embedded Systems with Debian GNU/Linux

itsyst...@tdnet France EURL   itsyst...@tdnet UG (limited liability)
Owner Michelle KonzackOwner Michelle Konzack

Apt. 917 (homeoffice)
50, rue de Soultz Kinzigstraße 17
67100 Strasbourg/France   77694 Kehl/Germany
Tel: +33-6-61925193 mobil Tel: +49-177-9351947 mobil
Tel: +33-9-52705884 fix

http://www.itsystems.tamay-dogan.net/  http://www.flexray4linux.org/
http://www.debian.tamay-dogan.net/ http://www.can4linux.org/

Jabber linux4miche...@jabber.ccc.de
ICQ#328449886

Linux-User #280138 with the Linux Counter, http://counter.li.org/


signature.pgp
Description: Digital signature


Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Yury V. Zaytsev
On Mon, 2010-08-09 at 10:42 +0200, Yury V. Zaytsev wrote:

 I guess that if you configure mcedit as sensible-editor and turn on use
 external editor switch in mc it might not quote the name correctly. I
 didn't check this out though...

Hmmm... just tested my assumption. Seems to work fine. 
I can't reproduce this bug.
 
-- 
Sincerely yours,
Yury V. Zaytsev




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Michelle Konzack
Am 2010-08-09 10:46:46, schrieb Yury V. Zaytsev:
 On Mon, 2010-08-09 at 10:42 +0200, Yury V. Zaytsev wrote:
 
  I guess that if you configure mcedit as sensible-editor and turn on use
  external editor switch in mc it might not quote the name correctly. I
  didn't check this out though...
 
 Hmmm... just tested my assumption. Seems to work fine. 
 I can't reproduce this bug.

Here too...

Does quoting depend on the shell used?

Thanks, Greetings and nice Day/Evening
Michelle Konzack

-- 
# Debian GNU/Linux Consultant ##
   Development of Intranet and Embedded Systems with Debian GNU/Linux

itsyst...@tdnet France EURL   itsyst...@tdnet UG (limited liability)
Owner Michelle KonzackOwner Michelle Konzack

Apt. 917 (homeoffice)
50, rue de Soultz Kinzigstraße 17
67100 Strasbourg/France   77694 Kehl/Germany
Tel: +33-6-61925193 mobil Tel: +49-177-9351947 mobil
Tel: +33-9-52705884 fix

http://www.itsystems.tamay-dogan.net/  http://www.flexray4linux.org/
http://www.debian.tamay-dogan.net/ http://www.can4linux.org/

Jabber linux4miche...@jabber.ccc.de
ICQ#328449886

Linux-User #280138 with the Linux Counter, http://counter.li.org/


signature.pgp
Description: Digital signature


Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Slavko
Ahoj,

Dňa Mon, 09 Aug 2010 10:46:46 +0200 Yury V. Zaytsev y...@shurup.com
napísal:

 On Mon, 2010-08-09 at 10:42 +0200, Yury V. Zaytsev wrote:
 
  I guess that if you configure mcedit as sensible-editor and turn on
  use external editor switch in mc it might not quote the name
  correctly. I didn't check this out though...
 
 Hmmm... just tested my assumption. Seems to work fine. 
 I can't reproduce this bug.
  

I have configured mcedit as editor, by alternatives:

There are 4 choices for the alternative editor (providing /usr/bin/editor).

  SelectionPathPriority   Status

  0/bin/nano40auto mode
  1/bin/ed -100   manual mode
  2/bin/nano40manual mode
* 3/usr/bin/mcedit-debian   25manual mode
  4/usr/bin/vim.tiny10manual mode

I tested change it to nano and vim too and both works fain with space
in filename. If i use debian.mcedit as alternative, then space is used
as separator...

-- 
s pozdravom

Slavko
http://slavino.sk


signature.asc
Description: PGP signature


Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Yury V. Zaytsev
Hi!

On Mon, 2010-08-09 at 11:03 +0200, Michelle Konzack wrote:

 Here too...
 
 Does quoting depend on the shell used?

Good point, I have no idea. I have bash, OP has dash. I can't test dash
though, as I am not using Debian anyways :-)

What I can observe in the source code of do_edit_at_line 

fn = vfs_canon_and_translate (filename);
do_execute (command, fn, EXECUTE_INTERNAL);

is that it does not appear to do any quoting explicitly.

However, it launches the process with the arguments as it has, so the
process knows that it's a file name with a space in between.

Try it out by circumventing sensible-editor: EDITOR=mcedit mc.

I guess it's an issue with /usr/bin/mcedit-debian that we ship. It
probably should have $@ instead of just $...@. 

I'm not a big fan of this solution, but it appears that sensbile-editor
only expects one argument (that is a file name), so we can live with it.

Ideas?

Best,
 
-- 
Sincerely yours,
Yury V. Zaytsev




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Michelle Konzack
Am 2010-08-09 11:47:08, schrieb Yury V. Zaytsev:
 Try it out by circumventing sensible-editor: EDITOR=mcedit mc.
 
 I guess it's an issue with /usr/bin/mcedit-debian that we ship. It
 probably should have $@ instead of just $...@. 
 
 I'm not a big fan of this solution, but it appears that sensbile-editor
 only expects one argument (that is a file name), so we can live with it.
 
 Ideas?

Hmmm, I am wondering WHY we have mcedit-debian, if there is a symlink

lrwxrwxrwx 1 root root 2 19. Apr 2009  /usr/bin/mcedit - mc

which works fine without the need for mcedit-debian.
Even mcedit-debian is only calling

mcedit $@

and I am puzzeling why.

Maybe Debian should drop the thing with mcedit-debian?

Thanks, Greetings and nice Day/Evening
Michelle Konzack

-- 
# Debian GNU/Linux Consultant ##
   Development of Intranet and Embedded Systems with Debian GNU/Linux

itsyst...@tdnet France EURL   itsyst...@tdnet UG (limited liability)
Owner Michelle KonzackOwner Michelle Konzack

Apt. 917 (homeoffice)
50, rue de Soultz Kinzigstraße 17
67100 Strasbourg/France   77694 Kehl/Germany
Tel: +33-6-61925193 mobil Tel: +49-177-9351947 mobil
Tel: +33-9-52705884 fix

http://www.itsystems.tamay-dogan.net/  http://www.flexray4linux.org/
http://www.debian.tamay-dogan.net/ http://www.can4linux.org/

Jabber linux4miche...@jabber.ccc.de
ICQ#328449886

Linux-User #280138 with the Linux Counter, http://counter.li.org/


signature.pgp
Description: Digital signature


Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Yury V. Zaytsev
Hi!

On Mon, 2010-08-09 at 11:57 +0200, Michelle Konzack wrote:

 Maybe Debian should drop the thing with mcedit-debian?

This is actually something I don't understand either. 

It was added by Adam Byrtek al...@debian.org sometime at the beginning
of the century (even before the package source got into a source control
system) and until now, nobody run into this bug.

My guess is that maybe the alternatives system at that time didn't
accept symlinks as valid editors, so he decided to create a wrapper
instead to work around this problem.

Whether it's true or not and if it is still needed or not I have no
clue. This would be a subject of an investigation on its own...
 
-- 
Sincerely yours,
Yury V. Zaytsev




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Michelle Konzack
Am 2010-08-09 11:14:17, schrieb Slavko:
   SelectionPathPriority   Status
 
   0/bin/nano40auto mode
   1/bin/ed -100   manual mode
   2/bin/nano40manual mode
 * 3/usr/bin/mcedit-debian   25manual mode
   4/usr/bin/vim.tiny10manual mode
 
 I tested change it to nano and vim too and both works fain with space
 in filename. If i use debian.mcedit as alternative, then space is used
 as separator...

OK, can you try following:

Open the file /var/lib/dpkg/info/mc.prostinst end change any references
from
mcedit-debian
to
mcedit

and then run

dpkg-reconfigure mc

then after this, retry the issue with  Midnight  Commander  and  editing
files and report it back.

It seems, that mcedit-debian should be removed since it is useless.

Thanks, Greetings and nice Day/Evening
Michelle Konzack

-- 
# Debian GNU/Linux Consultant ##
   Development of Intranet and Embedded Systems with Debian GNU/Linux

itsyst...@tdnet France EURL   itsyst...@tdnet UG (limited liability)
Owner Michelle KonzackOwner Michelle Konzack

Apt. 917 (homeoffice)
50, rue de Soultz Kinzigstraße 17
67100 Strasbourg/France   77694 Kehl/Germany
Tel: +33-6-61925193 mobil Tel: +49-177-9351947 mobil
Tel: +33-9-52705884 fix

http://www.itsystems.tamay-dogan.net/  http://www.flexray4linux.org/
http://www.debian.tamay-dogan.net/ http://www.can4linux.org/

Jabber linux4miche...@jabber.ccc.de
ICQ#328449886

Linux-User #280138 with the Linux Counter, http://counter.li.org/


signature.pgp
Description: Digital signature


Bug#592208: [Pkg-mc-devel] Bug#592208: Bug#592208: mc: Can't open files for edit (F4) with space in filenames

2010-08-09 Thread Slavko
Ahoj,

Dňa Mon, 9 Aug 2010 14:57:18 +0200 Michelle Konzack
linux4miche...@tamay-dogan.net napísal:

 It seems, that mcedit-debian should be removed since it is useless.

OK, i did this and now it now works :-)

thank you

-- 
s pozdravom

Slavko
http://slavino.sk


signature.asc
Description: PGP signature