Bug#592320: nslcd: unnecessary $ expansions cause spurious warnings

2010-08-14 Thread Arthur de Jong
tags 592320 + pending
thanks

On Mon, 2010-08-09 at 10:24 +0200, Sergio Gelato wrote:
 common/expr.c:parse_dollar_expression() will always evaluate $cn in
 ${gecos:-$cn} even when the gecos attribute is non-null. For an entry
 with multiple cn values, this results in warnings entry $dn contains
 multiple cn values which are just an annoyance when the entry also
 contains a gecos attribute. (There are legitimate reasons for the cn
 attribute to be multi-valued.)
 
 Would it be possible to optimize away the evaluation of the right-hand
 side of :- and :+ based on the value of the left-hand side?

Thanks for pointing this out. I've fixed this and it will be in the next
release.

-- 
-- arthur - adej...@debian.org - http://people.debian.org/~adejong --


signature.asc
Description: This is a digitally signed message part


Bug#592320: nslcd: unnecessary $ expansions cause spurious warnings

2010-08-09 Thread Sergio Gelato
Package: nss-pam-ldapd
Version: 0.7.2
Severity: minor

[Seen in version 0.7.2 on Ubuntu lucid, probably also applies to the latest
version since the VCS shows no relevant code changes since then.]

common/expr.c:parse_dollar_expression() will always evaluate $cn in
${gecos:-$cn} even when the gecos attribute is non-null. For an entry
with multiple cn values, this results in warnings entry $dn contains
multiple cn values which are just an annoyance when the entry also
contains a gecos attribute. (There are legitimate reasons for the cn
attribute to be multi-valued.)

Would it be possible to optimize away the evaluation of the right-hand
side of :- and :+ based on the value of the left-hand side?



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org