Bug#594088: [Pkg-samba-maint] Bug#594088: samba-common: wins server not added to /etc/samba/dhcp.conf
On Sat, Jan 29, 2011 at 07:59:56AM +0100, Christian PERRIER wrote: Quoting Mario 'BitKoenig' Holbe (mario.ho...@tu-ilmenau.de): This bug shows up if the lease is RELEASEd AND is still valid upon ifup. ... The attached patch fixes this issue at least for the empty dhcp.conf It's unfortuunately too late for this, sorry. Bummer. I'll probably consider this for post-squeeze and will look more closely to this bug report, then eventually add your patch. Thanks for your work... Should you do, please also consider adjusting the name resolve order according to a DHCP supplied netbios-node-type (dhcp-options(5)) as well. Debian's dhclient doesn't currently request this option from the server but i'm sure this can be changed post-squeeze :) Mario -- There are trivial truths and the great truths. The opposite of a trivial truth is plainly false. The opposite of a great truth is also true. -- Niels Bohr signature.asc Description: Digital signature
Bug#594088: [Pkg-samba-maint] Bug#594088: samba-common: wins server not added to /etc/samba/dhcp.conf
On Sat, Jan 29, 2011 at 12:34:08PM +0100, Mario 'BitKoenig' Holbe wrote: On Sat, Jan 29, 2011 at 07:59:56AM +0100, Christian PERRIER wrote: Quoting Mario 'BitKoenig' Holbe (mario.ho...@tu-ilmenau.de): This bug shows up if the lease is RELEASEd AND is still valid upon ifup. ... The attached patch fixes this issue at least for the empty dhcp.conf It's unfortuunately too late for this, sorry. Bummer. I'll probably consider this for post-squeeze and will look more closely to this bug report, then eventually add your patch. Thanks for your work... Should you do, please also consider adjusting the name resolve order according to a DHCP supplied netbios-node-type (dhcp-options(5)) as well. Debian's dhclient doesn't currently request this option from the server but i'm sure this can be changed post-squeeze :) I don't think we want to do that. There are only a few sensible values for name resolve order, and I don't think any settings a dhcp server might send via netbios-node-type would help us select between these. (The main things to select are whether to give precedence to DNS or WINS; and whether or not to fall back to broadcast at all. The latter might be a site preference, but I'd be more worried about the DHCP admin getting this wrong than about any adverse effects of leaving this in place as a fallback. -- Steve Langasek Give me a lever long enough and a Free OS Debian Developer to set it on, and I can move the world. Ubuntu Developerhttp://www.debian.org/ slanga...@ubuntu.com vor...@debian.org signature.asc Description: Digital signature
Bug#594088: [Pkg-samba-maint] Bug#594088: samba-common: wins server not added to /etc/samba/dhcp.conf
Quoting Mario 'BitKoenig' Holbe (mario.ho...@tu-ilmenau.de): This bug shows up if the lease is RELEASEd AND is still valid upon ifup. If the lease is not valid upon ifup, dhclient enters the BOUND state with empty old_* variables: everyting works well in the samba hook. If the lease is still valid upon ifup and not RELEASEd, dhclient re-requests it and enters the somewhat special REBOOT state where it clears the old_* variables: everyting works well in the samba hook. Unfortunately, Debian's ifdown initiates an DHCPRELEASE. Hence, if the lease is still valid upon ifup it gets offered to dhclient again and it enters the BOUND state with filled old_* variables. The attached patch fixes this issue at least for the empty dhcp.conf case. It does not fix more complex scenarios where information of multiple DHCP servers is merged into one dhcp.conf. Hence, the patch should be considered intermediate - to get it into squeeze, for example. It's unfortuunately too late for this, sorry. I'll probably consider this for post-squeeze and will look more closely to this bug report, then eventually add your patch. Thanks for your work... signature.asc Description: Digital signature
