Bug#596593: vdr-dev: vdrdbg-buildpackage is not a makefile

2010-10-17 Thread Tobias Grimm 
 -export DEB_BUILD_OPTIONS=$DEB_BUILD_OPTIONS noopt nostrip
 +export DEB_BUILD_OPTIONS=noopt nostrip $DEB_BUILD_OPTIONS
 would do as well? A leading blank in DEB_BUILD_OPTIONS causes
 problems, a trailing blank does not (at least for me).

Looks good to me.

@Julien / Malte: Thanks for reporting and providing a fix.

I'll upload the fix soon.

Sorry for the delay!

Tobias





-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#596593: vdr-dev: vdrdbg-buildpackage is not a makefile

2010-09-12 Thread Julien Cristau 
Package: vdr-dev
Version: 1.6.0-18
Severity: normal

Looking at the diff between vdr in testing and sid I notice:

-export DEB_BUILD_OPTIONS=$DEB_BUILD_OPTIONS noopt nostrip
+[ -z $DEB_BUILD_OPTIONS ] || export DEB_BUILD_OPTIONS=$DEB_BUILD_OPTIONS 
+export DEB_BUILD_OPTIONS=$(DEB_BUILD_OPTIONS)noopt nostrip

The $(foo) syntax to reference a variable is a make-ism, it doesn't work
in shell, you want ${foo}.

Cheers,
Julien


signature.asc
Description: Digital signature

Bug#596593: vdr-dev: vdrdbg-buildpackage is not a makefile

2010-09-12 Thread Malte Forkel 
 Am 12.09.2010 20:46, schrieb Julien Cristau:
 Package: vdr-dev
 Version: 1.6.0-18
 Severity: normal

 Looking at the diff between vdr in testing and sid I notice:

 -export DEB_BUILD_OPTIONS=$DEB_BUILD_OPTIONS noopt nostrip
 +[ -z $DEB_BUILD_OPTIONS ] || export DEB_BUILD_OPTIONS=$DEB_BUILD_OPTIONS 
 +export DEB_BUILD_OPTIONS=$(DEB_BUILD_OPTIONS)noopt nostrip

 The $(foo) syntax to reference a variable is a make-ism, it doesn't work
 in shell, you want ${foo}.

May be

-export DEB_BUILD_OPTIONS=$DEB_BUILD_OPTIONS noopt nostrip
+export DEB_BUILD_OPTIONS=noopt nostrip $DEB_BUILD_OPTIONS

would do as well? A leading blank in DEB_BUILD_OPTIONS causes problems,
a trailing blank does not (at least for me).

Malte