Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2013-07-07 Thread Eugene Paskevich

Hello,

So, as per my understanding, there is no confirmed positive impact of this
patch, and on the other hand there is a confirmed negative impact
(confirmed by me as well).

In this case, if I was in the maintainer's place, I'd remove the patch and
wait for reports that might be relative to this patch and fix it  
appropriately

afterwards.

--
Eugene Paskevich |   *==)---   | Plug me into
eug...@raptor.kiev.ua|   ---(==*   |  The Matrix


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2013-07-07 Thread Eugene Paskevich

Hello,

So, as per my understanding, there is no confirmed positive impact of this
patch,
and on the other hand there is a confirmed negative impact (confirmed by
me as well).

In this case, if I was in the maintainer's place, I'd remove the patch and
wait for
reports that might be relative to this patch and fix it appropriately
afterwards.

--
Eugene Paskevich |   *==)---   | Plug me into
eug...@raptor.kiev.ua|   ---(==*   |  The Matrix


--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2013-06-01 Thread Chris Boot
Hi Marco,

I've reviewed this bug and the recommended fix and it seems sound to me.
Unfortunately I don't have an easy way to reproduce the issue as I
currently only use PPPoE and don't have any modems lying around. Is
there a test case I can use to reproduce this issue without requiring
any specific hardware?

Why was the patch added in the first place? It seems to have been
introduced in 2.4.5-1 with the changelog entry simply stating:

  * Added patch always_setsid: always create a new process group.

There is no bug number to reference a bug that is fixed by adding the patch.

Marco: do you have any objections to me preparing an NMU with the
always_setsid patch removed, assuming I can reproduce it and removing
the patch fixes the issue?

Thanks,
Chris

-- 
Chris Boot
bo...@bootc.net



signature.asc
Description: OpenPGP digital signature


Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2013-06-01 Thread Marco d'Itri
On Jun 02, Chris Boot bo...@bootc.net wrote:

   * Added patch always_setsid: always create a new process group.
I do not remember the origin of this patch, but if there is no bug 
number then I have probably inherited it from the precedent maintainer.

 Marco: do you have any objections to me preparing an NMU with the
 always_setsid patch removed, assuming I can reproduce it and removing
 the patch fixes the issue?
There are a lot of bugs which need to be fixed, I am looking for 
a co-maintainer.


-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2012-02-09 Thread Rafal Dabrowa

How to repeat the problem: assume the following pppd command does work:

pppd call foo

The following command causes hangup immediately after connect:

dash -c pppd call foo updetach

Problem is caused by always_setsid patch. The patch is unnecessary 
with ppp 2.4.5 because problem which the patch is for, was fixed in 
original code - see differences between 2.4.4 and 2.4.5 in file 
pppd/main.c, function kill_my_pg(). The patch removal should correct the 
problem, without any negative impact.


Rafal



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2012-01-24 Thread Rafal Dabrowa
The bug does not appear in original pppd code. It is caused by 
always_setsid patch. With this patch, setsid() function is invoked 
before opening modem (tty) device. If the setsid() succeeds, pppd 
process is losing their controlling tty and then the opened modem device 
becomes a controlling tty of the pppd. This causes that when the parent 
dies, HUP signal is sent to all children processes - in particular to 
the child process communicating via modem.


The setsid() function fails when pppd is invoked directly from shell. It 
succeeds when is invoked e.g. from a shell script. If sedsid() fails, 
HUP signal is not sent to children when parent dies because the opened 
modem device does not become the controlling tty. This explains behavior 
described by David (Message #27).


As I understand, the always_setsid patch was added to prevent from 
kill of parent processes when a signal is delivered to pppd. But, as I 
see in the original pppd code, the problem should not appear. How old is 
the patch? Maybe the problem was fixed in original code some time ago, 
and the patch is not needed?



Rafal



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org



Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2011-01-06 Thread Marco d'Itri
tag 598551 unreproducible help
thanks

Sorry, I am unable to reproduce this with my E51.

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2010-12-29 Thread Marco d'Itri
On Sep 30, Russell Stuart russell-deb...@stuart.id.au wrote:

 I am using pppd to connect via a Nokia E70 phone.  This has worked
 well until recently, where recently means it didn't work yesterday,
Any news? Do you mind trying with the new generic configuration?
/usr/share/doc/ppp/examples/peers-gprs and /etc/chatscripts/gprs .

-- 
ciao,
Marco


signature.asc
Description: Digital signature


Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2010-12-29 Thread Russell Stuart
On Wed, 2010-12-29 at 22:50 +0100, Marco d'Itri wrote:
 On Sep 30, Russell Stuart russell-deb...@stuart.id.au wrote:
  I am using pppd to connect via a Nokia E70 phone.  This has worked
  well until recently, where recently means it didn't work yesterday,

 Any news? Do you mind trying with the new generic configuration?
 /usr/share/doc/ppp/examples/peers-gprs and /etc/chatscripts/gprs .

No change when using my configuration.  Latest squeeze updates have been
installed:

  Package: ppp
  Priority: optional
  Section: admin
  Installed-Size: 1016
  Maintainer: Marco d'Itri m...@linux.it
  Architecture: amd64
  Version: 2.4.5-4

The vanilla /usr/share/doc/ppp/examples/peers-gprs
and /etc/chatscripts/gprs don't work when you just insert the right
device and APN.  The minimally
modified /usr/share/doc/ppp/examples/peers-gprs is:

  # example configuration for a GPRS/UMTS/HDSPA connection
  #
  # See the manual page pppd(8) for information on all the options.

  # If your carrier requires authentication, uncomment this directive
  # and replace myusern...@realm with the login name provided by them.
  # If authentication is used, there should be a matching entry with the
  # password in /etc/ppp/pap-secrets and/or /etc/ppp/chap-secrets.
  #user myusern...@realm

  # MUST CHANGE: replace  with the APN name specific to your
  # mobile carrier and data plan.
  # The /etc/chatscripts/gprs chat script may be modified to change the
  # modem initialization string.
  connect /usr/sbin/chat -v -f /etc/chatscripts/gprs -T internet

  # Serial device to which the modem is connected.
  /dev/ttyACM0

  # Assumes that your IP address is allocated dynamically by the ISP.
  noipdefault
  # Try to get the name server addresses from the ISP.
  usepeerdns
  # Use this connection as the default route.
  defaultroute

  # Makes pppd dial again when the connection is lost.
  persist

  # Do not ask the remote to authenticate.
  noauth

  # Disable some PPP protocol features which are usually not supported
  # by mobile carriers.
  novj
  novjccomp
  noccp
  nomagic

Running sudo pppd updetach call peers-gprs produces this log:

  Dec 30 10:09:23 russell-laptop pppd[22428]: pppd 2.4.5 started by rstuart, 
uid 0
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (BUSY)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (VOICE)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (NO CARRIER)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (NO DIALTONE)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (NO DIAL TONE)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (NO ANSWER)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (DELAYED)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (ERROR)
  Dec 30 10:09:24 russell-laptop chat[22429]: abort on (+CGATT: 0)
  Dec 30 10:09:24 russell-laptop chat[22429]: send (AT^M)
  Dec 30 10:09:24 russell-laptop chat[22429]: timeout set to 12 seconds
  Dec 30 10:09:24 russell-laptop chat[22429]: expect (OK)
  Dec 30 10:09:24 russell-laptop chat[22429]: ^M
  Dec 30 10:09:24 russell-laptop chat[22429]: NO CARRIER
  Dec 30 10:09:24 russell-laptop chat[22429]:  -- failed
  Dec 30 10:09:24 russell-laptop chat[22429]: Failed (NO CARRIER)
  Dec 30 10:09:32 russell-laptop pppd[22428]: Terminating on signal 2
  Dec 30 10:09:32 russell-laptop pppd[22428]: Exit.

Adding crtscts fixed that problem.  Running it in when sudo pppd
updetach call peers-gprs then failed in the same way my configuration
does:

  Dec 30 10:25:14 russell-laptop pppd[23660]: pppd 2.4.5 started by rstuart, 
uid 0
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (BUSY)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (VOICE)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (NO CARRIER)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (NO DIALTONE)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (NO DIAL TONE)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (NO ANSWER)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (DELAYED)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (ERROR)
  Dec 30 10:25:15 russell-laptop chat[23661]: abort on (+CGATT: 0)
  Dec 30 10:25:15 russell-laptop chat[23661]: send (AT^M)
  Dec 30 10:25:15 russell-laptop chat[23661]: timeout set to 12 seconds
  Dec 30 10:25:15 russell-laptop chat[23661]: expect (OK)
  Dec 30 10:25:15 russell-laptop chat[23661]: AT^M^M
  Dec 30 10:25:15 russell-laptop chat[23661]: OK
  Dec 30 10:25:15 russell-laptop chat[23661]:  -- got it
  Dec 30 10:25:15 russell-laptop chat[23661]: send (ATH^M)
  Dec 30 10:25:15 russell-laptop chat[23661]: expect (OK)
  Dec 30 10:25:15 russell-laptop chat[23661]: ^M
  Dec 30 10:25:15 russell-laptop chat[23661]: ATH^M^M
  Dec 30 10:25:15 russell-laptop chat[23661]: OK
  Dec 30 10:25:15 russell-laptop chat[23661]:  -- got it
  Dec 30 10:25:15 russell-laptop chat[23661]: send (ATE1^M)
  Dec 30 10:25:15 russell-laptop chat[23661]: expect (OK)
  Dec 30 10:25:15 

Bug#598551: /usr/sbin/pppd: updetach option causes Connection terminated

2010-09-29 Thread Russell Stuart
Package: ppp
Version: 2.4.5-4
Severity: normal
File: /usr/sbin/pppd

I am using pppd to connect via a Nokia E70 phone.  This has worked
well until recently, where recently means it didn't work yesterday,
and was definitely working a month or two ago when I last used it.
I haven't altered any relevant configuration files between when it was
working and now.

The command used to invoke it is:

  pppd call gprs-optus.peer

When /etc/ppp/peers/gprs-optus.peer contains this:

  asyncmap 0
  noauth
  /dev/ttyACM0
  115200
  connect /usr/sbin/chat -v -T internet -f /etc/ppp/peers/gprs.chat
  debug
  crtscts
  noipdefault
  defaultroute
  usepeerdns
  updetach

The connection is made successfully, but then is terminated immediately.
Here is the contents of /var/log/syslog:

  Sep 30 10:32:28 russell-laptop pppd[11019]: pppd 2.4.5 started by rstuart, 
uid 0
  Sep 30 10:32:29 russell-laptop chat[11020]: send (ATZ^M)
  Sep 30 10:32:29 russell-laptop chat[11020]: expect (OK)
  Sep 30 10:32:29 russell-laptop chat[11020]: ATZ^M^M
  Sep 30 10:32:29 russell-laptop chat[11020]: OK
  Sep 30 10:32:29 russell-laptop chat[11020]:  -- got it
  Sep 30 10:32:29 russell-laptop chat[11020]: send 
(AT+CGDCONT=1,IP,internet^M)
  Sep 30 10:32:29 russell-laptop chat[11020]: expect (OK)
  Sep 30 10:32:29 russell-laptop chat[11020]: ^M
  Sep 30 10:32:29 russell-laptop chat[11020]: AT+CGDCONT=1,IP,internet^M^M
  Sep 30 10:32:29 russell-laptop chat[11020]: OK
  Sep 30 10:32:29 russell-laptop chat[11020]:  -- got it
  Sep 30 10:32:29 russell-laptop chat[11020]: send (ATD*99***1#^M)
  Sep 30 10:32:29 russell-laptop chat[11020]: expect (CONNECT)
  Sep 30 10:32:29 russell-laptop chat[11020]: ^M
  Sep 30 10:32:34 russell-laptop chat[11020]: ATD*99***1#^M^M
  Sep 30 10:32:34 russell-laptop chat[11020]: CONNECT
  Sep 30 10:32:34 russell-laptop chat[11020]:  -- got it
  Sep 30 10:32:34 russell-laptop pppd[11019]: Script /usr/sbin/chat -v -T 
internet -f /etc/ppp/peers/gprs.chat finished (pid 11020), status = 0x0
  Sep 30 10:32:34 russell-laptop pppd[11019]: Serial connection established.
  Sep 30 10:32:34 russell-laptop pppd[11019]: using channel 2
  Sep 30 10:32:34 russell-laptop pppd[11019]: Using interface ppp0
  Sep 30 10:32:34 russell-laptop pppd[11019]: Connect: ppp0 -- /dev/ttyACM0
  Sep 30 10:32:34 russell-laptop pppd[11019]: rcvd [LCP ConfReq id=0x0 auth 
pap mru 1500 asyncmap 0xa]
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [LCP ConfReq id=0x1 
asyncmap 0x0 magic 0xcfd0a8b2 pcomp accomp]
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [LCP ConfAck id=0x0 auth 
pap mru 1500 asyncmap 0xa]
  Sep 30 10:32:34 russell-laptop pppd[11019]: rcvd [LCP ConfRej id=0x1 magic 
0xcfd0a8b2 pcomp accomp]
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [LCP ConfReq id=0x2 
asyncmap 0x0]
  Sep 30 10:32:34 russell-laptop pppd[11019]: rcvd [LCP ConfAck id=0x2 
asyncmap 0x0]
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [LCP EchoReq id=0x0 
magic=0x0]
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [PAP AuthReq id=0x1 
user=russell-laptop password=hidden]
  Sep 30 10:32:34 russell-laptop pppd[11019]: rcvd [LCP EchoRep id=0x0 
magic=0x0]
  Sep 30 10:32:34 russell-laptop pppd[11019]: rcvd [PAP AuthAck id=0x1 ]
  Sep 30 10:32:34 russell-laptop pppd[11019]: PAP authentication succeeded
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [CCP ConfReq id=0x1 deflate 
15 deflate(old#) 15 bsd v1 15]
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [IPCP ConfReq id=0x1 
compress VJ 0f 01 addr 0.0.0.0 ms-dns1 0.0.0.0 ms-dns2 0.0.0.0]
  Sep 30 10:32:34 russell-laptop pppd[11019]: rcvd [IPCP ConfReq id=0x0 addr 
10.6.6.6]
  Sep 30 10:32:34 russell-laptop pppd[11019]: sent [IPCP ConfAck id=0x0 addr 
10.6.6.6]
  Sep 30 10:32:34 russell-laptop pppd[11019]: rcvd [LCP ProtRej id=0x0 80 fd 01 
01 00 0f 1a 04 78 00 18 04 78 00 15 03 2f]
  Sep 30 10:32:34 russell-laptop pppd[11019]: Protocol-Reject for 'Compression 
Control Protocol' (0x80fd) received
  Sep 30 10:32:35 russell-laptop pppd[11019]: rcvd [IPCP ConfRej id=0x1 
compress VJ 0f 01]
  Sep 30 10:32:35 russell-laptop pppd[11019]: sent [IPCP ConfReq id=0x2 addr 
0.0.0.0 ms-dns1 0.0.0.0 ms-dns2 0.0.0.0]
  Sep 30 10:32:35 russell-laptop pppd[11019]: rcvd [IPCP ConfNak id=0x2 addr 
122.110.246.41 ms-dns1 211.29.132.12 ms-dns2 61.88.88.88]
  Sep 30 10:32:35 russell-laptop pppd[11019]: sent [IPCP ConfReq id=0x3 addr 
122.110.246.41 ms-dns1 211.29.132.12 ms-dns2 61.88.88.88]
  Sep 30 10:32:35 russell-laptop pppd[11019]: rcvd [IPCP ConfAck id=0x3 addr 
122.110.246.41 ms-dns1 211.29.132.12 ms-dns2 61.88.88.88]
  Sep 30 10:32:35 russell-laptop pppd[11019]: not replacing existing default 
route via 10.7.0.2
  Sep 30 10:32:35 russell-laptop pppd[11019]: local  IP address 122.110.246.41
  Sep 30 10:32:35 russell-laptop pppd[11019]: remote IP address 10.6.6.6
  Sep 30 10:32:35 russell-laptop pppd[11019]: primary   DNS address 
211.29.132.12
  Sep 30 10:32:35 russell-laptop pppd[11019]: secondary DNS