Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Le dimanche 17 octobre 2010 à 16:58 +0200, Samuel Thibault a écrit : Samuel Thibault, le Sun 17 Oct 2010 16:06:45 +0200, a écrit : Josselin Mouette, le Mon 27 Sep 2010 18:20:38 +0200, a écrit : I would definitely accept a patch to do that. Here is the part that adds the beep. Here is the part that adds the configuration checkbox in the accessibility panel. That's in the gnome-settings-daemon package, thus cloning. Sorry but this is not going to happen. What use is there for such a configuration checkbox? Furthermore there is nothing in the patch that makes the beep actually happen. Cheers, -- .''`. Josselin Mouette : :' : `. `' “If you behave this way because you are blackmailed by someone, `-[…] I will see what I can do for you.” -- Jörg Schilling signature.asc Description: This is a digitally signed message part
Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Josselin Mouette, le Tue 19 Oct 2010 08:31:00 +0200, a écrit : Le dimanche 17 octobre 2010 à 16:58 +0200, Samuel Thibault a écrit : Samuel Thibault, le Sun 17 Oct 2010 16:06:45 +0200, a écrit : Josselin Mouette, le Mon 27 Sep 2010 18:20:38 +0200, a écrit : I would definitely accept a patch to do that. Here is the part that adds the beep. Here is the part that adds the configuration checkbox in the accessibility panel. That's in the gnome-settings-daemon package, thus cloning. Sorry but this is not going to happen. What use is there for such a configuration checkbox? Err, well, for enabling/disabling it easily, just like other accessibility features. Furthermore there is nothing in the patch that makes the beep actually happen. ?! Sure there is: that code toggles /desktop/gnome/applications/at/beep_enabled to true, which thus enables starting beep from the greeter-autostart. Samuel -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Le mardi 19 octobre 2010 à 11:57 +0200, Samuel Thibault a écrit : Sorry but this is not going to happen. What use is there for such a configuration checkbox? Err, well, for enabling/disabling it easily, just like other accessibility features. How is beeping in the *user session* an accessibility feature? Furthermore there is nothing in the patch that makes the beep actually happen. ?! Sure there is: that code toggles /desktop/gnome/applications/at/beep_enabled to true, which thus enables starting beep from the greeter-autostart. You are mixing apples (the greeter session) and oranges (the user session). The control center cannot be used to configure the greeter session, since it is not executed as the same user. Cheers, -- .''`. : :' : “You would need to ask a lawyer if you don't know `. `' that a handshake of course makes a valid contract.” `--- J???rg Schilling -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Josselin Mouette, le Tue 19 Oct 2010 13:57:59 +0200, a écrit : Le mardi 19 octobre 2010 à 11:57 +0200, Samuel Thibault a écrit : Sorry but this is not going to happen. What use is there for such a configuration checkbox? Err, well, for enabling/disabling it easily, just like other accessibility features. How is beeping in the *user session* an accessibility feature? This is not about the user session, but about the Debian-gdm session, used for gdm3. Furthermore there is nothing in the patch that makes the beep actually happen. ?! Sure there is: that code toggles /desktop/gnome/applications/at/beep_enabled to true, which thus enables starting beep from the greeter-autostart. You are mixing apples (the greeter session) and oranges (the user session). No, gdm does. It uses the Debian-gdm session for the greeter. The control center cannot be used to configure the greeter session, since it is not executed as the same user. It is, in the gdm3 case, thanks to the Debian-gdm special user. Samuel -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Samuel Thibault, le Tue 19 Oct 2010 14:07:54 +0200, a écrit : Josselin Mouette, le Tue 19 Oct 2010 13:57:59 +0200, a écrit : Le mardi 19 octobre 2010 à 11:57 +0200, Samuel Thibault a écrit : Sorry but this is not going to happen. What use is there for such a configuration checkbox? Err, well, for enabling/disabling it easily, just like other accessibility features. How is beeping in the *user session* an accessibility feature? This is not about the user session, but about the Debian-gdm session, used for gdm3. Just to make sure it's clear: at the bottom of the gdm3 screen, you have an accessibility icon, which triggers an accessibility panel that my patch is modifying. This all happens in the Debian-gdm session. Samuel -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Le mardi 19 octobre 2010 à 14:24 +0200, Samuel Thibault a écrit : Samuel Thibault, le Tue 19 Oct 2010 14:07:54 +0200, a écrit : Josselin Mouette, le Tue 19 Oct 2010 13:57:59 +0200, a écrit : Le mardi 19 octobre 2010 à 11:57 +0200, Samuel Thibault a écrit : Sorry but this is not going to happen. What use is there for such a configuration checkbox? Err, well, for enabling/disabling it easily, just like other accessibility features. How is beeping in the *user session* an accessibility feature? This is not about the user session, but about the Debian-gdm session, used for gdm3. Just to make sure it's clear: at the bottom of the gdm3 screen, you have an accessibility icon, which triggers an accessibility panel that my patch is modifying. This all happens in the Debian-gdm session. Ah, my bad. I thought this code was in the simple-greeter itself. In this case I don’t understand why you use 2 different GConf keys for that effect. You should put as much as possible of the changes in g-s-d, and just ship a different default for the greeter session - we can do so in the configuration file. I’d prefer if the beep was emitted by a new g-s-d plugin, but if done this way we could do with using beep. In this case we shouldn’t forget the correct X-GNOME-Autostart-Phase so that the beep only happens when everything else is ready. Cheers, -- .''`. : :' : “You would need to ask a lawyer if you don't know `. `' that a handshake of course makes a valid contract.” `--- J???rg Schilling -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Josselin Mouette, le Tue 19 Oct 2010 16:17:45 +0200, a écrit : In this case I don’t understand why you use 2 different GConf keys for that effect. Err, which 2 different GConf keys? I'm just using the /desktop/gnome/applications/at/beep_enabled key everywhere. You should put as much as possible of the changes in g-s-d, and just ship a different default for the greeter session - we can do so in the configuration file. I’d prefer if the beep was emitted by a new g-s-d plugin, Why doing so? Writing a plugin seems much more involved than just putting a .desktop file in gdm3, I wonder for which benefit. but if done this way we could do with using beep. Why is this case different from the .desktop file case, concerning using beep? In this case we shouldn’t forget the correct X-GNOME-Autostart-Phase so that the beep only happens when everything else is ready. Ah, I didn't know about that thing. I guess we can move gdm-simple-greeter.desktop.in to Desktop phase, and the beep task to Application phase? Samuel -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep
Le mardi 19 octobre 2010 à 16:39 +0200, Samuel Thibault a écrit : Josselin Mouette, le Tue 19 Oct 2010 16:17:45 +0200, a écrit : In this case I don’t understand why you use 2 different GConf keys for that effect. Err, which 2 different GConf keys? I'm just using the /desktop/gnome/applications/at/beep_enabled key everywhere. D’oh. Sorry, I misread that too. I’d prefer if the beep was emitted by a new g-s-d plugin, Why doing so? Writing a plugin seems much more involved than just putting a .desktop file in gdm3, I wonder for which benefit. You are adding functionality to g-s-d that only works for gdm3. That’s the path downwards confusion when you create a new configuration item that will not do anything when checked. To sum up: either you do the changes in g-s-d and have gdm set them in its GConf configuration, or you do the changes in gdm and set them in gdm’s own configuration. The latter is still my favorite, and above all I’m not for a half-baked mix of both solutions. Also note that it is quite late to introduce a new string in the configuration box. It wouldn’t be translated to more than a handful of languages at the time of the release. I’d prefer if we just stuck to making something that works - gdm2 has always beeped when ready, and I don’t recall people complaining of that. In this case we shouldn’t forget the correct X-GNOME-Autostart-Phase so that the beep only happens when everything else is ready. Ah, I didn't know about that thing. I guess we can move gdm-simple-greeter.desktop.in to Desktop phase, and the beep task to Application phase? I guess that wouldn’t work anyway, since gdm-simple-greeter doesn’t register itself to the session manager. Cheers, -- .''`. : :' : “You would need to ask a lawyer if you don't know `. `' that a handshake of course makes a valid contract.” `--- J???rg Schilling -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
