Bug#601124: munin: 1.4 regression: root is no longer a valid field name
forwarded 601124 http://munin-monitoring.org/ticket/921 thanks Hi Christoph, thanks for the bug report! On Donnerstag, 8. Dezember 2011, Christoph Biedl wrote: After upgrading a munin instance I noticed munin 1.4 doesn't draw some graphs any longer. A few hours later it turned out root is no longer an acceptable field name, probably since this has a special meaning in munin_get_keypath. This bug still exists in munin-1.999.4508-1 from experimental. Probably the fix in http://munin-monitoring.org/ticket/921 was never applied to 2.0 it was, but: r4133 | jo | 2011-01-21 16:58:32 +0100 (Fr, 21. Jan 2011) | 1 Zeile Reverted bad patch from r4131 r4131 | jo | 2011-01-20 16:55:55 +0100 (Do, 20. Jan 2011) | 1 Zeile Fixed a very silly bug, where a field couldn't be named root (#921) I've reopened the upstream ticket now and asked why it was reverted in trunk but not in the 1.4 branch. If you still got a munin 1.4 instance you could check if the fix works in 1.4.6, 1.4.6-2 is available in wheezy. cheers, Holger -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#601124: munin: 1.4 regression: root is no longer a valid field name
Holger Levsen wrote... On Donnerstag, 8. Dezember 2011, Christoph Biedl wrote: Probably the fix in http://munin-monitoring.org/ticket/921 was never applied to 2.0 it was, but: r4133 | jo | 2011-01-21 16:58:32 +0100 (Fr, 21. Jan 2011) | 1 Zeile Reverted bad patch from r4131 r4131 | jo | 2011-01-20 16:55:55 +0100 (Do, 20. Jan 2011) | 1 Zeile Fixed a very silly bug, where a field couldn't be named root (#921) OK, didn't see that. Applying that commit (some handwork required) broke the entire graph generation so that's a really bad idea. If you still got a munin 1.4 instance you could check if the fix works in 1.4.6, 1.4.6-2 is available in wheezy. In wheezy everything looks fine (at least using the static graph_strategy). Christoph -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#601124: munin: 1.4 regression: root is no longer a valid field name
Christoph Biedl wrote... After upgrading a munin instance I noticed munin 1.4 doesn't draw some graphs any longer. A few hours later it turned out root is no longer an acceptable field name, probably since this has a special meaning in munin_get_keypath. This bug still exists in munin-1.999.4508-1 from experimental. Probably the fix in http://munin-monitoring.org/ticket/921 was never applied to 2.0 Christoph signature.asc Description: Digital signature
Bug#601124: munin: 1.4 regression: root is no longer a valid field name
Package: munin
Version: 1.4.5-3
Severity: normal
After upgrading a munin instance I noticed munin 1.4 doesn't draw
some graphs any longer. A few hours later it turned out root is no
longer an acceptable field name, probably since this has a special
meaning in munin_get_keypath. Using such field names result in error
messages in munin-graph.log like (note the malformed rrd name)
2010/10/23 17:00:28 [RRD ERROR] Unable to graph
/var/cache/munin/www/(...)/fieldname_root-year.png : opening
'/var/lib/munin/--g.rrd': No such file or directory
and breaks the entire graph, not just that single data source.
How to repeat:
Use the following silly plugin, both as fieldname_root and
fieldname_Root (or anything else but root):
#!/bin/sh
case `basename $0` in
fieldname_*)
FIELDNAME=`echo $0 | sed -e 's/.*_//'`
;;
*)
exit 0
esac
if [ $1 = config ] ; then
echo graph_title field name '$FIELDNAME' constraint test
echo 'graph_vlabel something'
echo $FIELDNAME.label This is a label
exit 0
fi
echo $FIELDNAME.value 1
Expected behaviour: Two graphs showing a simple line. This works for
munin 1.2.
Observed behaviour: No graph is shown for fieldname_root.
This should be fixed ASAP since this will break all plugins in the
wild that use that field name. It seems that changing the usage of the
root label in
usr/share/perl5/Munin/Master/HTMLOld.pm:if (defined $groups-{name}
and $groups-{name} eq root) {
usr/share/perl5/Munin/Master/HTMLOld.pm:and
munin_get_node_name($parent) eq root;
usr/share/perl5/Munin/Master/LimitsOld.pm:if (defined $parent and
munin_get_node_name($parent) ne root) {
usr/share/perl5/Munin/Master/Utils.pm:$config-{'#%#name'} =
root;
usr/share/perl5/Munin/Master/Utils.pm: last if $name eq 'root';
by something different, e.g. :root works around that problem. Side
effects are not known.
Only as a last resort, update the documentation in all places,
http://munin-monitoring.org/wiki/notes_on_datasource_names
to begin with.
Christoph
-- System Information:
Debian Release: squeeze/sid
APT prefers testing
APT policy: (500, 'testing')
Architecture: i386 (i686)
Kernel: Linux 2.6.32.23
Locale: LANG=de_DE.UTF-8, LC_CTYPE=de_DE.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Versions of packages munin depends on:
ii adduser 3.112jj1 add and remove users and groups
ii cron 3.0pl1-115 process scheduling daemon
pn libdigest-md5-perlnone (no description available)
ii libhtml-template-perl 2.9-2 module for using HTML Templates wi
ii liblog-log4perl-perl 1.29-1 A Perl port of the widely popular
ii librrds-perl 1.4.3-1time-series data storage and displ
pn libstorable-perl none (no description available)
ii munin-common 1.4.5-3network-wide graphing framework (c
ii perl [libtime-hires-perl] 5.10.1-15 Larry Wall's Practical Extraction
ii perl-modules 5.10.1-15 Core Perl modules
ii rrdtool 1.4.3-1time-series data storage and displ
ii ttf-dejavu2.31-1 Metapackage to pull in ttf-dejavu-
Versions of packages munin recommends:
pn libdate-manip-perlnone (no description available)
pn munin-nodenone (no description available)
Versions of packages munin suggests:
ii apache2-mpm-prefork [httpd] 2.2.16-3 Apache HTTP Server - traditional n
pn libnet-ssleay-perl none (no description available)
ii links [www-browser] 2.3~pre1-1 Web browser running in text mode
ii lynx-cur [www-browser] 2.8.8dev.5-1 Text-mode WWW Browser with NLS sup
ii w3m [www-browser] 0.5.2-9 WWW browsable pager with excellent
-- no debconf information
signature.asc
Description: Digital signature
