Bug#602331: plymouth does not allow to enter maintenance shell

[Ben Hutchings]

On Sun, 15 Nov 2015 13:12:07 +0100 Laurent Bigonville  wrote:
[...]
> I think we could split that in two different issues, I've cloned this 
> bug, see: #805155
> 
> The attached patch is calling the new "panic" scripts just before 
> dropping to a shell, this can be then used by plymouth package to ensure 
> the plymouth daemon is killed/the splash hidden

Looks good, but could you re-send with a Developer's Certificate of
Origin (Signed-off-by line)?

Ben.
 
-- 
Ben Hutchings
Larkinson's Law: All laws are basically false.

signature.asc
Description: This is a digitally signed message part

Bug#602331: plymouth does not allow to enter maintenance shell

[Laurent Bigonville]

tag 602331 + patch
thanks

On Sat, 30 Aug 2014 23:27:47 +0200 Michael Prokop  wrote:
> Hi,

Hi,

> * Laurent Bigonville [Fri Aug 01, 2014 at 03:55:17PM +0200]:
>
> > An idea on how this could be fixed? In Ubuntu they have added a "panic"
> > hook to initramfs-tools that is being called in the "panic()" function.
> > Do you think it's the way to go here?
>
> > Otherwise I can also provide a patch for the same function to directly
> > call the needed plymouth command ("plymouth quit")
>
> I just took a look at Ubuntu's i-t and their try_failure_hooks
> function with features related to plymouth etc totally makes sense
> for me, I'd love to see that in Debian's i-t as well, so if anyone
> is willing to work on it you'd have my full support for that.

I think we could split that in two different issues, I've cloned this 
bug, see: #805155


The attached patch is calling the new "panic" scripts just before 
dropping to a shell, this can be then used by plymouth package to ensure 
the plymouth daemon is killed/the splash hidden


Cheers,

Laurent Bigonville


>From e666c9f267d73f5b3d434369d9efc5b7f9210e66 Mon Sep 17 00:00:00 2001
From: Laurent Bigonville 
Date: Sun, 15 Nov 2015 12:58:27 +0100
Subject: [PATCH] Run new panic scripts just before dropping to a shell

These panic scripts are run just before dropping to a shell, these can
be use for example to disable a splash screen.

Taken from Ubuntu

Closes: #602331
---
 debian/initramfs-tools.dirs | 1 +
 scripts/functions   | 3 +++
 2 files changed, 4 insertions(+)

diff --git a/debian/initramfs-tools.dirs b/debian/initramfs-tools.dirs
index 0f63f2f..bcb978b 100644
--- a/debian/initramfs-tools.dirs
+++ b/debian/initramfs-tools.dirs
@@ -7,6 +7,7 @@ etc/initramfs-tools/scripts/local-top
 etc/initramfs-tools/scripts/nfs-bottom
 etc/initramfs-tools/scripts/nfs-premount
 etc/initramfs-tools/scripts/nfs-top
+etc/initramfs-tools/scripts/panic
 etc/initramfs-tools/hooks
 etc/initramfs-tools/conf.d
 usr/share/initramfs-tools/conf.d
diff --git a/scripts/functions b/scripts/functions
index a347264..33fddcf 100644
--- a/scripts/functions
+++ b/scripts/functions
@@ -53,6 +53,9 @@ panic()
 	modprobe -v uhci-hcd || true
 	modprobe -v ohci-hcd || true
 	modprobe -v usbhid || true
+
+	run_scripts /scripts/panic
+
 	REASON="$@" PS1='(initramfs) ' /bin/sh -i /dev/console 2>&1
 }
 
-- 
2.6.2

Bug#602331: plymouth does not allow to enter maintenance shell

[Gavin Lambert]

On Sat, 30 Aug 2014 23:27:47 +0200 Michael Prokop m...@debian.org wrote: 
 * Laurent Bigonville [Fri Aug 01, 2014 at 03:55:17PM +0200]: 
 
  An idea on how this could be fixed? In Ubuntu they have added a panic 
  hook to initramfs-tools that is being called in the panic() function. 
  Do you think it's the way to go here? 
 
  Otherwise I can also provide a patch for the same function to directly 
  call the needed plymouth command (plymouth quit) 
 
 I just took a look at Ubuntu's i-t and their try_failure_hooks 
 function with features related to plymouth etc totally makes sense 
 for me, I'd love to see that in Debian's i-t as well, so if anyone 
 is willing to work on it you'd have my full support for that. 

I just encountered similar behaviour.  panic() really needs to call
plymouth quit before trying to do anything else.

Ubuntu's initramfs-tools has a system for running scripts on panic, which
Ubuntu's plymouth makes use of to do exactly this.  Any chance this can be
imported into Debian?  It seems fairly straightforward.


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Michael Prokop]

Hi,

* Laurent Bigonville [Fri Aug 01, 2014 at 03:55:17PM +0200]:

 An idea on how this could be fixed? In Ubuntu they have added a panic
 hook to initramfs-tools that is being called in the panic() function.
 Do you think it's the way to go here?

 Otherwise I can also provide a patch for the same function to directly
 call the needed plymouth command (plymouth quit)

I just took a look at Ubuntu's i-t and their try_failure_hooks
function with features related to plymouth etc totally makes sense
for me, I'd love to see that in Debian's i-t as well, so if anyone
is willing to work on it you'd have my full support for that.

regards,
-mika-


signature.asc
Description: Digital signature

Bug#602331: plymouth does not allow to enter maintenance shell

[Laurent Bigonville]

Hello,

An idea on how this could be fixed? In Ubuntu they have added a panic
hook to initramfs-tools that is being called in the panic() function.
Do you think it's the way to go here?

Otherwise I can also provide a patch for the same function to directly
call the needed plymouth command (plymouth quit)

Cheers,

Laurent Bigonville


-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Laurent Bigonville]

reassign 602331 initramfs-tools 0.106
affects 602331 plymouth
thanks

Hi,

I'm reassigning this to initramfs-tools so the panic() function can be
fixed to add the proper call to disable the splash screen.

Cheers

Laurent Bigonville



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Laurent Bigonville]

Package: plymouth
Followup-For: Bug #602331

Hi,

I think that plymouth --hide-splash should explicitly be called in the
panic() function of /usr/share/initramfs-tools/scripts/functions file.

Cheers

Laurent Bigonville

-- System Information:
Debian Release: wheezy/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.4-trunk-amd64 (SMP w/4 CPU cores)
Locale: LANG=fr_BE.utf8, LC_CTYPE=fr_BE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages plymouth depends on:
ii  initramfs-tools  0.106
ii  libc62.13-33

plymouth recommends no packages.

plymouth suggests no packages.

-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Arno Töll]

-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1

Hello,

I noticed earlier today, the problem still persists. Whenever Linux
drops the user into an emergency shell (you know the Give root password
for maintenance (or type Control-D to continue) dialog), this breaks
Plymouth.

This just blocks Plymouth forever. As it was mentioned earlier, even
worse, you can't use the shell Linux offers you as it is not possible to
enter the password and/or make use of the shell.

The only possibility to solve the problem is to do a reboot by hitting
the reboot button and booting with a nosplash kernel command line that
time.

I confirm this behavior for plymouth 0.8.3-20. To reproduce the issue
just provoke a problem e2fsck can't automatically solve. For example
change the system time to a date in the past (which is before the last
saved mount time in the metadata) and reboot.
- -- 
with kind regards,
Arno Töll
IRC: daemonkeeper on Freenode/OFTC
GnuPG Key-ID: 0x9D80F36D
-BEGIN PGP SIGNATURE-
Version: GnuPG v1.4.11 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQIcBAEBAgAGBQJOrG/WAAoJEMcrUe6dgPNtk1gQAKIppK2RAOs9+eUmZ2KmfFk5
44U1hznQQ9vYkg8WxsYcnm79i9dGuC5plMewizv4jOwS4Nt0pGGu9isCx67IdBDi
v+duEB16ElPV074YLki7VH+Lg0MhLMXmbJJsy0V9vzEejrdlknQfHg8dazOfwQTR
ZiBcHMyw38YmKWUNmy82lSt+1jYvbuiEqYlXTvBXpR2j7g28Ap1p3MHMGOG8nNQV
NENFc8j/RX8hnJAzfbDx4KFc9F3TFZHUTo0oLGdWksSbuVG1coyQnwEK/iJaG01p
HEvf/azBB3UcljaXR8/bauzOmaadrETdhQ/8L6DFfsfepJFUL9zA572uZM6sXzNO
KedMos7ZTIJGob+2I00W+il7hE9cRzAx039xno/xHR3rgeQCpectY3ejfXyhc/BK
j0txGy5YZDf2giKY9rpz6IRXHCiBFQTqxwJINoRHxr5300GYDZy9Ky27l3kEaUnX
l1GkHbjUCwl2fWT9/0h/QQgn3dGLaf24VnRcHpzmL/aspvyjt4C6HM4tJ5WMLyxB
ooZw4lfgwIJLcVEcGWjV0OSxUwbOEsbIYKnEkhORIhsta6ZQ81edyYJrvVqCG85p
bPbSXat6bl7ExmC8q8De+jl01RAqJWl1G7iiD9QoQxBtNivO3enfi8MmWdb2IV3u
0Z3+H27ycIewB1jj6ab4
=Ps5n
-END PGP SIGNATURE-



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Maximilian Gaukler]

Package: plymouth
Version: 0.8.3-9.1

I had similar problems in single-user mode. Using a shell was impossible, as I 
could only type one character.
Only the text mode theme was active. I ended up uninstalling plymouth, which is 
sad because it seems to be the only bootsplash possibility in squeeze.

Max



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Christian Meyer]

Am Donnerstag, den 04.11.2010, 20:53 +0100 schrieb Julien Cristau:
 On Thu, Nov  4, 2010 at 20:47:10 +0100, Christian Meyer wrote:
 
  Do you have a suggestion how to force the maintenance shell at boot time?
  However. I will install 0.8.3-17 and wait for the next filesystem 
  inconsistency. 
  
 I suppose you could change the root= parameter in grub so the initramfs
 can't find the root device and gets you to the maintenance shell?

Sorry, this didn't work. I gave invalid (e.g. /abc) and wrong
(e.g. /home) parameters, but my system booted without maintenance shell
(only a kernel panic once).
Even creating /forcefsck and then powering off by unplugging power
supply (while copying a large file to /) didn't work (yet).
I will go on trying and report it when maintenance shell appear.

Christian




-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Julien Cristau]

Hi Christian,

On Wed, Nov  3, 2010 at 20:31:38 +0100, Christian Meyer wrote:

 First plymouth problem (maybe a feature or not implemented yet):
 The plymouth theme runs (and runs and runs ...) and gives no hint that
 something is wrong. Only after pressing ESC you realize that there is a
 problem.
 
 Second problem (really annoying and important):
 I see the following lines (probably from init):
 Give root password for maintenance
 (or type Control-D to continue)
 
 When I want to enter my password after every single key the input is aborted
 (nothing displayed) and a new line shows up:
 
 Give root password for maintenance
 (or type Control-D to continue)
 
 The only way I found to work around is:
 Restart and remove the kernel boot option splash in grub.
 Then I'm able to enter my password.
 
Are both those problems reproducible in plymouth 0.8.3-17 (in unstable)?

Cheers,
Julien


signature.asc
Description: Digital signature

Bug#602331: plymouth does not allow to enter maintenance shell

[Julien Cristau]

On Thu, Nov  4, 2010 at 20:47:10 +0100, Christian Meyer wrote:

 Hello Julien,
 
 I would be glad to find out if the two issues are still in plymouth 0.8.3-17.
 Since I don't know much about filesystems (and I don't want to crash my 
 encrypted LVM)
 I have no glue how to damage my root partition just that little bit that is 
 needed to
 cause init to call the maintenance shell. Just forcing fsck at boot probably 
 will not find any error.
 
 Do you have a suggestion how to force the maintenance shell at boot time?
 However. I will install 0.8.3-17 and wait for the next filesystem 
 inconsistency. 
 
I suppose you could change the root= parameter in grub so the initramfs
can't find the root device and gets you to the maintenance shell?

Cheers,
Julien


signature.asc
Description: Digital signature

Bug#602331: plymouth does not allow to enter maintenance shell

[Christian Meyer]

Hello Julien,

I would be glad to find out if the two issues are still in plymouth 0.8.3-17.
Since I don't know much about filesystems (and I don't want to crash my 
encrypted LVM)
I have no glue how to damage my root partition just that little bit that is 
needed to
cause init to call the maintenance shell. Just forcing fsck at boot probably 
will not find any error.

Do you have a suggestion how to force the maintenance shell at boot time?
However. I will install 0.8.3-17 and wait for the next filesystem 
inconsistency. 

Christian
___
GRATIS! Movie-FLAT mit über 300 Videos. 
Jetzt freischalten unter http://movieflat.web.de



--
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org

Bug#602331: plymouth does not allow to enter maintenance shell

[Christian Meyer]

Package: plymouth
Version: 0.8.3-9.1
Severity: important

Hello there,

For some reason my root filesystem (ext3 on encrypted lvm) had some errors and
fsck could not fix them automatically. Then a maintenance shell should be
started to solve the problem manually.

First plymouth problem (maybe a feature or not implemented yet):
The plymouth theme runs (and runs and runs ...) and gives no hint that
something is wrong. Only after pressing ESC you realize that there is a
problem.



Second problem (really annoying and important):
I see the following lines (probably from init):
Give root password for maintenance
(or type Control-D to continue)

When I want to enter my password after every single key the input is aborted
(nothing displayed) and a new line shows up:

Give root password for maintenance
(or type Control-D to continue)

The only way I found to work around is:
Restart and remove the kernel boot option splash in grub.
Then I'm able to enter my password.

Christian Meyer



-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (500, 'testing')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.32-5-amd64 (SMP w/2 CPU cores)
Locale: LANG=de_DE.utf8, LC_CTYPE=de_DE.utf8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash

Versions of packages plymouth depends on:
ii  initramfs-tools0.98.5tools for generating an initramfs
ii  libc6  2.11.2-6+squeeze1 Embedded GNU C Library: Shared lib
ii  libcairo2  1.8.10-6  The Cairo 2D vector graphics libra
ii  libdrm-intel1  2.4.21-1~squeeze3 Userspace interface to intel-speci
ii  libdrm-nouveau12.4.21-1~squeeze3 Userspace interface to nouveau-spe
ii  libdrm-radeon1 2.4.21-1~squeeze3 Userspace interface to radeon-spec
ii  libdrm22.4.21-1~squeeze3 Userspace interface to kernel DRM 
ii  libglib2.0-0   2.24.2-1  The GLib library of C routines
ii  libpango1.0-0  1.28.3-1  Layout and rendering of internatio
ii  libpng12-0 1.2.44-1  PNG library - runtime

Versions of packages plymouth recommends:
ii  fontconfig-config 2.8.0-2.1  generic font configuration library
ii  plymouth-themes-all   0.8.3-9.1  Graphical Boot Animation and Logge
ii  ttf-dejavu-core   2.31-1 Vera font family derivate with add

Versions of packages plymouth suggests:
pn  gdm   none (no description available)

-- Configuration Files:
/etc/plymouth/plymouthd.conf changed:
[Daemon]
Theme=spinfinity


-- no debconf information



-- 
To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org
with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org