Bug#606642: lilypond: fails to build with G++ 4.5
On Sat, 27 Aug 2011, Jonathan Nieder wrote: I'd be willing to test, and even to fix if it turns out to be easy. :) Is the package in preparation available somewhere? It seems to be compiling ok now; I'm just wrangling some of the remaining issues before uploading. Don Armstrong -- She was alot like starbucks. IE, generic and expensive. -- hugh macleod http://www.gapingvoid.com/Moveable_Type/archives/001376.html http://www.donarmstrong.com http://rzlab.ucr.edu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#606642: lilypond: fails to build with G++ 4.5
Hi, Don Armstrong wrote: On Fri, Dec 10, 2010 at 16:53:42 -0800, Don Armstrong wrote: #lilypond (2.12.3-8) UNRELEASED; urgency=low # # * Apply patch from 77c34ddc (Werner Lemberg w...@gnu.org) to fix compilation with g++ 4.5 (Closes: #606642). #Thanks to Colin Watson for an alternative patch. # limit source lilypond tags 606642 + pending [...] There's actually something which is segfaulting in the stack and causing FTBFS; need to track that down first. I'd be willing to test, and even to fix if it turns out to be easy. :) Is the package in preparation available somewhere? Thanks, Jonathan -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#606642: lilypond: fails to build with G++ 4.5
Package: lilypond Version: 2.12.3-7 Severity: normal Tags: patch User: ubuntu-de...@lists.ubuntu.com Usertags: origin-ubuntu ubuntu-patch natty In Ubuntu natty, lilypond fails to build as follows: spacing-spanner.cc: In static member function 'static std::vectorGrob* Spacing_spanner::get_columns(Grob*)': spacing-spanner.cc:41:35: error: expected primary-expression before '*' token spacing-spanner.cc:41:36: error: expected primary-expression before '' token C++ is not my first language, but I think that you're not meant to call template constructors this way; perhaps this worked by chance with previous versions of G++? It seems easier to use the declarator syntax and just create a new variable rather than reusing 'all', since it's only a local variable and we're about to return anyway. === modified file 'lily/spacing-spanner.cc' --- lily/spacing-spanner.cc 2010-03-04 08:38:33 + +++ lily/spacing-spanner.cc 2010-12-10 14:11:29 + @@ -38,9 +38,8 @@ Spacing_spanner::get_columns (Grob *me_g vsize end = binary_search (all, (Grob*) me-get_bound (RIGHT), Paper_column::less_than); - all = vectorGrob*::vectorGrob* (all.begin () + start, - all.begin () + end + 1); - return all; + vectorGrob* ret (all.begin () + start, all.begin () + end + 1); + return ret; } MAKE_SCHEME_CALLBACK (Spacing_spanner, set_springs, 1); Thanks, -- Colin Watson [cjwat...@ubuntu.com] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#606642: lilypond: fails to build with G++ 4.5
On Fri, 10 Dec 2010, Colin Watson wrote: C++ is not my first language, but I think that you're not meant to call template constructors this way; perhaps this worked by chance with previous versions of G++? It seems easier to use the declarator syntax and just create a new variable rather than reusing 'all', since it's only a local variable and we're about to return anyway. Thanks for the report and patch; what I'm going to apply is what upstream did[1]: index 8e613e6..6ec8108 100644 (file) --- a/lily/spacing-spanner.cc +++ b/lily/spacing-spanner.cc @@ -49,8 +49,8 @@ Spacing_spanner::get_columns (Grob *me_grob) vsize end = binary_search (all, (Grob*) me-get_bound (RIGHT), Paper_column::less_than); - all = vectorGrob*::vectorGrob* (all.begin () + start, - all.begin () + end + 1); + all = vectorGrob* (all.begin () + start, + all.begin () + end + 1); return all; } but it resolves the same thing. Don Armstrong 1: http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commitdiff;h=77c34ddc0877c0625a48e1b41049b6dbaae215e0;hp=d2a42896a11c3287b746076299f8d4aeb4d3664a -- Every gun that is made, every warship launched, every rocket fired signifies [...] a theft from those who hunger and are not fed, those who are cold and are not clothed. This world in arms is not spending money alone. It is spending the sweat of its laborers, the genius of its scientists, the hopes of its children. [...] This is not a way of life at all in any true sense. Under the cloud of threatening war, it is humanity hanging from a cross of iron. [...] [I]s there no other way the world may live? -- President Dwight D. Eisenhower, April 16, 1953 http://www.donarmstrong.com http://rzlab.ucr.edu -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
Bug#606642: lilypond: fails to build with G++ 4.5
On Fri, Dec 10, 2010 at 04:18:45PM -0800, Don Armstrong wrote: On Fri, 10 Dec 2010, Colin Watson wrote: C++ is not my first language, but I think that you're not meant to call template constructors this way; perhaps this worked by chance with previous versions of G++? It seems easier to use the declarator syntax and just create a new variable rather than reusing 'all', since it's only a local variable and we're about to return anyway. Thanks for the report and patch; what I'm going to apply is what upstream did[1]: index 8e613e6..6ec8108 100644 (file) --- a/lily/spacing-spanner.cc +++ b/lily/spacing-spanner.cc @@ -49,8 +49,8 @@ Spacing_spanner::get_columns (Grob *me_grob) vsize end = binary_search (all, (Grob*) me-get_bound (RIGHT), Paper_column::less_than); - all = vectorGrob*::vectorGrob* (all.begin () + start, - all.begin () + end + 1); + all = vectorGrob* (all.begin () + start, + all.begin () + end + 1); return all; } but it resolves the same thing. Works either way, yes. Thanks! -- Colin Watson [cjwat...@ubuntu.com] -- To UNSUBSCRIBE, email to debian-bugs-dist-requ...@lists.debian.org with a subject of unsubscribe. Trouble? Contact listmas...@lists.debian.org
